[libvirt PATCH 00/10] virHashNew refactorings - part II

Tim Wiederhake posted 10 patches 2 years, 8 months ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20210709082739.29043-1-twiederh@redhat.com
There is a newer version of this series
src/qemu/qemu_monitor.c          |  9 +++------
src/util/viriptables.c           | 20 +++++---------------
tests/nwfilterxml2firewalltest.c | 18 ++++++------------
3 files changed, 14 insertions(+), 33 deletions(-)
[libvirt PATCH 00/10] virHashNew refactorings - part II
Posted by Tim Wiederhake 2 years, 8 months ago
"virHashNew" cannot return NULL, yet we check for NULL in various places.

See https://listman.redhat.com/archives/libvir-list/2021-July/msg00074.html.

Tim Wiederhake (10):
  virNWFilterCreateVarsFrom: `virHashNew` cannot return NULL
  virNWFilterCreateVarsFrom: Use automatic memory management
  virNWFilterCreateVarsFrom: Remove superfluous `goto`s
  virNWFilterRuleDefToRuleInst: `virHashNew` cannot return NULL
  iptablesPrivateChainCreate: `virHashNew` cannot return NULL
  iptablesPrivateChainCreate: Use automatic memory management
  iptablesPrivateChainCreate: Remove superfluous `goto`s
  qemuMonitorGetMemoryDeviceInfo: Assign hash table only on success
  qemuMonitorGetMemoryDeviceInfo: Use automatic memory management
  qemuMonitorGetMemoryDeviceInfo: `virHashNew` cannot return NULL

 src/qemu/qemu_monitor.c          |  9 +++------
 src/util/viriptables.c           | 20 +++++---------------
 tests/nwfilterxml2firewalltest.c | 18 ++++++------------
 3 files changed, 14 insertions(+), 33 deletions(-)

-- 
2.31.1


Re: [libvirt PATCH 00/10] virHashNew refactorings - part II
Posted by Peter Krempa 2 years, 8 months ago
On Fri, Jul 09, 2021 at 10:27:29 +0200, Tim Wiederhake wrote:
> "virHashNew" cannot return NULL, yet we check for NULL in various places.
> 
> See https://listman.redhat.com/archives/libvir-list/2021-July/msg00074.html.
> 
> Tim Wiederhake (10):
>   virNWFilterCreateVarsFrom: `virHashNew` cannot return NULL
>   virNWFilterCreateVarsFrom: Use automatic memory management
>   virNWFilterCreateVarsFrom: Remove superfluous `goto`s
>   virNWFilterRuleDefToRuleInst: `virHashNew` cannot return NULL
>   iptablesPrivateChainCreate: `virHashNew` cannot return NULL
>   iptablesPrivateChainCreate: Use automatic memory management
>   iptablesPrivateChainCreate: Remove superfluous `goto`s
>   qemuMonitorGetMemoryDeviceInfo: Assign hash table only on success
>   qemuMonitorGetMemoryDeviceInfo: Use automatic memory management
>   qemuMonitorGetMemoryDeviceInfo: `virHashNew` cannot return NULL

Series:

Reviewed-by: Peter Krempa <pkrempa@redhat.com>