From nobody Mon Feb 9 15:45:23 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=126.com Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1625649544246993.8763440404321; Wed, 7 Jul 2021 02:19:04 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-304-o5aJsQK4PnCB5YaQ962Ctg-1; Wed, 07 Jul 2021 05:19:01 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 116641B18BC8; Wed, 7 Jul 2021 09:18:56 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E76C65C1D5; Wed, 7 Jul 2021 09:18:55 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 681314EA37; Wed, 7 Jul 2021 09:18:55 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 1679IfDx012760 for ; Wed, 7 Jul 2021 05:18:41 -0400 Received: by smtp.corp.redhat.com (Postfix) id 9FE8710F26F8; Wed, 7 Jul 2021 09:18:41 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast04.extmail.prod.ext.rdu2.redhat.com [10.11.55.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9B50C10F26F2 for ; Wed, 7 Jul 2021 09:18:38 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id B9685108BDA5 for ; Wed, 7 Jul 2021 09:18:38 +0000 (UTC) Received: from m15113.mail.126.com (m15113.mail.126.com [220.181.15.113]) by relay.mimecast.com with ESMTP id us-mta-559-eyH-WQfKPn-tAKkruBB0NQ-1; Wed, 07 Jul 2021 05:18:36 -0400 Received: from zhangjl0200.home.langchao.com (unknown [58.56.96.27]) by smtp3 (Coremail) with SMTP id DcmowAD3_wtfceVga0SWSw--.5650S5; Wed, 07 Jul 2021 17:18:27 +0800 (CST) X-MC-Unique: o5aJsQK4PnCB5YaQ962Ctg-1 X-MC-Unique: eyH-WQfKPn-tAKkruBB0NQ-1 From: zhangjl02 To: libvir-list@redhat.com Subject: [PATCHv3 3/4] qemu: interface: remove setting noqueue for ovs port Date: Wed, 7 Jul 2021 17:18:18 +0800 Message-Id: <20210707091819.1861-4-jx8zjs@126.com> In-Reply-To: <20210707091819.1861-1-jx8zjs@126.com> References: <20210707091819.1861-1-jx8zjs@126.com> MIME-Version: 1.0 X-CM-TRANSID: DcmowAD3_wtfceVga0SWSw--.5650S5 X-Coremail-Antispam: 1Uf129KBjvdXoWrZF45GF18Xry3CF1UJrW7CFg_yoWfZrg_Aa y8Zw4jgF4kGF43ArW7Zay3XryIkrs8Ja1kWa4vq3ZrJF4rCw4rJFsxZws3Zw1Uua47WFWx XFs7W343A3srCjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IUnZNVJUUUUU== X-Originating-IP: [58.56.96.27] X-CM-SenderInfo: dm0y6ybv6rjloofrz/1tbiFwPISFpEBrHrvwAAsp X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-loop: libvir-list@redhat.com Cc: shenjiatong@inspur.com, zhangjl02@inspur.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1625649544888100001 Content-Type: text/plain; charset="utf-8" From: zhangjl02 Return 0 directly if the port is ovs managed. When the ovs port is set noqueue, qos config on this port will not work. --- diff to v2: - remove "actualType" argument --- src/qemu/qemu_domain.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 8488f58e09..bb529cc987 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -11527,7 +11527,8 @@ qemuDomainInterfaceSetDefaultQDisc(virQEMUDriver *d= river, actualType =3D=3D VIR_DOMAIN_NET_TYPE_NETWORK || actualType =3D=3D VIR_DOMAIN_NET_TYPE_BRIDGE || actualType =3D=3D VIR_DOMAIN_NET_TYPE_DIRECT) { - if (virNetDevBandwidthSetRootQDisc(net->ifname, "noqueue") < 0) + if (!virDomainNetDefIsOvsport(net) && + virNetDevBandwidthSetRootQDisc(net->ifname, "noqueue") < 0) return -1; } =20 --=20 2.30.2.windows.1