From nobody Mon Feb 9 13:57:43 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=quarantine dis=quarantine) header.from=suse.com Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1625606023091446.58174167505524; Tue, 6 Jul 2021 14:13:43 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-214-oJCJPce7PQyzAjh8yFXprQ-1; Tue, 06 Jul 2021 17:13:40 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2323B824F88; Tue, 6 Jul 2021 21:13:35 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 003EA2C6EE; Tue, 6 Jul 2021 21:13:34 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id BCA601809CB5; Tue, 6 Jul 2021 21:13:34 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 166LDEel014896 for ; Tue, 6 Jul 2021 17:13:15 -0400 Received: by smtp.corp.redhat.com (Postfix) id BED86200E4A7; Tue, 6 Jul 2021 21:13:14 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast02.extmail.prod.ext.rdu2.redhat.com [10.11.55.18]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4735E200ACB2 for ; Tue, 6 Jul 2021 21:13:11 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 0FBC4800B28 for ; Tue, 6 Jul 2021 21:13:11 +0000 (UTC) Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-312-eTyGh6fdMWu-Ly28z5ZVww-1; Tue, 06 Jul 2021 17:13:08 -0400 Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-am5eur03lp2053.outbound.protection.outlook.com [104.47.8.53]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-19-82rkeXW2PG2EKOUR2yemEA-2; Tue, 06 Jul 2021 23:13:06 +0200 Received: from AM8PR04MB7970.eurprd04.prod.outlook.com (2603:10a6:20b:24f::9) by AM4PR0401MB2354.eurprd04.prod.outlook.com (2603:10a6:200:54::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.31; Tue, 6 Jul 2021 21:13:02 +0000 Received: from AM8PR04MB7970.eurprd04.prod.outlook.com ([fe80::a835:c9e1:adaf:572c]) by AM8PR04MB7970.eurprd04.prod.outlook.com ([fe80::a835:c9e1:adaf:572c%7]) with mapi id 15.20.4287.033; Tue, 6 Jul 2021 21:13:02 +0000 Received: from localhost (192.225.177.165) by FR3P281CA0009.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1d::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4308.8 via Frontend Transport; Tue, 6 Jul 2021 21:13:01 +0000 X-MC-Unique: oJCJPce7PQyzAjh8yFXprQ-1 X-MC-Unique: eTyGh6fdMWu-Ly28z5ZVww-1 X-MC-Unique: 82rkeXW2PG2EKOUR2yemEA-2 From: Jim Fehlig To: libvir-list@redhat.com Subject: [PATCH 1/6] libxl: Drop unused 'cfg' parameter from libxlDomainSaveImageOpen Date: Tue, 6 Jul 2021 15:12:50 -0600 Message-ID: <20210706211255.8891-2-jfehlig@suse.com> In-Reply-To: <20210706211255.8891-1-jfehlig@suse.com> References: <20210706211255.8891-1-jfehlig@suse.com> X-ClientProxiedBy: FR3P281CA0009.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1d::8) To AM8PR04MB7970.eurprd04.prod.outlook.com (2603:10a6:20b:24f::9) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0e694113-436e-4062-f1c2-08d940c2d6ea X-MS-TrafficTypeDiagnostic: AM4PR0401MB2354: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:404 X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0 X-Microsoft-Antispam-Message-Info: OR3r4P4Az5u+yuPbDnCREloIREhnlPe0d182p+dOgMxYP4zNzKKHd8if/ZBOvzj/4SR73V9sBijC2ghPaYumnmkodm3fFOHRn+T3mt/N2oObNAcPsg59sOwqIEe2g+FqNNqshvx8dibXq9Wk1auFujb5e5wMBC9xnqaJMmQDkJ9wnZxHo/AMCwVJGKPJ/zaRtj0VDoOrUiAC/jYh+EBBPBQdYiX5KM9p+IhsBGf4jpnTNEJz8U2HCnlbUKhrz4A6UFwtHIKia2XlsRE1mO6lSfy6urMSP+au1fCxpDUo4cNY521KtTsL5EIOecjxooQO1rsL66oFUNWCtxYiHvdSpSvb6mjAxnNcFJfH7+vVUEreqQJQSGHWDPTi3VQorQdLm3UKSAZmL/sGtEmBCO+Rivqh5V10c3AWCqParviNiEY6l4mD5de2tsQ7ZflG5sHfLw3nEtNaNA4lmGesHQqMu0LT7rMOiWgF10KGM8YDlKpaODiGsDEVA5I78Y0sXErAgCnZ2Eqjx0AJ+jjKbiQTcTheygFCOcOOhZNJC/BeDYW65gjNqV2NaPn6PGpiS2HLBpEpgKgzv/hkFwDttn3/CPuE/LLvu6Dr2y58IKUglukoWy//QBYlHJYtqp2ko2u3sjg+Lrm+w44wyIVQ+kDV5ssaZtf3QQLcj5vXeZYtVlg+x0YRt1LwFznNOBmWeXv3EuwGINMdcEO5mM1e1s8JcA3Ar6R5uIhWzpMzN2CjlvA= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM8PR04MB7970.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(136003)(376002)(346002)(396003)(39840400004)(366004)(478600001)(6916009)(186003)(26005)(956004)(8936002)(2616005)(6496006)(2906002)(83380400001)(5660300002)(8676002)(316002)(6486002)(1076003)(66556008)(38100700002)(66476007)(66946007)(36756003)(6666004)(86362001)(145543001)(145603002); DIR:OUT; SFP:1101 X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?xgKX1vNP66xsTlZaw2I+I6HR6wL2Qr4HfZ7brAt/ZL+NFSS4D+/9DICokCYv?= =?us-ascii?Q?U3Beu3tlJOVijQgAHieXJQ4o2/hYdqS3gCxjhXYlG5LJbx4ib4eFu/t5CvO2?= =?us-ascii?Q?tTD0LgFRyqTN8whRqDBZqvhCKum5zAuuc5DAitfuWUk4WeIFZ4Xl9sLyRJBZ?= =?us-ascii?Q?naGuDFOTriacAXLiZ3sIKBMjZ848CmMeSJG77k/aqbWdDuRDz+KtpaFpSEh7?= =?us-ascii?Q?nMqPCBA8yHeXZ3ofpUPmARNZWdTUQdX+5AWn003pW0Be1iOs4x97c7vFUC/4?= =?us-ascii?Q?9Bx5W7CBuBvvGo36s9XnBW3+hsRYqNDGMkXK9e4QbOFr3Ru+3fP/UIrNV9GM?= =?us-ascii?Q?pjgDUVLiepp9HHfn8kEY/8DrNgYsgfG/tVP43NlrV24EJEzeiW7hqUuUhVwm?= =?us-ascii?Q?+P4RsjNA7uZLhn1ENc7R+QuF2zMxipIGJWtIglhq/mlZMSq5vSCpIchKcX1k?= =?us-ascii?Q?X7VJjrhNCElsvWEU9Ts/JfYlbm7R1Ho14NFFZAFIzbDx6/x0JDlzoYWnXEgY?= =?us-ascii?Q?LaAnH2y4rfzekAZJopvyBniH9mAd43BgmauAXU4TetYCg2HUlDcdY3XdNY+y?= =?us-ascii?Q?VFTRBCp5EgJ+RxVSiLOsecAIX1bZfYjAeQJKd45fxe7Aj+FZkpqszbzZdt0f?= =?us-ascii?Q?FHpJ/ffd7Yp5n5ylbJzNrhInBbZghE3LFDht6lLJ7EoAjzvNjnhU6HY1+88Z?= =?us-ascii?Q?vguXpVqT/PZhaVa8njmqB5YEKGQvPAMFoNLBRFqX1RUlA3uSwErcWxXZ9Rlx?= =?us-ascii?Q?Grs7rKQU9fD0Tc4a1O+zda2Q7TUTLv3a3qyfdwXd07HQynG15AU5wF+y17DM?= =?us-ascii?Q?d0+QOWJG141zVoPw+c6ULBQTEzEdb0OrmLKYQ9vrW/lRwJatqqWXD0D7L+Q8?= =?us-ascii?Q?RkKzqRzqxvyAK0CRtf2+L5xSVDhhvLMgtYcdnKA/NY+gA7/PuFcqsXAUg8ZA?= =?us-ascii?Q?oO+mGLijBKiMxW7sCwlTm3P8O9hsEM7mOuvEhFvI4vVSrotHkYL5shFVonFC?= =?us-ascii?Q?QwLi0VTK27xfPXxTtyvLTtADAJiFrmOjKeLMIYs2rxP3aA09VRyojoIAehex?= =?us-ascii?Q?x6Hp5cDyro/vOiiPlj1t4o111OOi7WJK7TCRUIglu0y/OD6il/kKDQZPfiY9?= =?us-ascii?Q?57Z54JarQL/+w2gTNSnPGhOQgO7baqcHf+YpTTD4/oA38AgxiQmlX2xbURhu?= =?us-ascii?Q?ZXiCDaTs9JdM6PrpzuQWmvQjy3P9qiYyLNNIbVyM1ivrqDfzhSlv8fQXXfQP?= =?us-ascii?Q?fLab0mOKeWSJ4HoqD+cul5t6Gz3n9abVRXYdrEGJpn312STPRGVqY3CfmR8b?= =?us-ascii?Q?Hgm+BIxSYce5OTCHXK8D4Dg/?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0e694113-436e-4062-f1c2-08d940c2d6ea X-MS-Exchange-CrossTenant-AuthSource: AM8PR04MB7970.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jul 2021 21:13:02.6396 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: oqgoV8uLm+igAKwk0W/5NuIAeYLQXyXV8H11qhjpjW1NZ6NRrI+PrXaj1Lfzf3QMsN8KIc1t4qOv2gOtm0T1Wg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR0401MB2354 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-MIME-Autoconverted: from quoted-printable to 8bit by lists01.pubmisc.prod.ext.phx2.redhat.com id 166LDEel014896 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1625606024227100001 Content-Type: text/plain; charset="utf-8" Signed-off-by: Jim Fehlig --- src/libxl/libxl_domain.c | 4 +--- src/libxl/libxl_domain.h | 3 +-- src/libxl/libxl_driver.c | 4 +--- 3 files changed, 3 insertions(+), 8 deletions(-) diff --git a/src/libxl/libxl_domain.c b/src/libxl/libxl_domain.c index af20434843..336b67b129 100644 --- a/src/libxl/libxl_domain.c +++ b/src/libxl/libxl_domain.c @@ -764,7 +764,6 @@ libxlDomainManagedSavePath(libxlDriverPrivate *driver, = virDomainObj *vm) */ int libxlDomainSaveImageOpen(libxlDriverPrivate *driver, - libxlDriverConfig *cfg G_GNUC_UNUSED, const char *from, virDomainDef **ret_def, libxlSavefileHeader *ret_hdr) @@ -1260,8 +1259,7 @@ libxlDomainStart(libxlDriverPrivate *driver, =20 if (virFileExists(managed_save_path)) { =20 - managed_save_fd =3D libxlDomainSaveImageOpen(driver, cfg, - managed_save_path, + managed_save_fd =3D libxlDomainSaveImageOpen(driver, managed_s= ave_path, &def, &hdr); if (managed_save_fd < 0) goto cleanup; diff --git a/src/libxl/libxl_domain.h b/src/libxl/libxl_domain.h index 928ee8f5cd..526c8e7332 100644 --- a/src/libxl/libxl_domain.h +++ b/src/libxl/libxl_domain.h @@ -103,11 +103,10 @@ libxlDomainManagedSavePath(libxlDriverPrivate *driver, =20 int libxlDomainSaveImageOpen(libxlDriverPrivate *driver, - libxlDriverConfig *cfg, const char *from, virDomainDef **ret_def, libxlSavefileHeader *ret_hdr) - ATTRIBUTE_NONNULL(4) ATTRIBUTE_NONNULL(5); + ATTRIBUTE_NONNULL(3) ATTRIBUTE_NONNULL(4); =20 int libxlDomainDestroyInternal(libxlDriverPrivate *driver, diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c index c97b2fb485..838747a1e3 100644 --- a/src/libxl/libxl_driver.c +++ b/src/libxl/libxl_driver.c @@ -1942,7 +1942,6 @@ libxlDomainRestoreFlags(virConnectPtr conn, const cha= r *from, const char *dxml, unsigned int flags) { libxlDriverPrivate *driver =3D conn->privateData; - libxlDriverConfig *cfg =3D libxlDriverConfigGet(driver); virDomainObj *vm =3D NULL; virDomainDef *def =3D NULL; libxlSavefileHeader hdr; @@ -1961,7 +1960,7 @@ libxlDomainRestoreFlags(virConnectPtr conn, const cha= r *from, return -1; } =20 - fd =3D libxlDomainSaveImageOpen(driver, cfg, from, &def, &hdr); + fd =3D libxlDomainSaveImageOpen(driver, from, &def, &hdr); if (fd < 0) goto cleanup; =20 @@ -1995,7 +1994,6 @@ libxlDomainRestoreFlags(virConnectPtr conn, const cha= r *from, virReportSystemError(errno, "%s", _("cannot close file")); virDomainDefFree(def); virDomainObjEndAPI(&vm); - virObjectUnref(cfg); return ret; } =20 --=20 2.31.1