From nobody Mon Feb 9 08:55:29 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1625499448; cv=none; d=zohomail.com; s=zohoarc; b=IIQRgMJOfNoow0lUQFd/K55IvaB8n2SJo+uUO+ZJbX/8/qDbaItJlc5Z8yluIBmgmVs/1V8ODawnJNjxOpudZq9dGwbCVn5oK4euSCGAcJ+syzR0fSM5RLM27llANI40j1hVwM0ZDuy9NldvQPvQ/U3tZ4nvUvlgMjQuD0xCYfo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1625499448; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=H3C4PiiLa1H+l9OBc7M/w64fZYtIVzzUklXFvNKcViI=; b=IT6jpYULLrw/OaDUuopJGbInGFlKVpHI87BkBhhsBI1nxEyEteNp8iYkW5zyCEJe8q6AMP+S9r7V5Qv0bsPSAjTPgToQ/bw54GfUq5huzez7E6XamYD3SDMSuDLY7Kl3AyI3jkBSJ03YACCdimuMBaxN6pn6anb153/N8lch8HI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1625499448285290.4347438855357; Mon, 5 Jul 2021 08:37:28 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-424-2i-TjlR9MMK960ULz1-XsA-1; Mon, 05 Jul 2021 11:37:25 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id CB8CA804301; Mon, 5 Jul 2021 15:37:20 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A3A4F10074F8; Mon, 5 Jul 2021 15:37:20 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 683871809CB6; Mon, 5 Jul 2021 15:37:20 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 165FbF3K032609 for ; Mon, 5 Jul 2021 11:37:15 -0400 Received: by smtp.corp.redhat.com (Postfix) id C62DF2EB07; Mon, 5 Jul 2021 15:37:15 +0000 (UTC) Received: from work.speedport.ip (ovpn-113-101.ams2.redhat.com [10.36.113.101]) by smtp.corp.redhat.com (Postfix) with ESMTP id 060132EB1B; Mon, 5 Jul 2021 15:37:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1625499447; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=H3C4PiiLa1H+l9OBc7M/w64fZYtIVzzUklXFvNKcViI=; b=Phnxj44o59yagL5alKdEHdv0SJv2CKyO/DQLkKipdEf7XxLEUTh2LMuibNyPtZNb6XuqS0 vtgaKyTBMGIyYBNrxjL3oy444lrbG0UwkcvVI9lCcqnW+lHxkM2LkYAZO7LF6ai0eePlNY PbRdKt15G89exs4xY6q3UT64X7LJV/I= X-MC-Unique: 2i-TjlR9MMK960ULz1-XsA-1 From: Tim Wiederhake To: libvir-list@redhat.com Subject: [libvirt PATCH 08/10] qemuMonitorGetChardevInfo: Remove superfluous variable "ret" Date: Mon, 5 Jul 2021 17:36:47 +0200 Message-Id: <20210705153649.236145-9-twiederh@redhat.com> In-Reply-To: <20210705153649.236145-1-twiederh@redhat.com> References: <20210705153649.236145-1-twiederh@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-loop: libvir-list@redhat.com Cc: Tim Wiederhake X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1625499451915100001 Content-Type: text/plain; charset="utf-8" Signed-off-by: Tim Wiederhake --- src/qemu/qemu_monitor.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c index dba2fb1982..f03d6106f9 100644 --- a/src/qemu/qemu_monitor.c +++ b/src/qemu/qemu_monitor.c @@ -2885,7 +2885,6 @@ int qemuMonitorGetChardevInfo(qemuMonitor *mon, GHashTable **retinfo) { - int ret; GHashTable *info =3D NULL; =20 VIR_DEBUG("retinfo=3D%p", retinfo); @@ -2895,9 +2894,7 @@ qemuMonitorGetChardevInfo(qemuMonitor *mon, if (!(info =3D virHashNew(qemuMonitorChardevInfoFree))) goto error; =20 - ret =3D qemuMonitorJSONGetChardevInfo(mon, info); - - if (ret < 0) + if (qemuMonitorJSONGetChardevInfo(mon, info) < 0) goto error; =20 *retinfo =3D info; --=20 2.31.1