From nobody Mon Feb 9 17:58:18 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1624631343; cv=none; d=zohomail.com; s=zohoarc; b=mEmYxmEgOYb3wtwz7EZsxLoygkuWkzxNsgGHnMs2l4L/EQjdrOGL5Dx09S2EViOZXtqKL7y3La4M8bJeiC/7MxYhLgAWCsj6YVFWrQnmd2uenGGQ0o63c/b16dsui4L3Y1boaKXwqjIW0Zn6TyJfiRuq+GBEYvCPSHFi0my+LsQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1624631343; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=3JWtqoswU6B2lXzayoxWB+VNqR9ncO813UwJ7Kzg3F0=; b=b5iR1hZecaaHZmUHg+t5bBOL3KRxJGx6udxGuZdUj5INyxXXHYnr9I6HWNikSC6HpKrRnzny1948xeBhZ5fhBptAYhikaaedJrBjX7zZxW+bQcRlc8e6MXy8QYCP8J/QkOYsfPqxl+M5tm3nyhqqP3D7hOTPkNH7nmYNKvQ0TXQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1624631343380424.66707055192296; Fri, 25 Jun 2021 07:29:03 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-434-wNWlqAi3N8yHro3iC7y8bA-1; Fri, 25 Jun 2021 10:28:11 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C159F1926DA6; Fri, 25 Jun 2021 14:28:06 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 95DB25D703; Fri, 25 Jun 2021 14:28:06 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 3391518005A2; Fri, 25 Jun 2021 14:28:06 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 15PERwA7017792 for ; Fri, 25 Jun 2021 10:27:58 -0400 Received: by smtp.corp.redhat.com (Postfix) id 8720D5C22B; Fri, 25 Jun 2021 14:27:58 +0000 (UTC) Received: from harajuku.usersys.redhat.com (unknown [10.40.195.37]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EAB9F5C1D5 for ; Fri, 25 Jun 2021 14:27:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1624631342; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=3JWtqoswU6B2lXzayoxWB+VNqR9ncO813UwJ7Kzg3F0=; b=AXIqktpP3tUjF1D3Bp4yEUeDe7S6TPQtkWs1amE8DZl+NLUyoFRXF3xdhlyd5ex1zJVS9j l2GtW1QquXb3+gD+uwHBkdlhMT1uge13NyGeii9YNZ/9QWOvDWApOFrasnxo9/6VCvNiyq uVJvmvvv1GrGUyKe0iwAlW7nc83glN8= X-MC-Unique: wNWlqAi3N8yHro3iC7y8bA-1 From: Andrea Bolognani To: libvir-list@redhat.com Subject: [libvirt PATCH 3/5] qemu: Default to TPM 2.0 for ARM virt guests Date: Fri, 25 Jun 2021 16:27:43 +0200 Message-Id: <20210625142745.117287-4-abologna@redhat.com> In-Reply-To: <20210625142745.117287-1-abologna@redhat.com> References: <20210625142745.117287-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" The TPM 2.0 specification predates ARM virtualization, and so implementing TPM 1.2 support on ARM was not considered a useful endeavor. This is technically a breaking change, but TPM support on ARM was only introduced fairly recently (libvirt 7.1.0) and the previous default resulted in non working TPM devices; anyone who has a working configuration is not going to be affected. https://bugzilla.redhat.com/show_bug.cgi?id=3D1970310 Signed-off-by: Andrea Bolognani Tested-by: Liu Yiding Tested-by: liuyd.fnst@fujitsu.com --- src/qemu/qemu_domain.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index fc60e15eea..8488f58e09 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -4445,7 +4445,8 @@ qemuDomainDefTPMsPostParse(virDomainDef *def) /* TPM 1.2 and 2 are not compatible, so we choose a specific versi= on here */ if (tpm->version =3D=3D VIR_DOMAIN_TPM_VERSION_DEFAULT) { if (tpm->model =3D=3D VIR_DOMAIN_TPM_MODEL_SPAPR || - tpm->model =3D=3D VIR_DOMAIN_TPM_MODEL_CRB) + tpm->model =3D=3D VIR_DOMAIN_TPM_MODEL_CRB || + qemuDomainIsARMVirt(def)) tpm->version =3D VIR_DOMAIN_TPM_VERSION_2_0; else tpm->version =3D VIR_DOMAIN_TPM_VERSION_1_2; --=20 2.31.1