From nobody Sat Sep 21 05:40:36 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1624364757; cv=none; d=zohomail.com; s=zohoarc; b=JvaUY/yxAYhOKjtd/lmKyWZZQ5cPOtcRiKAnKWb23l8hXRJeTAJdM3E6zsG6NjuA4I6ehFpLOhw0Lv1/SDdPOBgR0ID0fUTdEoaw0i23Az+DPsgoVho8TaU3Xf/wQJBoibRrzZ8/sU1L/xK75X0PY9y/eg+ynNUTNlOKmZcljc4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1624364757; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=8mTJ8xolaonXHXVoICpgaAu/hs8XmjPy8EFCFfnOBwo=; b=Wgj0Dbx977NtFhFWtA5LQJgmz6JSebW1d2QFsg7nn56O/hUp18dS2U2uCqFCvtF0jAQlvB5O+5xzazWJ7GKn45s8orl3Fo3vYr164YmX8fbPdhoQa5YqrrHewRfRpIConxxeGFp/6dGUQOiFQNuXJuioRcagqrKtLbuHnLcKwTo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1624364757595493.949119541094; Tue, 22 Jun 2021 05:25:57 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-243-PuBJ2MYYPDWaj3uJ8_LpyA-1; Tue, 22 Jun 2021 08:24:12 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id F22E38042FE; Tue, 22 Jun 2021 12:24:06 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D3D71608BA; Tue, 22 Jun 2021 12:24:06 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 98F341801258; Tue, 22 Jun 2021 12:24:06 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 15MCNBxl005169 for ; Tue, 22 Jun 2021 08:23:11 -0400 Received: by smtp.corp.redhat.com (Postfix) id 3731619D9B; Tue, 22 Jun 2021 12:23:11 +0000 (UTC) Received: from work.redhat.com (ovpn-113-16.ams2.redhat.com [10.36.113.16]) by smtp.corp.redhat.com (Postfix) with ESMTP id 83AD119C46; Tue, 22 Jun 2021 12:23:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1624364755; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=8mTJ8xolaonXHXVoICpgaAu/hs8XmjPy8EFCFfnOBwo=; b=dF035WYRK63m3XhsPEvFQswJXbLbBpINev0Uk0MQij3Vy8fPueDMIDsOti2kk+vfxvEFSd eY9P/Iv/Kmo9apaEHesP11wRBUKGMNqPhXH1L3C7BHp2t7T+i/pQ9f+kTWS5WuZ0der4/2 9/yq/Rxvl6hMGnmclUu/YVfaAtR89ao= X-MC-Unique: PuBJ2MYYPDWaj3uJ8_LpyA-1 From: Tim Wiederhake To: libvir-list@redhat.com Subject: [libvirt PATCH 07/16] virDomainFeaturesKVMDefParse: Remove tautological "switch" Date: Tue, 22 Jun 2021 14:22:48 +0200 Message-Id: <20210622122257.12528-8-twiederh@redhat.com> In-Reply-To: <20210622122257.12528-1-twiederh@redhat.com> References: <20210622122257.12528-1-twiederh@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-loop: libvir-list@redhat.com Cc: Tim Wiederhake X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" `feature` is always one of the values listed in the switch, ensured by `virDomainKVMTypeFromString` above. Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 18 ++++-------------- 1 file changed, 4 insertions(+), 14 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 2ad4cbc5a3..62565601ab 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -17418,21 +17418,11 @@ virDomainFeaturesKVMDefParse(virDomainDef *def, return -1; } =20 - switch ((virDomainKVM) feature) { - case VIR_DOMAIN_KVM_HIDDEN: - case VIR_DOMAIN_KVM_DEDICATED: - case VIR_DOMAIN_KVM_POLLCONTROL: - if (virXMLPropTristateSwitch(node, "state", - VIR_XML_PROP_REQUIRED, - &value) < 0) - return -1; - - def->kvm_features[feature] =3D value; - break; + if (virXMLPropTristateSwitch(node, "state", VIR_XML_PROP_REQUI= RED, + &value) < 0) + return -1; =20 - case VIR_DOMAIN_KVM_LAST: - break; - } + def->kvm_features[feature] =3D value; =20 node =3D xmlNextElementSibling(node); } --=20 2.31.1