From nobody Mon Feb 9 13:57:52 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=quarantine dis=quarantine) header.from=suse.com Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1623830621896926.5616236048221; Wed, 16 Jun 2021 01:03:41 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-368-oMV1EnJcO8W8KEzHXlNgDA-1; Wed, 16 Jun 2021 04:03:38 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 09CD4801B1A; Wed, 16 Jun 2021 08:03:34 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CF951100238C; Wed, 16 Jun 2021 08:03:33 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 8F6031809CBE; Wed, 16 Jun 2021 08:03:33 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 15G83SwK002335 for ; Wed, 16 Jun 2021 04:03:28 -0400 Received: by smtp.corp.redhat.com (Postfix) id AF9482157F28; Wed, 16 Jun 2021 08:03:28 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast04.extmail.prod.ext.rdu2.redhat.com [10.11.55.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id AAE6D2157F27 for ; Wed, 16 Jun 2021 08:03:28 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 931A1101D220 for ; Wed, 16 Jun 2021 08:03:28 +0000 (UTC) Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-511-zAW8J-uHOjeMPDTjFGe3JQ-1; Wed, 16 Jun 2021 04:03:26 -0400 Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-db5eur03lp2059.outbound.protection.outlook.com [104.47.10.59]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-19-2wuKeyFoOQWjEvTxPK2ByQ-2; Wed, 16 Jun 2021 10:03:24 +0200 Received: from AM9PR04MB8602.eurprd04.prod.outlook.com (2603:10a6:20b:439::12) by AM9PR04MB8793.eurprd04.prod.outlook.com (2603:10a6:20b:408::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4242.18; Wed, 16 Jun 2021 08:03:22 +0000 Received: from AM9PR04MB8602.eurprd04.prod.outlook.com ([fe80::cd4e:6cc0:8021:f249]) by AM9PR04MB8602.eurprd04.prod.outlook.com ([fe80::cd4e:6cc0:8021:f249%4]) with mapi id 15.20.4242.019; Wed, 16 Jun 2021 08:03:22 +0000 Received: from localhost (60.251.47.115) by PR0P264CA0082.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:18::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4242.15 via Frontend Transport; Wed, 16 Jun 2021 08:03:21 +0000 X-MC-Unique: oMV1EnJcO8W8KEzHXlNgDA-1 X-MC-Unique: zAW8J-uHOjeMPDTjFGe3JQ-1 X-MC-Unique: 2wuKeyFoOQWjEvTxPK2ByQ-2 From: Lin Ma To: libvir-list@redhat.com Subject: [libvirt] [PATCH v2 5/5] virsh-volume: Apply virshStorageVolNameCompleter to vol-{key, path} commands Date: Wed, 16 Jun 2021 16:02:54 +0800 Message-ID: <20210616080254.19513-6-lma@suse.com> In-Reply-To: <20210616080254.19513-1-lma@suse.com> References: <20210616080254.19513-1-lma@suse.com> X-Originating-IP: [60.251.47.115] X-ClientProxiedBy: PR0P264CA0082.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:18::22) To AM9PR04MB8602.eurprd04.prod.outlook.com (2603:10a6:20b:439::12) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2e4ad014-cd9b-4e7c-7ed8-08d9309d362e X-MS-TrafficTypeDiagnostic: AM9PR04MB8793: X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:296 X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0 X-Microsoft-Antispam-Message-Info: Ukf7gzgB7f87uT/zh5dMns73+mWCDEB2nbY9WpCGLUHNuXpGELO6aUiF5IdOauNArPQ1uzIyODrEvY/bpb0mNUj2c06iSdyaJoZozwt6VfBB8hjhWtCwM5kECKM1ZivK6IgeCfIkWPYtx3FRf3y8rGaqAkj3yAvaSeGFcWHEvFJy2wmup8P8pb0+AvMg7qSYIMRc67oag/4tPhpf1dog7WAFx21WE0trVbGk+uV3ts2EPka/X8rBVT/AcM2oZLSIbe26x1DDiMbC0DgdanKBLx4SPJLRRrtmTq5ZW2PhgiiMuGH8g9AqxkjElQh/W9V9erj68CcCu1EW7dM68srUzpkBTzkBWQ8sfIqvjEv2C8WKdijhz3m+A2SPwXFw/L+4C+Ev8VsSH2evsGIG4C9psQca55v/jhDE1DWLqepXYwQ+E+a8/sRIH+z6n3cPBPpbZK4A810vDj0BydDKZNAR0WfSY/XGIAo0J2fTxQaEtr0cGDQOXXzVwlg1IB6pSVg0v3yQMnz9zM/eJ0k2KaKh0xbM10WaspPdxkxizRdzNC+YPBCcAcIehfijP1D4AGRauGUezsY47zfSKcf4hGI7xBKX+cjfl4BJaMUqxIZEiaOdMNfJQ/SB9muQxemAV/FiA8nm6ZCYiqsHnssSb7+t9w== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM9PR04MB8602.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(396003)(376002)(136003)(346002)(39860400002)(6916009)(107886003)(83380400001)(186003)(4744005)(26005)(55236004)(1076003)(16526019)(316002)(5660300002)(38100700002)(450100002)(8936002)(6486002)(2616005)(36756003)(4326008)(66556008)(6496006)(66476007)(8676002)(956004)(86362001)(2906002)(66946007)(478600001)(6666004)(145543001); DIR:OUT; SFP:1101 X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?TgRq0wEWnIw0w6kre+3iXkVX/f+IBsx0uZr0ztAb8QPJcFQqmMfaMaihtQZD?= =?us-ascii?Q?KBrV8AJybcs1NGfmg1GSFsX0BQeZTIyAEotqyZNGIWW3rYLmtTbopy9XZrP3?= =?us-ascii?Q?gftdAZUBgpI6NEebHJ2aRh+hIGduxjEuOJcdQ9SNUa52E+7UjvcpcE+Zsct3?= =?us-ascii?Q?Sa4Ejvyprj9/1XTtVbTk6gQhRHgswuxJPzLMc5QjD42eQnl47lUWj7MGOmN+?= =?us-ascii?Q?wzoNCD5pUKbs+p8dpIlEN9ITbC+g0QkmUNUB7lRWVfFajhs7GiQ+y7H2WswT?= =?us-ascii?Q?nXYDX3VHIjJ4qMXguxunZjwplV5N1QpHHVPZdbMdx7RShHAdccYoPQWddQlo?= =?us-ascii?Q?wvSTplKLNVxiacS2JTnEv/ZnL/jVPYiVbnRicevXFidNnPZ6HsqcFuU1beDO?= =?us-ascii?Q?8hiPhDkgOOlki4xUlsA/QHk9eDMCXDZ+V5V29CldHMCGfwL+zYZmvz3/3RBJ?= =?us-ascii?Q?O75AUWMx/ggF7w3FCxWFk1JdkNPWlK3KH8lgHajTuqE1LpNAUZ5U7uzs9HHR?= =?us-ascii?Q?D5ejY+dwCsoJ/uHTYxc0yBnILWGTrNbypLQe5FP+e0/6UcSzgpPAgNLJsqIs?= =?us-ascii?Q?i/LXYAVPMpcd/Fe0UiSi6GOWu3WPYD65cVLITySKA2bjAplAtnQ7sGoY7aG9?= =?us-ascii?Q?fIo36cT8UTqDahY5EYPp0Oe1gkUNAuMZhQTPczqAMAxMmdHGHlDZI+74VuFy?= =?us-ascii?Q?lAE2HBnnQOs7tiul/98lZg6vSttC1P0c4NUoic4BJvFSBQQq3QfUgoFY+Y2A?= =?us-ascii?Q?3p1pyHYO7iwU0VZT8nT86H8KWH+lVWlrDLHHtON21ESGL7mAPoGNHHfgThAi?= =?us-ascii?Q?3ffWX0heWoi563tbqOZq/ahmg1q7VyfjE8NM5yucSOYTieFcGMlayKa22i07?= =?us-ascii?Q?/ninW2dvnZpfK2riE7t98t+I9RfXDMizwpz71F7MbftjLUnO+vhgyXuD/aS5?= =?us-ascii?Q?un/f7nv5SK0452ZG019oFEFezT/6bKXtAaboH0msbcFD1Qexb70jR3Y2sFi2?= =?us-ascii?Q?hNhh/NQzfeb3yCKEsCdGQY6BHr0I9f/wxNYAvTjAOumkj+utJ26A4bEOb3Te?= =?us-ascii?Q?HBxPa40wsetbFHibvgq//YzidRmg/FkALmsZ6dezVCfzxp79KTksAlD2g61E?= =?us-ascii?Q?RVzpoeF1TEFSjDbrqZ/T9Ni1GmbdDI+Ry7Qg02gHLGFeXyYADKNvNNol7j2Y?= =?us-ascii?Q?nfW7FrpyYsZFFav0zMyqGcXKbvJ+UKEfLEPOP12zEA+b8TzAYdaMJiHDQiwU?= =?us-ascii?Q?RfEhYyw01nFXgq45Kpx0cP8u1L01zm/NBhrlBCMr+enEL3mZ5hU5FJNG/H7H?= =?us-ascii?Q?VkAl5roKgIhm9Np5uxQ1n5MT?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2e4ad014-cd9b-4e7c-7ed8-08d9309d362e X-MS-Exchange-CrossTenant-AuthSource: AM9PR04MB8602.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jun 2021 08:03:22.7537 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: uQrcSnKU5obLMsQ/vHiq6lZGspUODV+8sbApGbxBRbP30Fp6SStjfK78aKFlDioO X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8793 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-MIME-Autoconverted: from quoted-printable to 8bit by lists01.pubmisc.prod.ext.phx2.redhat.com id 15G83SwK002335 X-loop: libvir-list@redhat.com Cc: mprivozn@redhat.com, Lin Ma X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Signed-off-by: Lin Ma --- tools/virsh-volume.c | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/tools/virsh-volume.c b/tools/virsh-volume.c index daa205ea67..1da9b7217f 100644 --- a/tools/virsh-volume.c +++ b/tools/virsh-volume.c @@ -1643,11 +1643,7 @@ static const vshCmdInfo info_vol_key[] =3D { }; =20 static const vshCmdOptDef opts_vol_key[] =3D { - {.name =3D "vol", - .type =3D VSH_OT_DATA, - .flags =3D VSH_OFLAG_REQ, - .help =3D N_("volume name or path") - }, + VIRSH_COMMON_OPT_VOL_NAME(N_("volume name or path")), VIRSH_COMMON_OPT_POOL_OPTIONAL, {.name =3D NULL} }; @@ -1679,11 +1675,7 @@ static const vshCmdInfo info_vol_path[] =3D { }; =20 static const vshCmdOptDef opts_vol_path[] =3D { - {.name =3D "vol", - .type =3D VSH_OT_DATA, - .flags =3D VSH_OFLAG_REQ, - .help =3D N_("volume name or key") - }, + VIRSH_COMMON_OPT_VOL_NAME(N_("volume name or key")), VIRSH_COMMON_OPT_POOL_OPTIONAL, {.name =3D NULL} }; --=20 2.26.2