From nobody Sun Feb 8 22:50:14 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=quarantine dis=quarantine) header.from=suse.com Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1623717669469665.2396436448546; Mon, 14 Jun 2021 17:41:09 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-580-egHFX6JnNqmZ2P9ksgUwWw-1; Mon, 14 Jun 2021 20:41:06 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id CCBA9185060E; Tue, 15 Jun 2021 00:41:01 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A422917A8B; Tue, 15 Jun 2021 00:41:01 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 6B60046F60; Tue, 15 Jun 2021 00:41:01 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 15F0eBqe002300 for ; Mon, 14 Jun 2021 20:40:11 -0400 Received: by smtp.corp.redhat.com (Postfix) id 90687112D432; Tue, 15 Jun 2021 00:40:11 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast03.extmail.prod.ext.rdu2.redhat.com [10.11.55.19]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8BB71112D42D for ; Tue, 15 Jun 2021 00:40:09 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id B128F80D0E0 for ; Tue, 15 Jun 2021 00:40:08 +0000 (UTC) Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-86-b9x9zEk5N0GU9bvu8Ujigw-1; Mon, 14 Jun 2021 20:40:06 -0400 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05lp2106.outbound.protection.outlook.com [104.47.17.106]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-6-5eRmkPSgOPiUxuU6RY_tSw-1; Tue, 15 Jun 2021 02:40:03 +0200 Received: from AM9PR04MB8602.eurprd04.prod.outlook.com (2603:10a6:20b:439::12) by AM9PR04MB8779.eurprd04.prod.outlook.com (2603:10a6:20b:40a::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.21; Tue, 15 Jun 2021 00:40:02 +0000 Received: from AM9PR04MB8602.eurprd04.prod.outlook.com ([fe80::cd4e:6cc0:8021:f249]) by AM9PR04MB8602.eurprd04.prod.outlook.com ([fe80::cd4e:6cc0:8021:f249%4]) with mapi id 15.20.4219.025; Tue, 15 Jun 2021 00:40:02 +0000 Received: from localhost (139.212.192.133) by HK2PR06CA0021.apcprd06.prod.outlook.com (2603:1096:202:2e::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.20 via Frontend Transport; Tue, 15 Jun 2021 00:40:01 +0000 X-MC-Unique: egHFX6JnNqmZ2P9ksgUwWw-1 X-MC-Unique: b9x9zEk5N0GU9bvu8Ujigw-1 X-MC-Unique: 5eRmkPSgOPiUxuU6RY_tSw-1 From: Lin Ma To: libvir-list@redhat.com Subject: [libvirt] [PATCH 12/12] virsh-volume: Apply virshStorageVolNameCompleter to vol-{key, path} commands Date: Tue, 15 Jun 2021 08:38:32 +0800 Message-ID: <20210615003832.5571-13-lma@suse.com> In-Reply-To: <20210615003832.5571-1-lma@suse.com> References: <20210615003832.5571-1-lma@suse.com> X-Originating-IP: [139.212.192.133] X-ClientProxiedBy: HK2PR06CA0021.apcprd06.prod.outlook.com (2603:1096:202:2e::33) To AM9PR04MB8602.eurprd04.prod.outlook.com (2603:10a6:20b:439::12) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 87c4b8fa-93fa-4d70-cd33-08d92f961cc5 X-MS-TrafficTypeDiagnostic: AM9PR04MB8779: X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:296 X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0 X-Microsoft-Antispam-Message-Info: /SrKBarz+8hRqEZnlYGeWtahTXa2zBB/dVxkwePz3jzbrWCk24fMSt94DovdreMeU3K+URdE1/NCdi69IbJaz7ncdItRl1WOjRAERqexadmZT5zDhbzsdZw1g2RPP72Fm5ujSWJkEJMciaFeIf+mbtxoN0HxDlhUfGjygC+N2IF/jL1vyndoL4KLfzgbOSV5BQsCNCAZZhb9MUdySAhKp+rJPbFX2Njk8JrkskxKQf3rcQpRtrhKn6H0yIN7JmjJDkJ5Ihq4tGaog2r4LUBbozepmdRCgh+ntQWTG+oboKOr1ZoG7AtpykqDcEPXQDLsUKdsDw4B7WAmCk8szyMre//1ncYnzDxjsCbZwyeiKToREoncOD8DqjAOnbuNAKw5UB1lE0x8QYkcct++Ko5BwVq3dkp3Xd1Th656rYvxc6eLKJ8YSrtrz/xsHsmWA1Xb+7WaQ3AMvJbOfa67Md7N8sQ8jihl4HQ5vmJz0j/K1vjryEqKE8kkjym9OjfyzjOzlrqldD3la0X79r0SQu/+TgxcmpzYCY7jQHLb7HQTqMvikqj2qVfIFRO+OOQGM1m6K3SwBn1UdVtFy0XG3LDt8jKB0REmJlZ/ltZh9LVgHk2tWSfGU3C850hbXNbpyntRUUs1HtfiR2ZoHCNV9HJuAg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM9PR04MB8602.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(39860400002)(396003)(346002)(376002)(136003)(186003)(86362001)(16526019)(26005)(450100002)(6916009)(478600001)(8676002)(4744005)(5660300002)(8936002)(4326008)(66946007)(66556008)(66476007)(83380400001)(2616005)(956004)(1076003)(107886003)(316002)(6496006)(6666004)(2906002)(36756003)(38100700002)(6486002)(145543001); DIR:OUT; SFP:1101 X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?+dZPGpt8s2VtpzZV13+q5wE4kHIo7SIpjKLe4asm6Io5t6vacKpPWMg0dOPg?= =?us-ascii?Q?dvNHwVMHLw3j8Yixhh8ezbEkoEugHN9EPUROe8ctyAHhkB+JpWwP6UfxDzLe?= =?us-ascii?Q?1bSBz7Nk1VHGEJcvUo4l361i3H1rKv3a7tP0dnjs9l7uJ62fZAUZe+Ume7qq?= =?us-ascii?Q?ga0KGWsuUdULdlqWjnZ8HZIWHV5iB/eya+ub2/w/cyOlkuPGX7+k0uiyJO6R?= =?us-ascii?Q?1REBCZCSQGvu0YtL0R/j986nBucGs14ptFLU4Ktfgq1mdrfDXo461jQFud7s?= =?us-ascii?Q?0Wwt/Zmuz5/I3OAFH8VXk3UP6p7GTP/TmSuAE3W6269kHwN5Gz+u5xtC/AIn?= =?us-ascii?Q?87e6+nEndUVDNfkGfawepVow0pBxhmgrFPPGyN3yrA2d2mnpnKY8gpHHHhsa?= =?us-ascii?Q?oYgbnAPcRqBn0qzQKzZ349F7pd4mBV5b3F9KjJaf1Xj5Hs0zrcZT94TJcwEW?= =?us-ascii?Q?B3TEE3EJj/XxE0XTtU/ut+2/g94O2TANi8a8Q0P3vSBSljm28+LaFCHQaBtB?= =?us-ascii?Q?ZrIT6zZiwL8WQSb33ml8AeR9YKehxxS8844zdJ0IE9zkiMIUM0ufV9M0G06I?= =?us-ascii?Q?RORYt70wHqYanLGHcKHJ77sOgAEmHUw9TIh37WcNgreHNHTPSM3CkH+AlEox?= =?us-ascii?Q?XuGn7QstOGWGolZvrA2PAHYO3eEtSQ+qjjvSyXDiZnp7OiEuvM1KYF8aNeH4?= =?us-ascii?Q?cZ1wV6ffUZG0ANNPQCbcw07QIlYaP9IStGgolslBkeVv09tNJ2GRnBMY17vY?= =?us-ascii?Q?vd4LqwESHrZP/m9cu5snZj3wgfViB+aJIx/lF6fb36pMmKj0ylaRcVwfF7mp?= =?us-ascii?Q?ZcYWK1gfmSAILLaGCDAxp5EhzwGjuTufTXzid3Y8BlZ0E1YE8bdoTUryAKsT?= =?us-ascii?Q?6STQZZqSOrY6SeleT9h0RPEVFPv139MNwFroeaYDs8x15Zn0dIubQSwYIZHF?= =?us-ascii?Q?m/7ENwd+DBYnjltOTR6x4E2XDpV5ZLsd+cXIaGIIIMy46geQ/mWvmqj7Z/dO?= =?us-ascii?Q?/Sc6bJ/o4hgx7DooxPQwZ44AvmkMrif/K5+khBhLGXug8AXjpRjUusP48js1?= =?us-ascii?Q?89acBRrAeLSpk+CqfMft5j8G3qMPbKIZgx/llUr7sNgpgRk2rVq/jlRu9YQf?= =?us-ascii?Q?2PIQ4qsSS2OmM7WRvTj3qkdNVxACig/MAE4l7uPsYn1XS67JDwuRbwSuyNa5?= =?us-ascii?Q?NQLEfdMZ1kxnkxsOXF+ALdrPSjyjDNwUZcrZBVEoA/hL+GZljONQgbKHFmdk?= =?us-ascii?Q?xv4zF8n3Da2yB0+TY9LHnnodYXSlDkjOItbLBGswdnFyR9KDoicJ+3KuPMPx?= =?us-ascii?Q?SQbN2QbT/vXntpilHSVSzHlg?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 87c4b8fa-93fa-4d70-cd33-08d92f961cc5 X-MS-Exchange-CrossTenant-AuthSource: AM9PR04MB8602.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jun 2021 00:40:02.8779 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: F/hn1vxSaHHiD0RsEdIy7YX5uZcUiW+G2owJXtVtL3hhWICuKWS2es9bXbGSZqDr X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8779 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-MIME-Autoconverted: from quoted-printable to 8bit by lists01.pubmisc.prod.ext.phx2.redhat.com id 15F0eBqe002300 X-loop: libvir-list@redhat.com Cc: mprivozn@redhat.com, Lin Ma X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Signed-off-by: Lin Ma --- tools/virsh-volume.c | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/tools/virsh-volume.c b/tools/virsh-volume.c index daa205ea67..1da9b7217f 100644 --- a/tools/virsh-volume.c +++ b/tools/virsh-volume.c @@ -1643,11 +1643,7 @@ static const vshCmdInfo info_vol_key[] =3D { }; =20 static const vshCmdOptDef opts_vol_key[] =3D { - {.name =3D "vol", - .type =3D VSH_OT_DATA, - .flags =3D VSH_OFLAG_REQ, - .help =3D N_("volume name or path") - }, + VIRSH_COMMON_OPT_VOL_NAME(N_("volume name or path")), VIRSH_COMMON_OPT_POOL_OPTIONAL, {.name =3D NULL} }; @@ -1679,11 +1675,7 @@ static const vshCmdInfo info_vol_path[] =3D { }; =20 static const vshCmdOptDef opts_vol_path[] =3D { - {.name =3D "vol", - .type =3D VSH_OT_DATA, - .flags =3D VSH_OFLAG_REQ, - .help =3D N_("volume name or key") - }, + VIRSH_COMMON_OPT_VOL_NAME(N_("volume name or key")), VIRSH_COMMON_OPT_POOL_OPTIONAL, {.name =3D NULL} }; --=20 2.26.2