[libvirt PATCH] cpu_map: sync_qemu_i386.py: Remove superfluous semicolon

Tim Wiederhake posted 1 patch 2 years, 9 months ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20210609110429.28110-1-twiederh@redhat.com
src/cpu_map/sync_qemu_i386.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[libvirt PATCH] cpu_map: sync_qemu_i386.py: Remove superfluous semicolon
Posted by Tim Wiederhake 2 years, 9 months ago
The semicolon in question makes the pipeline fail over a style checker
complaint.

Introduced-in: 360b8eb2d2cb1b6a8c9a78fa2c5be31dd7c74487
Signed-off-by: Tim Wiederhake <twiederh@redhat.com>
---
 src/cpu_map/sync_qemu_i386.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/cpu_map/sync_qemu_i386.py b/src/cpu_map/sync_qemu_i386.py
index fbf1edf5d0..92bb58f75b 100755
--- a/src/cpu_map/sync_qemu_i386.py
+++ b/src/cpu_map/sync_qemu_i386.py
@@ -209,7 +209,7 @@ def read_builtin_x86_defs(filename):
                 raise RuntimeError("begin mark not found")
             match = begin_mark.match(line)
             if match:
-                break;
+                break
             match = shorthand.match(line)
             if match:
                 # TCG definitions are irrelevant for cpu models
-- 
2.31.1

Re: [libvirt PATCH] cpu_map: sync_qemu_i386.py: Remove superfluous semicolon
Posted by Pavel Hrdina 2 years, 9 months ago
On Wed, Jun 09, 2021 at 01:04:29PM +0200, Tim Wiederhake wrote:
> The semicolon in question makes the pipeline fail over a style checker
> complaint.
> 
> Introduced-in: 360b8eb2d2cb1b6a8c9a78fa2c5be31dd7c74487
> Signed-off-by: Tim Wiederhake <twiederh@redhat.com>
> ---
>  src/cpu_map/sync_qemu_i386.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Pavel Hrdina <phrdina@redhat.com>
Re: [libvirt PATCH] cpu_map: sync_qemu_i386.py: Remove superfluous semicolon
Posted by Michal Prívozník 2 years, 9 months ago
On 6/9/21 1:11 PM, Pavel Hrdina wrote:
> On Wed, Jun 09, 2021 at 01:04:29PM +0200, Tim Wiederhake wrote:
>> The semicolon in question makes the pipeline fail over a style checker
>> complaint.
>>
>> Introduced-in: 360b8eb2d2cb1b6a8c9a78fa2c5be31dd7c74487
>> Signed-off-by: Tim Wiederhake <twiederh@redhat.com>
>> ---
>>  src/cpu_map/sync_qemu_i386.py | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Reviewed-by: Pavel Hrdina <phrdina@redhat.com>
> 

Pushed now. Sorry for not spotting this earlier.

Michal