From nobody Mon Feb 9 08:56:29 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=quarantine dis=quarantine) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1622827704; cv=none; d=zohomail.com; s=zohoarc; b=MG0F0CQ6FGyqsJtbKiv5kQSwv+9RAtd8uI8JDLzujK2Z5mfR0tyoWFmXXAIxFBg/hAXU6N9n0s7OAZdIvtAhYh26h/W3FDDGjhkuw6ydC1sBV3sai3hRHVMkVoJnSZFa6bZfMiEP65GTJI58FYbPj6N9yFw88TvYuduu+ohQFPY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1622827704; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=JNSgRIxtna08BINNZmB6hgk0gxiwuqJFAa0hACLP2N0=; b=X2JyhbT4mJYuyMa9VW3SieIngyHlFaApcayW8dFFvA0Q13fFCcnxhYGgxTaV0Q7A7ZjXgO9GDwUiQIEvISHKJ27i5KIibwuEsrv2tCBojLBw7l8XkJK9B9DRTGtFL/t2Wsj7nAeHuygME3xCPPJN+snz3ao3cQixBgJgWJhGuuw= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail header.from= (p=quarantine dis=quarantine) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1622827704144891.4565600065478; Fri, 4 Jun 2021 10:28:24 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-18-waPysYopO-yNi1vcubyF0w-1; Fri, 04 Jun 2021 13:28:19 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 93BA5803F50; Fri, 4 Jun 2021 17:28:14 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 603415D705; Fri, 4 Jun 2021 17:28:14 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 1E0931800BB8; Fri, 4 Jun 2021 17:28:14 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 154HS7A7019579 for ; Fri, 4 Jun 2021 13:28:07 -0400 Received: by smtp.corp.redhat.com (Postfix) id 2806E10C6EAD; Fri, 4 Jun 2021 17:28:07 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast03.extmail.prod.ext.rdu2.redhat.com [10.11.55.19]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 231AF10C6EAB for ; Fri, 4 Jun 2021 17:28:03 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 71FB880D0E4 for ; Fri, 4 Jun 2021 17:28:03 +0000 (UTC) Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-330-WzoP9sxPO56cys0OsnYbjg-1; Fri, 04 Jun 2021 13:28:01 -0400 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05lp2109.outbound.protection.outlook.com [104.47.18.109]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-14-yiUmwwZPNPGeUKk9YLQiJg-1; Fri, 04 Jun 2021 19:27:59 +0200 Received: from AM8PR04MB7970.eurprd04.prod.outlook.com (2603:10a6:20b:24f::9) by AM8PR04MB7905.eurprd04.prod.outlook.com (2603:10a6:20b:235::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4195.24; Fri, 4 Jun 2021 17:27:58 +0000 Received: from AM8PR04MB7970.eurprd04.prod.outlook.com ([fe80::44f9:5a6e:fe98:1718]) by AM8PR04MB7970.eurprd04.prod.outlook.com ([fe80::44f9:5a6e:fe98:1718%7]) with mapi id 15.20.4195.024; Fri, 4 Jun 2021 17:27:58 +0000 Received: from localhost (192.225.191.61) by AM8P189CA0029.EURP189.PROD.OUTLOOK.COM (2603:10a6:20b:218::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4195.23 via Frontend Transport; Fri, 4 Jun 2021 17:27:57 +0000 X-MC-Unique: waPysYopO-yNi1vcubyF0w-1 X-MC-Unique: WzoP9sxPO56cys0OsnYbjg-1 X-MC-Unique: yiUmwwZPNPGeUKk9YLQiJg-1 From: Jim Fehlig To: libvir-list@redhat.com Subject: [PATCH 2/3] libxl: Forbid domain definition with secure boot enabled Date: Fri, 4 Jun 2021 11:27:47 -0600 Message-ID: <20210604172748.681-3-jfehlig@suse.com> In-Reply-To: <20210604172748.681-1-jfehlig@suse.com> References: <20210604172748.681-1-jfehlig@suse.com> X-Originating-IP: [192.225.191.61] X-ClientProxiedBy: AM8P189CA0029.EURP189.PROD.OUTLOOK.COM (2603:10a6:20b:218::34) To AM8PR04MB7970.eurprd04.prod.outlook.com (2603:10a6:20b:24f::9) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6de80fb1-ac1f-4936-e1ec-08d9277e18b8 X-MS-TrafficTypeDiagnostic: AM8PR04MB7905: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:27 X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0 X-Microsoft-Antispam-Message-Info: 843Engm2cnERIVSAWeyCv1Bd4iTOW8VZXardplIFVFXy3U5t2EjdNAEsjENvoGxn07zkujnQwVvIRxtUUKt39j8mK/Zp5lpHFdmk6ASYzp1lXpK66ND4iReF0Hq1Qx6mD8rcQWf8kuvkyHdGcRJzxcP6vdnncRykMfWZmSv0hQAJ8yhUCrHcNfGzPBxFQb83tvm4I/vRMi3LDxR9NK0iqoxEA1LeC2RfvSy4te5qhEmCpX0V0o2rHq1PKX/SllYyugY+IpfYMAdjLVB47e5FqmeadHdnJz/gmmsk1C6heb0+gTG/bVpy9VsGd+hXB1WnP4lMIY0tLfmLluNG+dbbNmIwW4YrrJ38ujRdxubZuIL47eObBq57xFhErQ0Iah9zE1lQ/wE1i+0itkoA2NuMj41akbhaYonnUTuBxWV/CJwWFdM/xDvYUUe3+5JLng0SKpbTyBQB4+HEn6gppGMMyICzgDwWPdIs0OQgntdRfDSoMFWQtB+q/tjPBTz4uxaOWtqXsSLm7GGw1lJoFqwHnyC4cYTh0HU8SSHSc7gGIwFJ/CXK7/ccqaLkoIrG5j2jmaIG4RSxeVsAfHJByVmoqg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM8PR04MB7970.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(396003)(376002)(346002)(366004)(39860400002)(136003)(107886003)(4326008)(16526019)(83380400001)(66476007)(2906002)(66556008)(186003)(26005)(6666004)(66946007)(478600001)(4744005)(8936002)(8676002)(5660300002)(2616005)(316002)(956004)(38100700002)(36756003)(6496006)(6486002)(6916009)(86362001)(1076003); DIR:OUT; SFP:1101 X-MS-Exchange-AntiSpam-MessageData: =?us-ascii?Q?eKphC3EXqiPFHKcTcxFToTTNm/daFDpt7QX24GtHCJoy2UpHgBgC5J7z9F3P?= =?us-ascii?Q?lVWmiR3pVxHvEUSuGB4I8nw1ZOimi6FBeDzcg8EjGbaQiAt/BuDAWn2vRXz3?= =?us-ascii?Q?g8nqitBM1X9sylslbKgp78HBec/fm9O2bLdK/H/AWBKIysQEN11IjyANvGyQ?= =?us-ascii?Q?jXGUaDOOblYIY5EmRN02UAKQBxKIEym552FyZ7Cmb1LMr3MU3hwdFnXy+sa5?= =?us-ascii?Q?6rYifUcEpqTC8ajCrxwHzt9yAIpAVnKLkPn4g8b/X9H5o1ZvWpk0ZF6rSH/X?= =?us-ascii?Q?I8xisVpNI2KdZeVRpGWmjTyR+A1sEa3vAyfdqwa13fmDTmVmWtXykpkD7RAk?= =?us-ascii?Q?2YVGaIgrgGrKDLF/ubPfDRrQvlmYYPlit0vMnJpsOY3cyS/x//eIKjKr4KcJ?= =?us-ascii?Q?FqEwkDGOyAnAGdkjQeUNHOWRCqmmaz730W/K2lvSXj5xEq6J2K0rsc78n4XI?= =?us-ascii?Q?W6d653JT1ShBzrpuNAe/ob7SYSpRZdUtsdIBMrcMEnNpsRCwUy8xy/T/U6p7?= =?us-ascii?Q?YWAbdbLdys9s/bfl1i2fs4JlkqISRgi7FXcYGid2My+DB8IoDODl+C/fF5J7?= =?us-ascii?Q?4jGZY04MzicRA3LvM3JUp1L+FK3fWTACnw+TVYzTXdo7qyXH3UjfQbpcf3LJ?= =?us-ascii?Q?+D2QEaCliENGi9sKL1+66VqiM8tB1zGvyYGDE2o/R+x+p6WhItovPP87Q3eM?= =?us-ascii?Q?wGkEfH3xLDeEx3FmmiiFzvXNIEkOvP+HQF+NRH0+CDIplwWzQFZBk2Byotme?= =?us-ascii?Q?PGnZvjcBksneysV9tOtqS+WPc1kX0C2abarIukyuMXrSzyChSn7bNjb29Uut?= =?us-ascii?Q?IPrlgE0YTqvTPqcgpElk68fkE7vjqPikwTNx3b20V+mouZAFuPCaSeTA1LoH?= =?us-ascii?Q?JULmEX+Q3pS+JLEGzQRxyG2WukGShQjSJze6lHZJiAC0BFE3hYYGl4c2mOwa?= =?us-ascii?Q?FE0epgKBfDOZijCETUVjkul/xnFdfXXAGxTRtIaQPY25Nc/d1MzPyScPNLhJ?= =?us-ascii?Q?TfJWLL880FIH/QZO0grDjY8QDpU23N3GbpnUaidhKbFri/a63Mcqcjl4knTX?= =?us-ascii?Q?KQ9wBhFZycnB2YHZOXOchbO4vDUe1wFWf7YkCTcCrIVcBkFxt3+5v4PK7F5G?= =?us-ascii?Q?+ILauY93TAmRfoz/zwrQiQuZ6/5ov+qVgfVd21Cb5f9+R1QkMsPtXyQUiRW8?= =?us-ascii?Q?49ofL9d9a+/QRvAAFNu8LwWs60ND2PKrnDZo+tPpZ9VPJk1hrbbMosc10SMp?= =?us-ascii?Q?VMBQWvQsTV8x7HpnFqkgNYpx/xhpxPNqUjbaA/zPP3y8IVQlozrLpqzVvGCM?= =?us-ascii?Q?imWSA97kaafWJopBxOQnooFH?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6de80fb1-ac1f-4936-e1ec-08d9277e18b8 X-MS-Exchange-CrossTenant-AuthSource: AM8PR04MB7970.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jun 2021 17:27:58.4833 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: JIKk0LMr1SSu3gitioRqWOyxOrqOEeLamYQeQYPS0xZ1c+Fk/0r26q9e6CO6pREwavsQyHxyUdXF3Xx74AYP/A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7905 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-MIME-Autoconverted: from quoted-printable to 8bit by lists01.pubmisc.prod.ext.phx2.redhat.com id 154HS7A7019579 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Xen+ovmf does not support secure boot. Fail domain def validation if secure boot is enabled. Signed-off-by: Jim Fehlig --- src/libxl/libxl_domain.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/src/libxl/libxl_domain.c b/src/libxl/libxl_domain.c index 9630f12568..14d000511a 100644 --- a/src/libxl/libxl_domain.c +++ b/src/libxl/libxl_domain.c @@ -446,6 +446,16 @@ libxlDomainDefValidate(const virDomainDef *def, def->virtType)) return -1; =20 + /* Xen+ovmf does not support secure boot */ + if (virDomainDefHasOldStyleUEFI(def)) { + if (def->os.loader && + def->os.loader->secure =3D=3D VIR_TRISTATE_BOOL_YES) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("Secure boot is not supported on Xen")); + return -1; + } + } + return 0; } =20 --=20 2.31.1