From nobody Tue Feb 10 19:47:41 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1622536733; cv=none; d=zohomail.com; s=zohoarc; b=BAkPRuy+/GhD7w9toyBnQopVye/K419LOJvO1gxf5coWJj6NSDle7s4PoSf8UmH7P6jsh5kvbKQsV0UrgPb/l7uCnUo+N2rYO2EqVikzEnSluTO/MuBCym3VtGjIISC4Jb059GbxOOwebHFulydYZKABvBn0jU3dsW4DS3dDd3Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1622536733; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=nkVWdjahPbQrUJsHGzlaAJvLi8N8fnlFBj/UK3x7w4k=; b=DIbcJ+rDHCCSsU6ZNQkxfEzQml707Rtiw9QzCDnOnmMEtEqcgQmRX/4iqbqEmeo1Z7D/c5pIesMmQGmCnum7WKWw+k/NUeBo7/QQuA8ZPMkiyQLDI+GgYiNOZ2bU4zia8xvg0x1rlTKYQFM5n+zWbJo6JL/5W0U5DqdutZDyZB4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1622536733900999.9547023687059; Tue, 1 Jun 2021 01:38:53 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-104-ppudgyEVMi6ReA_kHIronw-1; Tue, 01 Jun 2021 04:38:50 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3A0ECBBEED; Tue, 1 Jun 2021 08:38:45 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 124DCE2D4; Tue, 1 Jun 2021 08:38:45 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id CE4BB5B41C; Tue, 1 Jun 2021 08:38:44 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 1518cRii026092 for ; Tue, 1 Jun 2021 04:38:27 -0400 Received: by smtp.corp.redhat.com (Postfix) id 6304FE2D8; Tue, 1 Jun 2021 08:38:27 +0000 (UTC) Received: from harajuku.usersys.redhat.com (unknown [10.40.195.114]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C13C1E2D4 for ; Tue, 1 Jun 2021 08:38:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1622536732; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=nkVWdjahPbQrUJsHGzlaAJvLi8N8fnlFBj/UK3x7w4k=; b=HMZAPqQ8G49ZvTdPV1O2CdB0x6Dve+8lmNEH8H+DjohJyfMfZAErAYhdxl3sRBxi7oMze+ y/oshVt2dToojD4R+T1L+KszfA0xaV2+Lv7ryUSabPdRMySSI292sontci4zJuanI351FV gQCoxOvUcDLlorCcWFdacLsNjMBt+C8= X-MC-Unique: ppudgyEVMi6ReA_kHIronw-1 From: Andrea Bolognani To: libvir-list@redhat.com Subject: [libvirt PATCH 16/26] meson: Fix firewalld check Date: Tue, 1 Jun 2021 10:37:47 +0200 Message-Id: <20210601083757.10194-17-abologna@redhat.com> In-Reply-To: <20210601083757.10194-1-abologna@redhat.com> References: <20210601083757.10194-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" firewalld is Linux-only, so it should be disabled by default everywhere else and attempts to explicitly enable firewalld support on non-Linux targets should result in an error. Signed-off-by: Andrea Bolognani --- meson.build | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/meson.build b/meson.build index faccbd750c..0b2e3e062e 100644 --- a/meson.build +++ b/meson.build @@ -1342,8 +1342,11 @@ endif if not get_option('firewalld').disabled() firewalld_enable =3D true =20 - if host_machine.system() =3D=3D 'freebsd' + if host_machine.system() !=3D 'linux' firewalld_enable =3D false + if get_option('firewalld').enabled() + error('firewalld support can only be enabled on Linux') + endif endif =20 if firewalld_enable --=20 2.31.1