From nobody Mon Feb 9 09:33:10 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1621350552; cv=none; d=zohomail.com; s=zohoarc; b=Q0QvbBca6HTIHGx6bL0i+hYqXocMIhQZ1tvxfRpeY/uIojOPw2JBGqTtxf8vV0aSIYX4rbebP89ZFiQwa5xeBK5hbH9dy2d8efeeWuxIX4dmZN+RcJM78hHzzGQQQDZ2o3J3o+uNIlpUcx0AwDOV2mrDNgZfwymrPZZi2YaPmxY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1621350552; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=z1A+WCdsWoJEwts+8O67s82Anp2v8Z71NWRpRumDpPA=; b=gGwPIivQwi1rQzM4m5ZGgkBnmjaJtULUknNIJtyQ/HeFLNxWLs8y0B4R4ERL1UnZNEmqvX2gPqofYem49dNRJoki3P2129OfFmuD+foEoEJwFA010qylBvMNT1NpS437XzDDOTnfaGepmZlaVLn+5BrZ+/PMTVSZ8Cd7jDJdXYk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1621350552469696.1545380890099; Tue, 18 May 2021 08:09:12 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-261-22TV_V7BNH-zpUTP6TsKTg-1; Tue, 18 May 2021 11:05:06 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id BEE0BE7B4C; Tue, 18 May 2021 15:04:59 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 370FA1007625; Tue, 18 May 2021 15:04:59 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 6AB081801028; Tue, 18 May 2021 15:04:57 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 14IF4skU019236 for ; Tue, 18 May 2021 11:04:54 -0400 Received: by smtp.corp.redhat.com (Postfix) id 1D7DE19D9F; Tue, 18 May 2021 15:04:54 +0000 (UTC) Received: from work.redhat.com (ovpn-113-109.ams2.redhat.com [10.36.113.109]) by smtp.corp.redhat.com (Postfix) with ESMTP id 647463CC7; Tue, 18 May 2021 15:04:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1621350308; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=z1A+WCdsWoJEwts+8O67s82Anp2v8Z71NWRpRumDpPA=; b=P7ysdvyoybhXd7Th77YtJQtsjSD/ZIfVIdYZ7OtcTVCZL455cNWRITyb3bOLozfHeFGBM6 2aYOGTaCut6AIINIWCBZbLq5fAcujbLFFNIrLmCDwd0X31gSk2dSwmYaAYSHcOxnVtlCYw 8x2Ok+NFMJSe3sjoyJ4p279EQsYNPwQ= X-MC-Unique: 22TV_V7BNH-zpUTP6TsKTg-1 From: Tim Wiederhake To: libvir-list@redhat.com Subject: [libvirt PATCH 01/10] virDomainHostdevDef: Change type of startupPolicy to virDomainStartupPolicy Date: Tue, 18 May 2021 17:04:42 +0200 Message-Id: <20210518150451.79954-2-twiederh@redhat.com> In-Reply-To: <20210518150451.79954-1-twiederh@redhat.com> References: <20210518150451.79954-1-twiederh@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-loop: libvir-list@redhat.com Cc: Tim Wiederhake X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 6 +++--- src/conf/domain_conf.h | 21 ++++++++++----------- 2 files changed, 13 insertions(+), 14 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 7044701fac..734fa584a4 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -6704,14 +6704,14 @@ virDomainHostdevSubsysUSBDefParseXML(xmlNodePtr nod= e, ctxt->node =3D node; =20 if ((startupPolicy =3D virXMLPropString(node, "startupPolicy"))) { - def->startupPolicy =3D - virDomainStartupPolicyTypeFromString(startupPolicy); - if (def->startupPolicy <=3D 0) { + int value =3D virDomainStartupPolicyTypeFromString(startupPolicy); + if (value <=3D 0) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, _("Unknown startup policy '%s'"), startupPolicy); return -1; } + def->startupPolicy =3D value; } =20 if ((autoAddress =3D virXMLPropString(node, "autoAddress"))) diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h index 2d5462bb55..41e570765e 100644 --- a/src/conf/domain_conf.h +++ b/src/conf/domain_conf.h @@ -332,6 +332,15 @@ struct _virDomainHostdevCaps { }; =20 =20 +typedef enum { + VIR_DOMAIN_STARTUP_POLICY_DEFAULT =3D 0, + VIR_DOMAIN_STARTUP_POLICY_MANDATORY, + VIR_DOMAIN_STARTUP_POLICY_REQUISITE, + VIR_DOMAIN_STARTUP_POLICY_OPTIONAL, + + VIR_DOMAIN_STARTUP_POLICY_LAST +} virDomainStartupPolicy; + /* basic device for direct passthrough */ struct _virDomainHostdevDef { /* If 'parentnet' is non-NULL it means this host dev was @@ -343,7 +352,7 @@ struct _virDomainHostdevDef { virDomainNetDef *parentnet; =20 int mode; /* enum virDomainHostdevMode */ - int startupPolicy; /* enum virDomainStartupPolicy */ + virDomainStartupPolicy startupPolicy; bool managed; bool missing; bool readonly; @@ -432,16 +441,6 @@ typedef enum { VIR_DOMAIN_DISK_IO_LAST } virDomainDiskIo; =20 -typedef enum { - VIR_DOMAIN_STARTUP_POLICY_DEFAULT =3D 0, - VIR_DOMAIN_STARTUP_POLICY_MANDATORY, - VIR_DOMAIN_STARTUP_POLICY_REQUISITE, - VIR_DOMAIN_STARTUP_POLICY_OPTIONAL, - - VIR_DOMAIN_STARTUP_POLICY_LAST -} virDomainStartupPolicy; - - typedef enum { VIR_DOMAIN_DEVICE_SGIO_DEFAULT =3D 0, VIR_DOMAIN_DEVICE_SGIO_FILTERED, --=20 2.26.3