From nobody Mon Feb 9 10:28:09 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1620212170; cv=none; d=zohomail.com; s=zohoarc; b=Awg6LQ28AvmONsSJ5oLH9+P2ZhtI7Uve0rulRFMecO/kC9SUUlHuljQqLFO0B3aOcE/bAlB0PjCzMJKRRexFagtBQFjfo6jCIs6nhcF5hVhqt092VdS88OdaFrB8J6MwHeM9ibWH8Vw5tsHvqOJcjN4zmBmgOIR33hh+TRHLzbo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1620212170; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=9Na9AKxwFY8dAyTF6aXG43qvNcgDfzOd8f1qsiaxx1s=; b=d2X4yWf3OJ+8KGkozRWUTbPNfD+/TKNfYfWIzASFVUtBgLHDBJozD6nK7qo8PiTbq9KUAwVMGYQ/34SD3XFw4N5XPTdLnvM/Nt8id6x1WBu6D9WBDtwfl9ogOjN97ZrZ8I4UFWoxmm/0FhsIQDAk3nOkbvkOk/wvgxaNasF84d0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 162021217024898.7372675171132; Wed, 5 May 2021 03:56:10 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-310-0TdhOQ5nNMmSpumcHY6KGg-1; Wed, 05 May 2021 06:56:07 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6B21B1854E2E; Wed, 5 May 2021 10:56:02 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4B7FC5B4A6; Wed, 5 May 2021 10:56:02 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 18F8B1800BB4; Wed, 5 May 2021 10:56:02 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 145AtvrD025958 for ; Wed, 5 May 2021 06:55:57 -0400 Received: by smtp.corp.redhat.com (Postfix) id 371C018825; Wed, 5 May 2021 10:55:57 +0000 (UTC) Received: from work.redhat.com (ovpn-113-124.ams2.redhat.com [10.36.113.124]) by smtp.corp.redhat.com (Postfix) with ESMTP id 45E2460C17; Wed, 5 May 2021 10:55:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620212169; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=9Na9AKxwFY8dAyTF6aXG43qvNcgDfzOd8f1qsiaxx1s=; b=CefToxS3aiJH19Ag7RUTUkdtlxoNAY8czyhTY3TGJ4XfdPCNT89lDomKU3qHtBqnQODi4W M81IpdA4G7JOHj6uhY6izcf7pz+2pvF1JqQLovsrLpzJ9TmcYv8et5C65wQxu1vVk2afiB q0K2qY4M9HfDfw9QeQ7HfTuMq6MOZoI= X-MC-Unique: 0TdhOQ5nNMmSpumcHY6KGg-1 From: Tim Wiederhake To: libvir-list@redhat.com Subject: [libvirt PATCH v3 3/4] virDomainGraphicsDefParseXMLSpice: Make name and mode mandatory Date: Wed, 5 May 2021 12:55:47 +0200 Message-Id: <20210505105548.95348-4-twiederh@redhat.com> In-Reply-To: <20210505105548.95348-1-twiederh@redhat.com> References: <20210505105548.95348-1-twiederh@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-loop: libvir-list@redhat.com Cc: Tim Wiederhake X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Attributes are mandatory and were incorrectly made optional recently. Fixes: 2a5e16398eb622f30dabb16770d2e14b7a6d5212 Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index e7823ec2df..3c12a94627 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -12739,12 +12739,12 @@ virDomainGraphicsDefParseXMLSpice(virDomainGraphi= csDef *def, =20 if (virXMLPropEnum(node_list[i], "name", virDomainGraphicsSpiceChannelNameTypeFromString, - VIR_XML_PROP_NONE, &name) < 0) + VIR_XML_PROP_REQUIRED, &name) < 0) return -1; =20 if (virXMLPropEnum(node_list[i], "mode", virDomainGraphicsSpiceChannelModeTypeFromString, - VIR_XML_PROP_NONE, &mode) < 0) + VIR_XML_PROP_REQUIRED, &mode) < 0) return -1; =20 def->data.spice.channels[name] =3D mode; --=20 2.26.3