From nobody Sun Feb 8 16:32:27 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1620137004; cv=none; d=zohomail.com; s=zohoarc; b=PhNXWqXK9ZJmMlHiATtsh4Aecue2f2rEy/muqRcN1u+D7yPaB4bIEqZe8c2wefGU161cSalJSEmLl/HXRIxsjZSAzGJ7AcwCb33jhfuC7PjBT1vOJL+z0OVy6z1TAyAqAKQLPGIHnmcPqgDCMAxY1rCzfzwe5Rs5sKO75zO4ZLM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1620137004; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=DZ6oFpoFRDhjdjghOELM+oMguDYq/r0aIDjfUEELPHc=; b=HAjZjkJ2tr2lISpNVfGx79kqr6MvfMfi2QdAPahxl/PGIDnNOdUYbdi2S4ZVJ3vaA6IVzQo0N8DvLWVfpe3qfM6YLjLLQ3yiJWsEyLOgsn5S3fYy7lqW0tDScB5h4zfPHHV1s/ANdRVghNPrpM0u8d9LOVSsfQ4qpxZAB82r21o= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1620137004028929.680883223195; Tue, 4 May 2021 07:03:24 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-356-jYPCSa_VNISy2MA15NcVtw-1; Tue, 04 May 2021 10:02:59 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9764E1074642; Tue, 4 May 2021 14:02:51 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 72E3A5D9DD; Tue, 4 May 2021 14:02:51 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 1AAE3180C69B; Tue, 4 May 2021 14:02:51 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 144E2krL013161 for ; Tue, 4 May 2021 10:02:46 -0400 Received: by smtp.corp.redhat.com (Postfix) id 6551760C4A; Tue, 4 May 2021 14:02:46 +0000 (UTC) Received: from work.redhat.com (ovpn-115-86.ams2.redhat.com [10.36.115.86]) by smtp.corp.redhat.com (Postfix) with ESMTP id A950A60C0F; Tue, 4 May 2021 14:02:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620137001; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=DZ6oFpoFRDhjdjghOELM+oMguDYq/r0aIDjfUEELPHc=; b=Cx5ovkqHjQTpZxAC7yvpEkRavpf12AKd5Ey82Yt0B1XRbbpbFJI44kwoNj3w/xRcyouKsy BkBgUF/fUAkakQkITJbdMGz24h9XluDjI//l24nj4IZanIe+Cjfci+7PVwh4x2NXYt5oB4 ZDF3KzHQk6LDffsoAlc8p+xJ0kHKXXg= X-MC-Unique: jYPCSa_VNISy2MA15NcVtw-1 From: Tim Wiederhake To: libvir-list@redhat.com Subject: [libvirt PATCH 05/10] virDomainIOThreadPinDefParseXML: Use virXMLProp* Date: Tue, 4 May 2021 16:02:30 +0200 Message-Id: <20210504140235.132300-6-twiederh@redhat.com> In-Reply-To: <20210504140235.132300-1-twiederh@redhat.com> References: <20210504140235.132300-1-twiederh@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-loop: libvir-list@redhat.com Cc: Tim Wiederhake X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 20 +++----------------- 1 file changed, 3 insertions(+), 17 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index e95be17989..d7cef00246 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -17319,24 +17319,10 @@ virDomainIOThreadPinDefParseXML(xmlNodePtr node, g_autofree char *tmp =3D NULL; g_autoptr(virBitmap) cpumask =3D NULL; =20 - if (!(tmp =3D virXMLPropString(node, "iothread"))) { - virReportError(VIR_ERR_XML_ERROR, "%s", - _("missing iothread id in iothreadpin")); - return -1; - } - - if (virStrToLong_uip(tmp, NULL, 10, &iothreadid) < 0) { - virReportError(VIR_ERR_XML_ERROR, - _("invalid setting for iothread '%s'"), tmp); - return -1; - } - VIR_FREE(tmp); - - if (iothreadid =3D=3D 0) { - virReportError(VIR_ERR_XML_ERROR, "%s", - _("zero is an invalid iothread id value")); + if (virXMLPropUInt(node, "iothread", 10, + VIR_XML_PROP_REQUIRED | VIR_XML_PROP_NONZERO, + &iothreadid) < 0) return -1; - } =20 if (!(iothrid =3D virDomainIOThreadIDFind(def, iothreadid))) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, --=20 2.26.3