From nobody Tue Feb 10 03:44:54 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1620136989; cv=none; d=zohomail.com; s=zohoarc; b=PfkX2aTrUW0W+bDqy6nSgf96eo2Dl/mJopBBSt6qQDyT/TWqAlA7TQVNEXNPlVGYTk4zRvDFw6Bke+b4yT1CBikiY87Mq30HwyvjVuFOKRqJAtsaA9i3Wnv173u7n/ZDQNUyiur0kEa4JQG4TxxpywfcIN0WYjQLMOu20emSxjE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1620136989; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=RHnvRFDD+p2XRyTSTTsUyK7EUnD5znGkd8yzw6T+Voc=; b=R6EGR1CeCiKcnrsyIPd/kcf5IlnnDTWg3TAfjIAJ1NS2dXFKrnC7JqcaOxfBn14wMuu3FT1tY+xH5DldJyfi6YYnqa+pZSmC05DWO0S9d/q0Ij6qJK2oyPpuY+aDJVbQzU2ODhyIIJVAGeTN7ZG98TRVD2JcmvGjKbo0wOBs9mE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1620136989339630.4120984834889; Tue, 4 May 2021 07:03:09 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-464-6OMJ0Tg-Mmu7-_Srl1Rumg-1; Tue, 04 May 2021 10:02:56 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 64DA0107ACE6; Tue, 4 May 2021 14:02:48 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 39BC510016F8; Tue, 4 May 2021 14:02:48 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id F28951800FFC; Tue, 4 May 2021 14:02:47 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 144E2jQ4013141 for ; Tue, 4 May 2021 10:02:45 -0400 Received: by smtp.corp.redhat.com (Postfix) id 561E917A7B; Tue, 4 May 2021 14:02:45 +0000 (UTC) Received: from work.redhat.com (ovpn-115-86.ams2.redhat.com [10.36.115.86]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9DDFA60C0F; Tue, 4 May 2021 14:02:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620136986; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=RHnvRFDD+p2XRyTSTTsUyK7EUnD5znGkd8yzw6T+Voc=; b=YfrGpalMRrcxRF+cap6UV056dPOlt6d3UGDAlrV13k5OqGPm4JdPGPEdOTvkJ5783ntKDR 3SohTC/ycNkbCCcn3bTck5qoLP26AfaR9HDXVVo7lRu+nTFtEhjLrlkju5Wl//tMAxDBYC vdrH5NQ2s2Sh4sdS1ZXoVARmaIV+3A0= X-MC-Unique: 6OMJ0Tg-Mmu7-_Srl1Rumg-1 From: Tim Wiederhake To: libvir-list@redhat.com Subject: [libvirt PATCH 04/10] virDomainVcpuPinDefParseXML: Use virXMLProp* Date: Tue, 4 May 2021 16:02:29 +0200 Message-Id: <20210504140235.132300-5-twiederh@redhat.com> In-Reply-To: <20210504140235.132300-1-twiederh@redhat.com> References: <20210504140235.132300-1-twiederh@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-loop: libvir-list@redhat.com Cc: Tim Wiederhake X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index b8ac399f5c..e95be17989 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -17273,17 +17273,8 @@ virDomainVcpuPinDefParseXML(virDomainDef *def, unsigned int vcpuid; g_autofree char *tmp =3D NULL; =20 - if (!(tmp =3D virXMLPropString(node, "vcpu"))) { - virReportError(VIR_ERR_XML_ERROR, "%s", _("missing vcpu id in vcpu= pin")); + if (virXMLPropUInt(node, "vcpu", 10, VIR_XML_PROP_REQUIRED, &vcpuid) <= 0) return -1; - } - - if (virStrToLong_uip(tmp, NULL, 10, &vcpuid) < 0) { - virReportError(VIR_ERR_XML_ERROR, - _("invalid setting for vcpu '%s'"), tmp); - return -1; - } - VIR_FREE(tmp); =20 if (!(vcpu =3D virDomainDefGetVcpu(def, vcpuid))) { VIR_WARN("Ignoring vcpupin for missing vcpus"); --=20 2.26.3