From nobody Sun Feb 8 18:49:33 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1620039582; cv=none; d=zohomail.com; s=zohoarc; b=CRJHZ5x2jvHv1ldYqkznduzQXDT+ZOc7IzjkVhvyuB/xrM/zYVUcXeW9Ayma1Oxqafa8QBS5KK3Y0z6q/gNNoG1gvoSNFZYmdoD/SlXJqcbOhdC6XtJCw/RXAVLbGPKlMuBo59/XZ7Lk3lOWtUp9ZBtlp/YglO2TuLcCHwhjY+E= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1620039582; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=QZatndtEgmu+kxoc/tJEbeUHdCaWYEM9bXwU1A7N4Uc=; b=X2pK+u/0Gd1fBirOAkSQDEy6KtTutiTJU2b1J6+ocNb7NNukJrXkrSNFOA9ChQyE+jfMr6bPPz/aIdUZNlnzbwp5lcOPqQAmqz/TD+hBXbPWupNqaAhNTIzv4xFxuWWe/M3Iyh/6tg47h5Ra5KF8Q4lO++Z5FQDQcpc5zyXXrZc= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1620039582650995.6866286178093; Mon, 3 May 2021 03:59:42 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-3-bi9pXywKPQKxnBBehUXX4A-1; Mon, 03 May 2021 06:59:39 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9A2048049CC; Mon, 3 May 2021 10:59:32 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 79BF9369A; Mon, 3 May 2021 10:59:32 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 340A61800BBE; Mon, 3 May 2021 10:59:32 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 143AxVUj006009 for ; Mon, 3 May 2021 06:59:31 -0400 Received: by smtp.corp.redhat.com (Postfix) id 64AC31D0B0; Mon, 3 May 2021 10:59:31 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast01.extmail.prod.ext.rdu2.redhat.com [10.11.55.17]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5E2789E9B for ; Mon, 3 May 2021 10:59:25 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 5E0B48058DC for ; Mon, 3 May 2021 10:59:25 +0000 (UTC) Received: from mo4-p00-ob.smtp.rzone.de (mo4-p00-ob.smtp.rzone.de [85.215.255.23]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-307-bL1uMTqUPQCWu0L1VAITlw-1; Mon, 03 May 2021 06:59:23 -0400 Received: from sender by smtp.strato.de (RZmta 47.25.4 AUTH) with ESMTPSA id m06458x43AuJ0m0 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Mon, 3 May 2021 12:56:19 +0200 (CEST) X-MC-Unique: bi9pXywKPQKxnBBehUXX4A-1 X-MC-Unique: bL1uMTqUPQCWu0L1VAITlw-1 X-RZG-AUTH: ":P2EQZWCpfu+qG7CngxMFH1J+3q8wa/QXkBR9MXjAuzpIG0mv9coXAgtl+1b1FMstFZvCqIQN5N7TvWFg4vzhFVdoKAuQ" X-RZG-CLASS-ID: mo00 From: Olaf Hering To: libvir-list@redhat.com Subject: [PATCH v1 1/4] libxl: remove obsolete VIR_LIBXL_EVENT_CONST Date: Mon, 3 May 2021 12:56:10 +0200 Message-Id: <20210503105613.19554-2-olaf@aepfle.de> In-Reply-To: <20210503105613.19554-1-olaf@aepfle.de> References: <20210503105613.19554-1-olaf@aepfle.de> MIME-Version: 1.0 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-loop: libvir-list@redhat.com Cc: Olaf Hering X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In Xen 4.2 struct libxl_event_hooks had a member which was erroneously declared const. Since libvirt requires at least Xen 4.6, remove the dead code. Signed-off-by: Olaf Hering Reviewed-by: Jim Fehlig --- src/libxl/libxl_domain.c | 2 +- src/libxl/libxl_domain.h | 14 +------------- 2 files changed, 2 insertions(+), 14 deletions(-) diff --git a/src/libxl/libxl_domain.c b/src/libxl/libxl_domain.c index 917f6f1d81..d78765ad84 100644 --- a/src/libxl/libxl_domain.c +++ b/src/libxl/libxl_domain.c @@ -641,7 +641,7 @@ libxlDomainHandleDeath(libxlDriverPrivate *driver, virD= omainObj *vm) * Handle previously registered domain event notification from libxenlight. */ void -libxlDomainEventHandler(void *data, VIR_LIBXL_EVENT_CONST libxl_event *eve= nt) +libxlDomainEventHandler(void *data, libxl_event *event) { libxlDriverPrivate *driver =3D data; libxl_shutdown_reason xl_reason =3D event->u.domain_shutdown.shutdown_= reason; diff --git a/src/libxl/libxl_domain.h b/src/libxl/libxl_domain.h index 8223b1d255..cbe7ba19ba 100644 --- a/src/libxl/libxl_domain.h +++ b/src/libxl/libxl_domain.h @@ -117,20 +117,8 @@ void libxlDomainCleanup(libxlDriverPrivate *driver, virDomainObj *vm); =20 -/* - * Note: Xen 4.3 removed the const from the event handler signature. - * Detect which signature to use based on - * LIBXL_HAVE_NONCONST_EVENT_OCCURS_EVENT_ARG. - */ -#ifdef LIBXL_HAVE_NONCONST_EVENT_OCCURS_EVENT_ARG -# define VIR_LIBXL_EVENT_CONST /* empty */ -#else -# define VIR_LIBXL_EVENT_CONST const -#endif - void -libxlDomainEventHandler(void *data, - VIR_LIBXL_EVENT_CONST libxl_event *event); +libxlDomainEventHandler(void *data, libxl_event *event); =20 int libxlDomainAutoCoreDump(libxlDriverPrivate *driver,