From nobody Wed May 1 21:31:55 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1619192393; cv=none; d=zohomail.com; s=zohoarc; b=ak4NuFcNtPi3Ls74cVmKtia6HxN0qHXJQBuZDxWkdqv5EVaoD0SEE4/d4fOf0qVy7fiGcEt2PX8h1DxdTtWxP3Du18dvG4PC98Z6Oke8JSpkz+htYnQHbiNnLNE3tibok/hhKOsF+d3M0D9iPJtfE5PZuJ2yhRMiWVos5oz7dqo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1619192393; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=ZvRaFEdPlGPiAYfZZHN9OXbaWGv8eI1EPPA75Z8lLQo=; b=HRxRmRUQhjDLRJqoyOvFsfzl8Tqc4kylfOLPrUMCKc5MSWNxy+q0z5DSYT1dvCeBuFwt0gTZidzO8AVeZ2zzAETIT3g8aPc2bAAr5VNv0DnoYjn3jCewLDe7EUG2fVqqZF0w5dppTzhk5yV6eCaOyxMD0CtaotT52gmNcmuTpV4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1619192393447556.1793437339242; Fri, 23 Apr 2021 08:39:53 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-109-qi4ZXNjuNi68kpzHx8E87Q-1; Fri, 23 Apr 2021 11:39:49 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 19A6D8030CA; Fri, 23 Apr 2021 15:39:43 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E7E06295D5; Fri, 23 Apr 2021 15:39:42 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id AFF7B44A61; Fri, 23 Apr 2021 15:39:42 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 13NFdVih004208 for ; Fri, 23 Apr 2021 11:39:31 -0400 Received: by smtp.corp.redhat.com (Postfix) id 1D6326090F; Fri, 23 Apr 2021 15:39:31 +0000 (UTC) Received: from work.redhat.com (ovpn-115-30.ams2.redhat.com [10.36.115.30]) by smtp.corp.redhat.com (Postfix) with ESMTP id 56E7F60854; Fri, 23 Apr 2021 15:39:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1619192392; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=ZvRaFEdPlGPiAYfZZHN9OXbaWGv8eI1EPPA75Z8lLQo=; b=efLdR4AVTKN+0HMIk0OKY+W2Ppu4YvbQwqsSQoLB3Cz7dI/8nBKmopuqsRxsRUZq4vsxt2 N80/URoeNZpQjjPyrjN3U2iTXpksp8fkPUASYnX/0CDzcz/hsg2iTHlobpDdz6cA9ytUrc fSJCoo7ogTVv5Xjc/oL2KMLsv1CxqF8= X-MC-Unique: qi4ZXNjuNi68kpzHx8E87Q-1 From: Tim Wiederhake To: libvir-list@redhat.com Subject: [libvirt PATCH 02/10] virDomainGraphicsDefParseXMLDesktop: Use virXMLProp* Date: Fri, 23 Apr 2021 17:39:15 +0200 Message-Id: <20210423153923.339223-3-twiederh@redhat.com> In-Reply-To: <20210423153923.339223-1-twiederh@redhat.com> References: <20210423153923.339223-1-twiederh@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com Cc: Tim Wiederhake X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 5b0e90f234..d57450b3c0 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -12885,18 +12885,13 @@ static int virDomainGraphicsDefParseXMLDesktop(virDomainGraphicsDef *def, xmlNodePtr node) { - g_autofree char *fullscreen =3D virXMLPropString(node, "fullscreen"); + virTristateBool fullscreen =3D VIR_TRISTATE_BOOL_NO; =20 - if (fullscreen !=3D NULL) { - if (virStringParseYesNo(fullscreen, &def->data.desktop.fullscreen)= < 0) { - virReportError(VIR_ERR_INTERNAL_ERROR, - _("unknown fullscreen value '%s'"), fullscreen); - return -1; - } - } else { - def->data.desktop.fullscreen =3D false; - } + if (virXMLPropTristateBool(node, "fullscreen", VIR_XML_PROP_NONE, + &fullscreen) < 0) + return -1; =20 + def->data.desktop.fullscreen =3D fullscreen =3D=3D VIR_TRISTATE_BOOL_Y= ES; def->data.desktop.display =3D virXMLPropString(node, "display"); =20 return 0; --=20 2.26.3