[libvirt PATCH 00/10] Refactor more XML parsing boilerplate code, part VI

Tim Wiederhake posted 10 patches 3 weeks, 3 days ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20210423153923.339223-1-twiederh@redhat.com
src/conf/domain_conf.c                        | 683 +++++-------------
src/conf/domain_conf.h                        |   6 +-
src/qemu/qemu_command.c                       |   2 +-
src/qemu/qemu_domain_address.c                |   2 +-
src/qemu/qemu_validate.c                      |   2 +-
.../qemuxml2argvdata/aarch64-gic-invalid.err  |   2 +-
6 files changed, 206 insertions(+), 491 deletions(-)

[libvirt PATCH 00/10] Refactor more XML parsing boilerplate code, part VI

Posted by Tim Wiederhake 3 weeks, 3 days ago
For background, see
https://listman.redhat.com/archives/libvir-list/2021-April/msg00668.html

Tim Wiederhake (10):
  virDomainGraphicsDefParseXMLSDL: Use virXMLProp*
  virDomainGraphicsDefParseXMLDesktop: Use virXMLProp*
  virDomainGraphicsDefParseXMLSpice: Use virXMLProp*
  virDomainGraphicsDefParseXML: Use virXMLProp*
  virDomainSoundDef: Change type of model to virDomainSoundModel
  virDomainSoundDefParseXML: Use virXMLProp*
  virDomainDef: Change type of hyperv_stimer_direct to virTristateSwitch
  virDomainDef: Change type of xen_passthrough_mode to
    virDomainXenPassthroughMode
  virDomainFeaturesDefParse: Use virXMLProp*
  virDomainAudioSDLParse: Use virXMLProp*

 src/conf/domain_conf.c                        | 683 +++++-------------
 src/conf/domain_conf.h                        |   6 +-
 src/qemu/qemu_command.c                       |   2 +-
 src/qemu/qemu_domain_address.c                |   2 +-
 src/qemu/qemu_validate.c                      |   2 +-
 .../qemuxml2argvdata/aarch64-gic-invalid.err  |   2 +-
 6 files changed, 206 insertions(+), 491 deletions(-)

-- 
2.26.3


Re: [libvirt PATCH 00/10] Refactor more XML parsing boilerplate code, part VI

Posted by Peter Krempa 3 weeks ago
On Fri, Apr 23, 2021 at 17:39:13 +0200, Tim Wiederhake wrote:
> For background, see
> https://listman.redhat.com/archives/libvir-list/2021-April/msg00668.html
> 
> Tim Wiederhake (10):
>   virDomainGraphicsDefParseXMLSDL: Use virXMLProp*
>   virDomainGraphicsDefParseXMLDesktop: Use virXMLProp*
>   virDomainGraphicsDefParseXMLSpice: Use virXMLProp*
>   virDomainGraphicsDefParseXML: Use virXMLProp*
>   virDomainSoundDef: Change type of model to virDomainSoundModel
>   virDomainSoundDefParseXML: Use virXMLProp*
>   virDomainDef: Change type of hyperv_stimer_direct to virTristateSwitch
>   virDomainDef: Change type of xen_passthrough_mode to
>     virDomainXenPassthroughMode
>   virDomainFeaturesDefParse: Use virXMLProp*
>   virDomainAudioSDLParse: Use virXMLProp*

Patches which I've didn't reply to have been

Reviewed-by: Peter Krempa <pkrempa@redhat.com>

and will be pushed shortly.