From nobody Mon Feb 9 11:28:54 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1619174290; cv=none; d=zohomail.com; s=zohoarc; b=jYsiFadeSpidjMu9I8sydmabgFMYf0+WNUuxdrHHAocSSxQ1TTV/Ga8ItSZSwDhyQgdopm5uup40W3sJMXJzq5mqtIr1sg3Nsky/6MmRBLvjQEq6N3ME1nX5hQzpd99Ho3Vn2LIG7LCrol/0WhzBTpMXZDm3zP2rEoTtcjkV1fs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1619174290; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=SkSRP9FXighrme12Ccv/Y+5TQ3sVjwCar/N1B2L/2es=; b=IoC4gosGqGrH9pvkr2VDcz5W9Gla5/7fE5ddJtMCeKJ0yl5vAx5p7VNz6w7hta2XT7DZBpjFGAKETB4pOPxYaPSnYR/EGChMUHcI2fwK4JBhvgOq3V9Gw0vk2dy4Lve4ywKU3rZkU1jZE+aaa8wjrxG/nVijSruFLjw2MTZpLWM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1619174290903557.2802355793906; Fri, 23 Apr 2021 03:38:10 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-153-Ca_W0Op_OEa9bKU4RMnN1g-1; Fri, 23 Apr 2021 06:38:07 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8C68718BA286; Fri, 23 Apr 2021 10:38:01 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 433EE60C5A; Fri, 23 Apr 2021 10:38:00 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 7EBED1806D1A; Fri, 23 Apr 2021 10:37:56 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 13NAbsu5004020 for ; Fri, 23 Apr 2021 06:37:54 -0400 Received: by smtp.corp.redhat.com (Postfix) id 1DFC85C3FD; Fri, 23 Apr 2021 10:37:54 +0000 (UTC) Received: from work.redhat.com (ovpn-115-30.ams2.redhat.com [10.36.115.30]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5A8645C5E0; Fri, 23 Apr 2021 10:37:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1619174289; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=SkSRP9FXighrme12Ccv/Y+5TQ3sVjwCar/N1B2L/2es=; b=MxiLwTd1vaDEdTbftU/FTT5zwdbM2UodsDcf39EJbsN1DMgoU4bOIukbsSyYuoysHeH/3P wUJHyp7wZW3eXPvNvzhy9yIN0OpXs4ddfWDb25joFiyFRa39b2KupwJzIale9mqfX8S/TI 8zWcFAAOJ6THivnMnUjN8G+g7/g9DhQ= X-MC-Unique: Ca_W0Op_OEa9bKU4RMnN1g-1 From: Tim Wiederhake To: libvir-list@redhat.com Subject: [libvirt PATCH 01/10] virXMLPropEnum: Fix return value Date: Fri, 23 Apr 2021 12:37:32 +0200 Message-Id: <20210423103741.65814-2-twiederh@redhat.com> In-Reply-To: <20210423103741.65814-1-twiederh@redhat.com> References: <20210423103741.65814-1-twiederh@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-loop: libvir-list@redhat.com Cc: Tim Wiederhake X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Function incorrectly returns 0 when property was successfully read. Fixes: ab5d2776c925ec45eb54ec5432f5645cebb80c85 Signed-off-by: Tim Wiederhake Reviewed-by: J=C3=A1n Tomko --- src/util/virxml.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/virxml.c b/src/util/virxml.c index b79050db35..01c0114072 100644 --- a/src/util/virxml.c +++ b/src/util/virxml.c @@ -856,7 +856,7 @@ virXMLPropEnum(xmlNodePtr node, } =20 *result =3D ret; - return 0; + return 1; } =20 /** --=20 2.26.3