[libvirt PATCH 00/10] Refactor more XML parsing boilerplate code, part IV

Tim Wiederhake posted 10 patches 3 weeks, 5 days ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20210422103257.119508-1-twiederh@redhat.com
src/conf/domain_conf.c | 176 +++++++++++++----------------------------
src/conf/domain_conf.h |  12 +--
2 files changed, 61 insertions(+), 127 deletions(-)

[libvirt PATCH 00/10] Refactor more XML parsing boilerplate code, part IV

Posted by Tim Wiederhake 3 weeks, 5 days ago
For background, see
https://listman.redhat.com/archives/libvir-list/2021-April/msg00668.html

Tim Wiederhake (10):
  virDomainDiskDef: Change type of cachemode to virDomainDiskCache
  virDomainDiskDef: Change type of error_policy to
    virDomainDiskErrorPolicy
  virDomainDiskDef: Change type of rerror_policy to
    virDomainDiskErrorPolicy
  virDomainDiskDef: Change type of iomode to virDomainDiskInfo
  virDomainDiskDef: Change type of discard to virDomainDiskDiscard
  virDomainDiskDef: Change type of detect_zeroes to
    virDomainDiskDetectZeroes
  virDomainDiskDefDriverParseXML: Use virXMLProp*
  domain_conf: Introduce function virDomainChrSouceModeTypeFromString
  domain_conf: Remove function virDomainChrSourceDefParseMode
  virDomainChrSourceDefParseTCP: Use virXMLProp*

 src/conf/domain_conf.c | 176 +++++++++++++----------------------------
 src/conf/domain_conf.h |  12 +--
 2 files changed, 61 insertions(+), 127 deletions(-)

-- 
2.26.3


Re: [libvirt PATCH 00/10] Refactor more XML parsing boilerplate code, part IV

Posted by Michal Privoznik 3 weeks, 4 days ago
On 4/22/21 12:32 PM, Tim Wiederhake wrote:
> For background, see
> https://listman.redhat.com/archives/libvir-list/2021-April/msg00668.html
> 
> Tim Wiederhake (10):
>    virDomainDiskDef: Change type of cachemode to virDomainDiskCache
>    virDomainDiskDef: Change type of error_policy to
>      virDomainDiskErrorPolicy
>    virDomainDiskDef: Change type of rerror_policy to
>      virDomainDiskErrorPolicy
>    virDomainDiskDef: Change type of iomode to virDomainDiskInfo
>    virDomainDiskDef: Change type of discard to virDomainDiskDiscard
>    virDomainDiskDef: Change type of detect_zeroes to
>      virDomainDiskDetectZeroes
>    virDomainDiskDefDriverParseXML: Use virXMLProp*
>    domain_conf: Introduce function virDomainChrSouceModeTypeFromString
>    domain_conf: Remove function virDomainChrSourceDefParseMode
>    virDomainChrSourceDefParseTCP: Use virXMLProp*
> 
>   src/conf/domain_conf.c | 176 +++++++++++++----------------------------
>   src/conf/domain_conf.h |  12 +--
>   2 files changed, 61 insertions(+), 127 deletions(-)
> 

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

and pushed.

Michal