From nobody Sat Feb 7 07:10:16 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1619012043; cv=none; d=zohomail.com; s=zohoarc; b=c9bEg4Vgxwrahp1tXPBw9w++LW2+mUWZi7sxGErdBpiD1AehN51NjttO/O3ZBtjgPcurzqXkI+X6Ly8SAMDF5mqKY1rrXibKCPBuGw1/Al6N0aISPTmy0psUscuwAbihzZ/u/XPDNfo8p4D/xhU5+OjKuB+KzG9jbe1Y+nzVkU8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1619012043; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=NZEYOTOEzf5KAg+uDjT+Kmp8TmLFyYaYtEVV4XFjuM0=; b=b4DiPzMf9LKvH4bzF9fu0RNFUsMFNFtn0C2Lg7neUt/DcUQ61cBN2ymjEuyUNfgudxvTZKb8jvnygrBEjCqIGQ+0vKgpvGc8CRi3xrmaoRchI9DwrmDf2kONthtrViiBYWW2KqHoMX2TRKyZBslH03a0LfZXgJWMIVYuirFxnFw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1619012043760223.3520204837488; Wed, 21 Apr 2021 06:34:03 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-541-LuN0BWRnPle9D09MjDTNDw-1; Wed, 21 Apr 2021 09:34:00 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7E644107464C; Wed, 21 Apr 2021 13:33:52 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5FC3B50F1A; Wed, 21 Apr 2021 13:33:52 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 1668444A64; Wed, 21 Apr 2021 13:33:52 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 13LDXlMn019816 for ; Wed, 21 Apr 2021 09:33:47 -0400 Received: by smtp.corp.redhat.com (Postfix) id 9BFF86362B; Wed, 21 Apr 2021 13:33:47 +0000 (UTC) Received: from work.redhat.com (ovpn-112-172.ams2.redhat.com [10.36.112.172]) by smtp.corp.redhat.com (Postfix) with ESMTP id E7E39629C0; Wed, 21 Apr 2021 13:33:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1619012042; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=NZEYOTOEzf5KAg+uDjT+Kmp8TmLFyYaYtEVV4XFjuM0=; b=AKmA+SwdkBclHcOvjqKMq2pTpCWlOUupDF0u7Af9xiHRAy+EYkIwWZB8hFtDs3HOd0Ypf3 laeBQQxfLbt3fSmMlXGzrmMVZ7LxK3dSxOePfnPxGxhTdqzRSscMQj+jLcMrk0nTL2W4xn RjVX640BpWTq46yWBT0GHztqCD58spE= X-MC-Unique: LuN0BWRnPle9D09MjDTNDw-1 From: Tim Wiederhake To: libvir-list@redhat.com Subject: [libvirt PATCH 08/10] virDomainVideoResolutionDefParseXML: Use virXMLProp* Date: Wed, 21 Apr 2021 15:33:30 +0200 Message-Id: <20210421133332.59662-9-twiederh@redhat.com> In-Reply-To: <20210421133332.59662-1-twiederh@redhat.com> References: <20210421133332.59662-1-twiederh@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com Cc: Tim Wiederhake X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 21 ++------------------- 1 file changed, 2 insertions(+), 19 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index ec7d48b40e..9e968c087d 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -14914,31 +14914,14 @@ static virDomainVideoResolutionDef * virDomainVideoResolutionDefParseXML(xmlNodePtr node) { g_autofree virDomainVideoResolutionDef *def =3D NULL; - g_autofree char *x =3D NULL; - g_autofree char *y =3D NULL; - - x =3D virXMLPropString(node, "x"); - y =3D virXMLPropString(node, "y"); - - if (!x || !y) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("missing values for resolution")); - return NULL; - } =20 def =3D g_new0(virDomainVideoResolutionDef, 1); =20 - if (virStrToLong_uip(x, NULL, 10, &def->x) < 0) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, - _("cannot parse video x-resolution '%s'"), x); + if (virXMLPropUInt(node, "x", 10, VIR_XML_PROP_REQUIRED, &def->x) < 0) return NULL; - } =20 - if (virStrToLong_uip(y, NULL, 10, &def->y) < 0) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, - _("cannot parse video y-resolution '%s'"), y); + if (virXMLPropUInt(node, "y", 10, VIR_XML_PROP_REQUIRED, &def->y) < 0) return NULL; - } =20 return g_steal_pointer(&def); } --=20 2.26.3