From nobody Sat Feb 7 07:09:50 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1619012049; cv=none; d=zohomail.com; s=zohoarc; b=Eg+QrH9IgG3JR/y0I0DfMjHFPXCVlJNeJCFt9ynNg1RerD8Sxlx67ixX6aM7CD7zNURVcWjOSfXgA/PRiCduEuE8Bk7FxpEcH1TWjYS15GxwQHrUOj1t9iU4KkxswXk6KpaqBkTW+Hegz/3K6LarP9T3tsxSkqM0JoIRNCbS2JA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1619012049; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=EbNWf2NzGkEihJDE+B6W6Lpc2b7b0/NgF9PNHyiBrG0=; b=ToaTCuRWZggLd1bCUd981IhxtyyMKqPP6amaf1ii3VIo+uh8d6zmDkoVf5RyGRBUwixmULp2+1NZLzXpaRXJkEhHAl2gde5Uhsq2j7XzhIlCE6cs+zPMriHB+lwqBtYJ8fzsCHGjFo7WG3GjI0W6qt3fTolkc2n2wQQ9ro31b6w= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1619012049374814.1598885229074; Wed, 21 Apr 2021 06:34:09 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-579-IbI6lQFSN1Ori0MYpXxf5A-1; Wed, 21 Apr 2021 09:34:05 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 37CE583DE6C; Wed, 21 Apr 2021 13:33:55 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1045C5DAA5; Wed, 21 Apr 2021 13:33:55 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id C41EE44A6A; Wed, 21 Apr 2021 13:33:54 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 13LDXkZZ019808 for ; Wed, 21 Apr 2021 09:33:46 -0400 Received: by smtp.corp.redhat.com (Postfix) id 96DFA63634; Wed, 21 Apr 2021 13:33:46 +0000 (UTC) Received: from work.redhat.com (ovpn-112-172.ams2.redhat.com [10.36.112.172]) by smtp.corp.redhat.com (Postfix) with ESMTP id DD617629C0; Wed, 21 Apr 2021 13:33:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1619012048; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=EbNWf2NzGkEihJDE+B6W6Lpc2b7b0/NgF9PNHyiBrG0=; b=JVqhfgwKd6rMTAJbOFrQVUCcfUKcGzDMYyC2+lYh/3kOHTbBy1sOmoiwmf78OhG41Xo8o5 tGcO6xpP3Vzz0ja87nursm4lsVdnGMC5ECxpyU0HXMQ1ubxTHsEybvExNtKXat5H754LcF tebswUEWtPsoHpg6xurM/VxsLecpcpc= X-MC-Unique: IbI6lQFSN1Ori0MYpXxf5A-1 From: Tim Wiederhake To: libvir-list@redhat.com Subject: [libvirt PATCH 07/10] virDomainAudioJackParse: Use virXMLProp* Date: Wed, 21 Apr 2021 15:33:29 +0200 Message-Id: <20210421133332.59662-8-twiederh@redhat.com> In-Reply-To: <20210421133332.59662-1-twiederh@redhat.com> References: <20210421133332.59662-1-twiederh@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com Cc: Tim Wiederhake X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index c97a062d1f..ec7d48b40e 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -13806,19 +13806,13 @@ static int virDomainAudioJackParse(virDomainAudioIOJack *def, xmlNodePtr node) { - g_autofree char *exactName =3D virXMLPropString(node, "exactName"); - def->serverName =3D virXMLPropString(node, "serverName"); def->clientName =3D virXMLPropString(node, "clientName"); def->connectPorts =3D virXMLPropString(node, "connectPorts"); =20 - if (exactName && - ((def->exactName =3D - virTristateBoolTypeFromString(exactName)) <=3D 0)) { - virReportError(VIR_ERR_XML_ERROR, - _("unknown 'exactName' value '%s'"), exactName); + if (virXMLPropTristateBool(node, "exactName", VIR_XML_PROP_NONE, + &def->exactName) < 0) return -1; - } =20 return 0; } --=20 2.26.3