From nobody Mon Feb 9 11:47:07 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1619006964; cv=none; d=zohomail.com; s=zohoarc; b=ImVEtz8W97f7PE6Cnk1bQK6XiL9v3ilP/FeIulf52Q7V66T6B2w0b0eUURCu1k9lBZUDX/Slq6f7oJHsiLXnenLM4FD+zOzSEWxbXikiLys0qa12pSZZfHJUqQcBVDvnzRmMKgSB0J7Xws5ce8+4+eS4siVwrKbQeKxRX8ZXFns= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1619006964; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=UgHZsnCg/tFdFTsLqMsX6DUXr4nZCPb9qKvi6zPUgII=; b=Nt+aTdizdpk7uXcH3ZpukeQ9y6insXr9LqE4nmjL0SXwZ3AZsH48xc4QslWUdPm8gk7+HSTv3tuLi5w/FibpcUwB2Rqju9tL2Rc8XtozxYBLFDQfLL5H9avdg8C1n/6Q+N/fyC8QjFoQ/7+szN2IZDS0UA4c8RnJ2rzarFlvbxo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1619006964543569.7351385005057; Wed, 21 Apr 2021 05:09:24 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-322-5gDiS_FdN3GEKfHBMpa0Iw-1; Wed, 21 Apr 2021 08:09:15 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id CE4918542CD; Wed, 21 Apr 2021 12:09:08 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id AAE6D60C05; Wed, 21 Apr 2021 12:09:08 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 66F8655345; Wed, 21 Apr 2021 12:09:08 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 13LC8MG3008673 for ; Wed, 21 Apr 2021 08:08:22 -0400 Received: by smtp.corp.redhat.com (Postfix) id 12B0B60916; Wed, 21 Apr 2021 12:08:22 +0000 (UTC) Received: from work.redhat.com (ovpn-112-172.ams2.redhat.com [10.36.112.172]) by smtp.corp.redhat.com (Postfix) with ESMTP id 31E0360871; Wed, 21 Apr 2021 12:08:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1619006962; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=UgHZsnCg/tFdFTsLqMsX6DUXr4nZCPb9qKvi6zPUgII=; b=NyoRS/J0YQM5eEVjoDN/v9YtgGKP6iswnBWLAbTsCQbYH2VdDo8BqpnJToqa7EapW7EP0e OHZxW7qalH9CK8BbxWtQkQXxQ1JHESHfgg/L3vwEh4rvKVjQvNCvoX8Ovd5qXleNP8EOQN JvxwJDNr+/TAsOMwFHBJOnEPfNXFqnc= X-MC-Unique: 5gDiS_FdN3GEKfHBMpa0Iw-1 From: Tim Wiederhake To: libvir-list@redhat.com Subject: [libvirt PATCH v2 06/10] virDomainDeviceDriveAddressParseXML: Use virXMLProp* Date: Wed, 21 Apr 2021 14:08:04 +0200 Message-Id: <20210421120808.35786-7-twiederh@redhat.com> In-Reply-To: <20210421120808.35786-1-twiederh@redhat.com> References: <20210421120808.35786-1-twiederh@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com Cc: Peter Krempa , Tim Wiederhake X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Signed-off-by: Tim Wiederhake Reviewed-by: Peter Krempa --- src/conf/device_conf.c | 31 ++++++------------------------- 1 file changed, 6 insertions(+), 25 deletions(-) diff --git a/src/conf/device_conf.c b/src/conf/device_conf.c index e527899d7d..66b7af109f 100644 --- a/src/conf/device_conf.c +++ b/src/conf/device_conf.c @@ -319,40 +319,21 @@ int virDomainDeviceDriveAddressParseXML(xmlNodePtr node, virDomainDeviceDriveAddress *addr) { - g_autofree char *controller =3D virXMLPropString(node, "controller"); - g_autofree char *bus =3D virXMLPropString(node, "bus"); - g_autofree char *target =3D virXMLPropString(node, "target"); - g_autofree char *unit =3D virXMLPropString(node, "unit"); - memset(addr, 0, sizeof(*addr)); =20 - if (controller && - virStrToLong_uip(controller, NULL, 10, &addr->controller) < 0) { - virReportError(VIR_ERR_INTERNAL_ERROR, "%s", - _("Cannot parse
'controller' attribute")); + if (virXMLPropUInt(node, "controller", 10, VIR_XML_PROP_NONE, + &addr->controller) < 0) return -1; - } =20 - if (bus && - virStrToLong_uip(bus, NULL, 10, &addr->bus) < 0) { - virReportError(VIR_ERR_INTERNAL_ERROR, "%s", - _("Cannot parse
'bus' attribute")); + if (virXMLPropUInt(node, "bus", 10, VIR_XML_PROP_NONE, &addr->bus) < 0) return -1; - } =20 - if (target && - virStrToLong_uip(target, NULL, 10, &addr->target) < 0) { - virReportError(VIR_ERR_INTERNAL_ERROR, "%s", - _("Cannot parse
'target' attribute")); + if (virXMLPropUInt(node, "target", 10, VIR_XML_PROP_NONE, + &addr->target) < 0) return -1; - } =20 - if (unit && - virStrToLong_uip(unit, NULL, 10, &addr->unit) < 0) { - virReportError(VIR_ERR_INTERNAL_ERROR, "%s", - _("Cannot parse
'unit' attribute")); + if (virXMLPropUInt(node, "unit", 10, VIR_XML_PROP_NONE, &addr->unit) <= 0) return -1; - } =20 return 0; } --=20 2.26.3