From nobody Mon Feb 9 14:33:35 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1619006955; cv=none; d=zohomail.com; s=zohoarc; b=UbGOI7YGhM7quIGXlYxILp9Xw/hYO0Js8w2D+cv7t0YRm5E05oUz96hlr+7UDgzZGq3DFU1/g1fkbWropfu4DoNYfP8+SCvtTOqmBblbhMGIUgiTABqeD9iooPyEBAuxwPeDqDhIZSJ/uN1Vbss2DgEy6pQgNLlOKWCEI8Or0UQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1619006955; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=jXnAyBr/Gh4oYMT4ownwPRFTrLvSeDSTFQ3JYmhsekI=; b=SeFGCEe4MPs/djGigwv8wwqTCV4my2LwqqFVpvG4B1oJEewJKC+4DhmY69zl3pbWe7R+q6pEEFyKunFBTMtWGWpcvzFc/NqZHiVcoDwnTXnK7/2K0/ECDWfRdP6G/D6gd8c1AyMGRwvGIoYLD0144AJCRBEScpNHVDEgZCDNtp0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1619006955691205.61954878092217; Wed, 21 Apr 2021 05:09:15 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-381-4k3rmrgFPbeQv2eMAj0E6Q-1; Wed, 21 Apr 2021 08:09:11 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6A33383DD46; Wed, 21 Apr 2021 12:09:03 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 478A060916; Wed, 21 Apr 2021 12:09:03 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 0D93955341; Wed, 21 Apr 2021 12:09:03 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 13LC8PB3008698 for ; Wed, 21 Apr 2021 08:08:25 -0400 Received: by smtp.corp.redhat.com (Postfix) id B180160916; Wed, 21 Apr 2021 12:08:25 +0000 (UTC) Received: from work.redhat.com (ovpn-112-172.ams2.redhat.com [10.36.112.172]) by smtp.corp.redhat.com (Postfix) with ESMTP id D23CC60871; Wed, 21 Apr 2021 12:08:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1619006954; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=jXnAyBr/Gh4oYMT4ownwPRFTrLvSeDSTFQ3JYmhsekI=; b=Vp+JKHbYcm8HkGpfCET8PG6RTY8SCYZSWGnb+8k1wo6xc272t/52RrYYTPQPbnIhPgsPgY 0C+2IOqi8d2f+0tDCx7EwWYgGYM+xv7hjpTfP9GW2YDhsPsSlE8u4SlF9eYh4k6Sx9sKI5 kXTcR1SFQepeiri/3diTx9kexE4cYUs= X-MC-Unique: 4k3rmrgFPbeQv2eMAj0E6Q-1 From: Tim Wiederhake To: libvir-list@redhat.com Subject: [libvirt PATCH v2 09/10] virDomainDeviceUSBAddressParseXML: Use virXMLProp* Date: Wed, 21 Apr 2021 14:08:07 +0200 Message-Id: <20210421120808.35786-10-twiederh@redhat.com> In-Reply-To: <20210421120808.35786-1-twiederh@redhat.com> References: <20210421120808.35786-1-twiederh@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com Cc: Peter Krempa , Tim Wiederhake X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Signed-off-by: Tim Wiederhake Reviewed-by: Peter Krempa --- src/conf/device_conf.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/src/conf/device_conf.c b/src/conf/device_conf.c index dbe30b05c1..9b0b81b2cb 100644 --- a/src/conf/device_conf.c +++ b/src/conf/device_conf.c @@ -401,19 +401,15 @@ virDomainDeviceUSBAddressParseXML(xmlNodePtr node, virDomainDeviceUSBAddress *addr) { g_autofree char *port =3D virXMLPropString(node, "port"); - g_autofree char *bus =3D virXMLPropString(node, "bus"); =20 memset(addr, 0, sizeof(*addr)); =20 if (port && virDomainDeviceUSBAddressParsePort(addr, port) < 0) return -1; =20 - if (bus && - virStrToLong_uip(bus, NULL, 10, &addr->bus) < 0) { - virReportError(VIR_ERR_INTERNAL_ERROR, "%s", - _("Cannot parse
'bus' attribute")); + if (virXMLPropUInt(node, "bus", 10, VIR_XML_PROP_NONE, &addr->bus) < 0) return -1; - } + return 0; } =20 --=20 2.26.3