From nobody Fri May 17 11:28:36 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1618938825; cv=none; d=zohomail.com; s=zohoarc; b=nx8231lSH7Ynuigmb6ex4XPeUa85MdxkoajJZCdDaCtyHTf/9FdT8iqvw+LMqc+97eP+ZdFfEYPOfnAIACfXqzk/EWlAQ1LKJ5p5avHPkfawNaQdBHva5otC3Fgrhbn79vfMhpN93bBR1PrR6DCj+a/6L4KIoRV5OgIUiB+D3jg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1618938825; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=snc1mJgJC7kAvbL1bZ54i/hQEs/XKYacMO1VQHIDtaw=; b=jq9Pycu1N0KFxDUBo0i0inwK5n4IMJmbxxvXZFpcdrfzowh8/dPEPVgvw9an1xHQ5ZmskARD3bPebgfvBKmK6z9jEr6EkuIzylnEDpRUqYeXmWGTLI+O1ECaoEinD9y5gm5FoaQQge7oQeoRphoPpdUKLc3xQ2bcGdP9PILjG7k= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1618938825183663.3450992635549; Tue, 20 Apr 2021 10:13:45 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-390-UApVb5_pN5aMSumIkjr02A-1; Tue, 20 Apr 2021 13:13:41 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8C6361B2C988; Tue, 20 Apr 2021 17:13:36 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 92FEB5D9DC; Tue, 20 Apr 2021 17:13:35 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 04BF41806D17; Tue, 20 Apr 2021 17:13:34 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 13KHDWal023390 for ; Tue, 20 Apr 2021 13:13:32 -0400 Received: by smtp.corp.redhat.com (Postfix) id 1D50E19C95; Tue, 20 Apr 2021 17:13:32 +0000 (UTC) Received: from harajuku.usersys.redhat.com (unknown [10.40.195.191]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2A64350F1A for ; Tue, 20 Apr 2021 17:13:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1618938824; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=snc1mJgJC7kAvbL1bZ54i/hQEs/XKYacMO1VQHIDtaw=; b=daKf9RxWfkYJLYtyGMqaAzS4BxhHkWXHcjR+AVg7ON42YfEcfX0HCbqmVRujejWQOkq0et TcT95TMhoHuZE7uNNfGPnjTUsxM9syLjhfq6KWTGJgm+7KFQiPpYyxpCf6iWk8+yogUsV2 HfENA9FoDQDg5KuVuXYTw3yMmYTwcDc= X-MC-Unique: UApVb5_pN5aMSumIkjr02A-1 From: Andrea Bolognani To: libvir-list@redhat.com Subject: [libvirt PATCH v4 1/7] docs: Use consistent vertical spacing Date: Tue, 20 Apr 2021 19:13:16 +0200 Message-Id: <20210420171322.544322-2-abologna@redhat.com> In-Reply-To: <20210420171322.544322-1-abologna@redhat.com> References: <20210420171322.544322-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Signed-off-by: Andrea Bolognani Reviewed-by: Michal Privoznik Reviewed-by: Neal Gompa --- docs/kbase/rpm-deployment.rst | 35 +---------------------------------- 1 file changed, 1 insertion(+), 34 deletions(-) diff --git a/docs/kbase/rpm-deployment.rst b/docs/kbase/rpm-deployment.rst index 568cf5b3eb..c580c52e79 100644 --- a/docs/kbase/rpm-deployment.rst +++ b/docs/kbase/rpm-deployment.rst @@ -34,14 +34,12 @@ RPM packages reconfigured on a running daemon without a restart. This is recommended to be installed on any host running a libvirt daemon. =20 - * libvirt-bash-completion =20 Argument auto-completion support for the Bash shell. This is shared code= that is pulled in by either the libvirt-admin or libvirt-clients RPMs, so the= re is no need to explicitly ask for this package to be installed. =20 - * libvirt-client =20 The virsh tool, used for interacting with any libvirt driver, both prima= ry @@ -49,14 +47,12 @@ RPM packages installs should have this installed as it provides a useful way to view = and debug what is being done by other applications using libvirt. =20 - * libvirt-daemon =20 The monolithic libvirtd daemon, traditionally used for running all the stateful drivers. This package does not contain any drivers, so further packages need to be installed to provide the desired drivers. =20 - * libvirt-daemon-config-network =20 The sample configuration file providing the 'default' virtual network th= at @@ -64,7 +60,6 @@ RPM packages on desktop installations, but is not typically desired on server installations where VMs will use full bridged connectivity. =20 - * libvirt-daemon-config-nwfilter =20 The sample configuration files providing the network filters for protect= ing @@ -72,14 +67,12 @@ RPM packages MAC and IP spoofing. This is typically desired on server installations, = if the mgmt app is using libvirt's network filtering features. =20 - * libvirt-daemon-driver-interface =20 The dynamically loadable driver providing an implementation of the host network interface management APIs, as well as the virtinterfaced daemon binary. =20 - * libvirt-daemon-driver-libxl =20 The dynamically loadable driver providing an implementation of the hyper= visor @@ -89,13 +82,11 @@ RPM packages Note that this is a minimal package so does not actually pull in the full Xen hypervisor package set. This be must requested separately. =20 - * libvirt-daemon-driver-lxc =20 The dynamically loadable driver providing an implementation of the hyper= visor APIs for Linux containers, as well as the virtlxcd daemon binary. =20 - * libvirt-daemon-driver-network =20 The dynamically loadable driver providing an implementation of the virtu= al @@ -103,20 +94,17 @@ RPM packages binary. Typically the libvirt-daemon-config-network RPM will also be des= ired when this is installed. =20 - * libvirt-daemon-driver-nodedev =20 The dynamically loadable driver providing an implementation of the host device management APIs, as well as the virtnodedevd daemon binary. =20 - * libvirt-daemon-driver-nwfilter =20 The dynamically loadable driver providing an implementation of the host network firewall management APIs, as well as the virtnwfilterd daemon binary. =20 - * libvirt-daemon-driver-qemu =20 The dynamically loadable driver providing an implementation of the hyper= visor @@ -126,12 +114,11 @@ RPM packages Note that this is a minimal package so does not actually pull in the full QEMU or KVM package set. This be must requested separately. =20 - * libvirt-daemon-driver-secret + The dynamically loadable driver providing an implementation of the secret data management APIs, as well as the virtsecretd daemon binary. =20 - * libvirt-daemon-driver-storage =20 This is an empty package that exists only as a convenient way to request @@ -141,7 +128,6 @@ RPM packages a smaller install footprint can be obtained by requesting the individual drivers. =20 - * libvirt-daemon-driver-storage-core =20 The dynamically loadable driver providing an implementation of the host @@ -151,74 +137,62 @@ RPM packages Note that this is a minimal package so does not actually pull in any pool implementations. =20 - * libvirt-daemon-driver-storage-disk =20 The dynamically loadable driver providing an implementation of the disk partition storage pool type, for the storage pool management APIs. =20 - * libvirt-daemon-driver-storage-gluster =20 The dynamically loadable driver providing an implementation of the Glust= erFS file storage pool type, for the storage pool management APIs. =20 - * libvirt-daemon-driver-storage-iscsi =20 The dynamically loadable driver providing an implementation of the ISCSI disk storage pool type, for the storage pool management APIs. =20 - * libvirt-daemon-driver-storage-iscsi-direct =20 The dynamically loadable driver providing an implementation of the ISCSI network storage pool type, for the storage pool management APIs. =20 - * libvirt-daemon-driver-storage-logical =20 The dynamically loadable driver providing an implementation of the LVM storage pool type, for the storage pool management APIs. =20 - * libvirt-daemon-driver-storage-mpath =20 The dynamically loadable driver providing an implementation of the multi= path disk storage pool type, for the storage pool management APIs. =20 - * libvirt-daemon-driver-storage-rbd =20 The dynamically loadable driver providing an implementation of the RBD network storage pool type, for the storage pool management APIs. =20 - * libvirt-daemon-driver-storage-scsi =20 The dynamically loadable driver providing an implementation of the SCSI disk storage pool type, for the storage pool management APIs. =20 - * libvirt-daemon-driver-storage-sheepdog =20 The dynamically loadable driver providing an implementation of the Sheep= Dog network storage pool type, for the storage pool management APIs. =20 - * libvirt-daemon-driver-storage-zfs =20 The dynamically loadable driver providing an implementation of the ZFS file storage pool type, for the storage pool management APIs. =20 - * libvirt-daemon-driver-vbox =20 The dynamically loadable driver providing an implementation of the host network interface management APIs, as well as the virtinterfaced daemon binary. =20 - * libvirt-daemon-kvm =20 This is an empty package that exists only as a convenient way to request @@ -235,7 +209,6 @@ RPM packages features, the subset of libvirt-daemon-driver-XXX packages should be used instead. =20 - * libvirt-daemon-lxc =20 This is an empty package that exists only as a convenient way to request @@ -249,7 +222,6 @@ RPM packages features, the subset of libvirt-daemon-driver-XXX packages should be used instead. =20 - * libvirt-daemon-qemu =20 This is an empty package that exists only as a convenient way to request @@ -266,7 +238,6 @@ RPM packages features, the subset of libvirt-daemon-driver-XXX packages should be used instead. =20 - * libvirt-daemon-vbox =20 This is an empty package that exists only as a convenient way to request @@ -280,7 +251,6 @@ RPM packages features, the subset of libvirt-daemon-driver-XXX packages should be used instead. =20 - * libvirt-daemon-xen =20 This is an empty package that exists only as a convenient way to request @@ -297,7 +267,6 @@ RPM packages features, the subset of libvirt-daemon-driver-XXX packages should be used instead. =20 - * libvirt-devel =20 The header files required to build applications, or language bindings ag= ainst @@ -327,14 +296,12 @@ RPM packages A simple login shell that automatically spawns an LXC container for the = user logging in and places them in a shell inside that container. =20 - * libvirt-nss =20 A NSS plugin that provides hostname resolution for guests attached to a libvirt virtual network. It is recommended to be installed on any host w= ith guests using the libvirt virtual network connectivity. =20 - * libvirt-wireshark =20 A wireshark plugin that allows for dissecting the XDR based RPC protocol= used --=20 2.26.3 From nobody Fri May 17 11:28:36 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1618938838; cv=none; d=zohomail.com; s=zohoarc; b=L8CaweTsfKfpRztK+9SRTdB3BeAybkMzO9Q88CgtTkJUhksTnxMSvDLPKw8Piv8eFwi/TVtvCNdzo1FvZ/eAOkaY4JJ3c0YrJZvQ48v7nco8sl7VUzt/1Jeb18EbEDwfwZvUKYi2jSjmwec781P79CTm1XUIddJ4qJKAPvOaIc8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1618938838; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=8nZbtBV2JMHJGIw0BuieuveUZNhx5c8oVOhMvrUstao=; b=RFxIxJa60Lh8UnPI8AuCT6uJPCbCVmvzh5GNJQq8odks5tzgVFUzjSrEnQH0yAm668zYVfwm5X2Keb0ozJmGrYU1k6TQn/2mSCB6tYk5tO/prVPty+iAUhhQtZije3h1myrGHbMQEMZTEd7G3EQjq8WA347/urpehIAmxzP3v98= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1618938838012715.0381412110285; Tue, 20 Apr 2021 10:13:58 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-245-uaov8yH4P_KUf57_vE7XrQ-1; Tue, 20 Apr 2021 13:13:54 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 23CC88542C3; Tue, 20 Apr 2021 17:13:48 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 05B1461F49; Tue, 20 Apr 2021 17:13:48 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id C3D451806D1A; Tue, 20 Apr 2021 17:13:47 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 13KHDX6j023397 for ; Tue, 20 Apr 2021 13:13:33 -0400 Received: by smtp.corp.redhat.com (Postfix) id 9DE5750FAF; Tue, 20 Apr 2021 17:13:33 +0000 (UTC) Received: from harajuku.usersys.redhat.com (unknown [10.40.195.191]) by smtp.corp.redhat.com (Postfix) with ESMTPS id AEAA050F89 for ; Tue, 20 Apr 2021 17:13:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1618938836; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=8nZbtBV2JMHJGIw0BuieuveUZNhx5c8oVOhMvrUstao=; b=b1l9Zcqk9QAoCFDuAY4n3Q+BO7YDrH6gWK6mrxd5LsBahyZ3OayJXZm7xu6V0UyarGahwd cSmLO+T+nNjkRPoR1z72qJOJDEbowXGq1WW0aQO1+LMcdthANNF2dkg7eHxJtWjJRbQiXE tZnHgCfWUYjk126rebhYrWHpD8GtjxM= X-MC-Unique: uaov8yH4P_KUf57_vE7XrQ-1 From: Andrea Bolognani To: libvir-list@redhat.com Subject: [libvirt PATCH v4 2/7] docs: Expand upon the contents of the -daemon package Date: Tue, 20 Apr 2021 19:13:17 +0200 Message-Id: <20210420171322.544322-3-abologna@redhat.com> In-Reply-To: <20210420171322.544322-1-abologna@redhat.com> References: <20210420171322.544322-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" It doesn't only contain the libvirtd binary. Signed-off-by: Andrea Bolognani Reviewed-by: Michal Privoznik Reviewed-by: Neal Gompa --- docs/kbase/rpm-deployment.rst | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/docs/kbase/rpm-deployment.rst b/docs/kbase/rpm-deployment.rst index c580c52e79..2563142a50 100644 --- a/docs/kbase/rpm-deployment.rst +++ b/docs/kbase/rpm-deployment.rst @@ -53,6 +53,10 @@ RPM packages stateful drivers. This package does not contain any drivers, so further packages need to be installed to provide the desired drivers. =20 + In addition to the libvirtd daemon this package also contains the virtlo= gd, + virtlockd and virtproxyd daemons, plus a number of helpers, configuration + files and other bits necessary to create and admin a virtualization host. + * libvirt-daemon-config-network =20 The sample configuration file providing the 'default' virtual network th= at --=20 2.26.3 From nobody Fri May 17 11:28:36 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1618938847; cv=none; d=zohomail.com; s=zohoarc; b=IepF0xZ6dhZ+/xnfXkfT5SCoYAG+frg7H/P7Y9Bd/fwbPTA6MUGN3v6MqMXhR1Nzd8jl8KWBtyqDqI42hcbYKJn/mueymfkYViSr3YwQp8UNCr36elkgBwZVN+DpID5bo6Nk6YQKD7Of19TNv10u+C3U7QqiroPrLTQ+TUqaWF8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1618938847; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=1X8M0b1vmCua/fjePH4xubJK4V0CEwdb5Yj58TtLolQ=; b=C+CS9/tdI+37bKu2OwrSQGNy9O+eVFssUEfMaoG528bhgRJA0GGqGLxozrTrAxtEczs19fziOT7D9i0V820X3F27RYcO0pmvUrRa2k09HitvOF72oh+9cCgCQEgj0YiQPUwIIwYdG/4Ne9wKso6Jfn4lmNlJNYX5txJ+evJFkXw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 161893884742385.64646278879127; Tue, 20 Apr 2021 10:14:07 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-587-YzMwSej1OCKf6Pm3Yw3rbw-1; Tue, 20 Apr 2021 13:13:58 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 08CC28189D3; Tue, 20 Apr 2021 17:13:51 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D4CFD19D80; Tue, 20 Apr 2021 17:13:50 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 9E3C41806D1B; Tue, 20 Apr 2021 17:13:50 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 13KHDZla023406 for ; Tue, 20 Apr 2021 13:13:35 -0400 Received: by smtp.corp.redhat.com (Postfix) id 2B4B450FAF; Tue, 20 Apr 2021 17:13:35 +0000 (UTC) Received: from harajuku.usersys.redhat.com (unknown [10.40.195.191]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 470A850F89 for ; Tue, 20 Apr 2021 17:13:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1618938846; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=1X8M0b1vmCua/fjePH4xubJK4V0CEwdb5Yj58TtLolQ=; b=M0SeUd3/PRFFMYRFrYLZf5cymHLfHnVWlUwHtIiRW5kMtzQnnwHYfo7CVR0Rgior7r2PW2 CUn3e2JdwxLIbsVqvKGXSitPJ6QEIcHRuHzKeRWr/Yny1oQshDUdz7WBbF6U8cESxTw2Y0 duZ6/lweQXo2NKX1sF+CYtbbuc6Jyqw= X-MC-Unique: YzMwSej1OCKf6Pm3Yw3rbw-1 From: Andrea Bolognani To: libvir-list@redhat.com Subject: [libvirt PATCH v4 3/7] spec: Merge -admin package into -daemon Date: Tue, 20 Apr 2021 19:13:18 +0200 Message-Id: <20210420171322.544322-4-abologna@redhat.com> In-Reply-To: <20210420171322.544322-1-abologna@redhat.com> References: <20210420171322.544322-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" It's useful to have virt-admin around when debugging issues with libvirtd, and since it's a tiny binary we can simply include it in the -daemon package to ensure it's always going to be available when needed. Signed-off-by: Andrea Bolognani Reviewed-by: Michal Privoznik Reviewed-by: Neal Gompa --- docs/kbase/rpm-deployment.rst | 12 +++++------- libvirt.spec.in | 24 +++++++++++------------- 2 files changed, 16 insertions(+), 20 deletions(-) diff --git a/docs/kbase/rpm-deployment.rst b/docs/kbase/rpm-deployment.rst index 2563142a50..cc2a4eb288 100644 --- a/docs/kbase/rpm-deployment.rst +++ b/docs/kbase/rpm-deployment.rst @@ -27,13 +27,6 @@ RPM packages every other libvirt RPM package. Almost every deployment scenario would = be better served by picking one of the other RPMs listed below. =20 -* libvirt-admin - - The virt-admin tool, used for administrative operations on any libvirt - daemons. Most usefully it allows for logging filters and outputs to be - reconfigured on a running daemon without a restart. This is recommended - to be installed on any host running a libvirt daemon. - * libvirt-bash-completion =20 Argument auto-completion support for the Bash shell. This is shared code= that @@ -57,6 +50,11 @@ RPM packages virtlockd and virtproxyd daemons, plus a number of helpers, configuration files and other bits necessary to create and admin a virtualization host. =20 + The virt-admin tool, also included in this package, is used for + administrative operations on any libvirt daemons. Most usefully it allows + for logging filters and outputs to be reconfigured on a running daemon + without a restart. + * libvirt-daemon-config-network =20 The sample configuration file providing the 'default' virtual network th= at diff --git a/libvirt.spec.in b/libvirt.spec.in index f9af330186..db88b1bf3d 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -430,6 +430,9 @@ Summary: Server side daemon and supporting files for li= bvirt library # The client side, i.e. shared libs are in a subpackage Requires: %{name}-libs =3D %{version}-%{release} =20 +# bash completion support for virt-admin +Requires: %{name}-bash-completion =3D %{version}-%{release} + # (client invokes 'nc' against the UNIX socket on the server) Requires: /usr/bin/nc =20 @@ -461,6 +464,10 @@ Requires: dbus # For uid creation during pre Requires(pre): shadow-utils =20 +# Ensure smooth upgrades +Obsoletes: libvirt-admin < 7.3.0 +Provides: libvirt-admin + %description daemon Server side daemon required to manage the virtualization capabilities of recent versions of Linux. Requires a hypervisor specific sub-RPM @@ -918,14 +925,6 @@ Requires: cyrus-sasl-gssapi %description libs Shared libraries for accessing the libvirt daemon. =20 -%package admin -Summary: Set of tools to control libvirt daemon -Requires: %{name}-libs =3D %{version}-%{release} -Requires: %{name}-bash-completion =3D %{version}-%{release} - -%description admin -The client side utilities to control the libvirt daemon. - %package bash-completion Summary: Bash completion script =20 @@ -1589,12 +1588,16 @@ exit 0 %attr(0755, root, root) %{_sbindir}/virtlogd %attr(0755, root, root) %{_sbindir}/virtlockd =20 +%{_mandir}/man1/virt-admin.1* %{_mandir}/man8/libvirtd.8* %{_mandir}/man8/virtlogd.8* %{_mandir}/man8/virtlockd.8* %{_mandir}/man8/virtproxyd.8* %{_mandir}/man7/virkey*.7* =20 +%{_bindir}/virt-admin +%{_datadir}/bash-completion/completions/virt-admin + %files daemon-config-network %dir %{_datadir}/libvirt/networks/ %{_datadir}/libvirt/networks/default.xml @@ -1911,11 +1914,6 @@ exit 0 =20 %{_datadir}/libvirt/test-screenshot.png =20 -%files admin -%{_mandir}/man1/virt-admin.1* -%{_bindir}/virt-admin -%{_datadir}/bash-completion/completions/virt-admin - %files bash-completion %{_datadir}/bash-completion/completions/vsh =20 --=20 2.26.3 From nobody Fri May 17 11:28:36 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1618938907; cv=none; d=zohomail.com; s=zohoarc; b=MdPcAbWUM3aGRtmPQQx9DFMqHYi4d7uLS8izig1iNhL3LFo3viJ/EZ9sp+savhquoHTlfxjtHnLeD8P2UD2PJlXuyoaYTnjnWda1p33D2+UzzYah1pXEENv1K2zqhFawsx+tmNEuBENIUu5yFJ1UzimULti1Q+U1AuUU6aXSxSs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1618938907; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=dBlqrLc3aqd3sMYnzRYHh/NphWk1dCvsyKcwpBRc2AM=; b=bbhPIthWcWYw1dUhfpJE4+d+zHEuhyDUeFgwNzPNJxVySqofhJCITqPK7KpEfnwknMz9tef+CpVRXBzJcMIyMDdolusKDKyeX381FNtmOaQ4jl82pQdWWDMRBYdhdKO6DhDPpK82cvMp9DhacXEURlYC8avCWRFprjka/2eR5UI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1618938907660593.9338774890384; Tue, 20 Apr 2021 10:15:07 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-317-TBKVq7K_PI-HQ8LHPc4aQQ-1; Tue, 20 Apr 2021 13:14:07 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A3646CC640; Tue, 20 Apr 2021 17:13:53 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7C3305D9CD; Tue, 20 Apr 2021 17:13:53 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 487771806D1E; Tue, 20 Apr 2021 17:13:53 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 13KHDao4023416 for ; Tue, 20 Apr 2021 13:13:36 -0400 Received: by smtp.corp.redhat.com (Postfix) id 95ACD50F89; Tue, 20 Apr 2021 17:13:36 +0000 (UTC) Received: from harajuku.usersys.redhat.com (unknown [10.40.195.191]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BF42B510ED for ; Tue, 20 Apr 2021 17:13:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1618938905; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=dBlqrLc3aqd3sMYnzRYHh/NphWk1dCvsyKcwpBRc2AM=; b=P6hOg4Jv59rhAq14HX3+xyJTADRYfFAxSRy49SMc1sLgh8BH2DEU/v2QTQPtCPnGDFBHpB XpCwDwP978sk1ZEc9ubzczcQGuMrd2iOVPqCwOIzeUe4DVZN4TMEv5I3kqf9SIgIcwoOYV EfxmY36u0+3frna0JDswrAVSRhVGpOg= X-MC-Unique: TBKVq7K_PI-HQ8LHPc4aQQ-1 From: Andrea Bolognani To: libvir-list@redhat.com Subject: [libvirt PATCH v4 4/7] spec: Move some files from -client to -daemon Date: Tue, 20 Apr 2021 19:13:19 +0200 Message-Id: <20210420171322.544322-5-abologna@redhat.com> In-Reply-To: <20210420171322.544322-1-abologna@redhat.com> References: <20210420171322.544322-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" The -client package's purpose is enabling remote machines to connect to a virtualization host, but the virt-host-validate and libvirt-guests tools are designed to be run directly on the virtualization host and as such are a better fit for the -daemon package. With this change, installing and removing the -client package no longer needs to touch the systemd configuration. Signed-off-by: Andrea Bolognani Reviewed-by: Michal Privoznik Reviewed-by: Neal Gompa --- libvirt.spec.in | 29 ++++++++++------------------- 1 file changed, 10 insertions(+), 19 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index db88b1bf3d..35e7219006 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -463,6 +463,8 @@ Requires: numad Requires: dbus # For uid creation during pre Requires(pre): shadow-utils +# Needed by /usr/libexec/libvirt-guests.sh script. +Requires: gettext =20 # Ensure smooth upgrades Obsoletes: libvirt-admin < 7.3.0 @@ -904,8 +906,6 @@ capabilities of VirtualBox %package client Summary: Client side utilities of the libvirt library Requires: %{name}-libs =3D %{version}-%{release} -# Needed by /usr/libexec/libvirt-guests.sh script. -Requires: gettext # Needed by virt-pki-validate script. Requires: gnutls-utils Requires: %{name}-bash-completion =3D %{version}-%{release} @@ -1326,6 +1326,7 @@ exit 0 %systemd_post libvirtd.socket libvirtd-ro.socket libvirtd-admin.socket %systemd_post libvirtd-tcp.socket libvirtd-tls.socket %systemd_post libvirtd.service +%systemd_post libvirt-guests.service =20 # request daemon restart in posttrans mkdir -p %{_localstatedir}/lib/rpm-state/libvirt || : @@ -1337,6 +1338,7 @@ touch %{_localstatedir}/lib/rpm-state/libvirt/restart= || : %systemd_preun libvirtd.socket libvirtd-ro.socket libvirtd-admin.socket %systemd_preun virtlogd.socket virtlogd-admin.socket virtlogd.service %systemd_preun virtlockd.socket virtlockd-admin.socket virtlockd.service +%systemd_preun libvirt-guests.service =20 %postun daemon /bin/systemctl daemon-reload >/dev/null 2>&1 || : @@ -1344,6 +1346,7 @@ if [ $1 -ge 1 ] ; then /bin/systemctl reload-or-try-restart virtlockd.service >/dev/null 2>&1= || : /bin/systemctl reload-or-try-restart virtlogd.service >/dev/null 2>&1 = || : fi +%systemd_postun libvirt-guests.service =20 # In upgrade scenario we must explicitly enable virtlockd/virtlogd # sockets, if libvirtd is already enabled and start them if @@ -1488,16 +1491,6 @@ fi exit 0 %endif =20 -%preun client - -%systemd_preun libvirt-guests.service - -%post client -%systemd_post libvirt-guests.service - -%postun client -%systemd_postun libvirt-guests.service - %if %{with_lxc} %pre login-shell getent group virtlogin >/dev/null || groupadd -r virtlogin @@ -1533,6 +1526,7 @@ exit 0 %{_unitdir}/virtlockd.service %{_unitdir}/virtlockd.socket %{_unitdir}/virtlockd-admin.socket +%{_unitdir}/libvirt-guests.service %config(noreplace) %{_sysconfdir}/sysconfig/libvirtd %config(noreplace) %{_sysconfdir}/sysconfig/virtproxyd %config(noreplace) %{_sysconfdir}/sysconfig/virtlogd @@ -1542,6 +1536,7 @@ exit 0 %config(noreplace) %{_sysconfdir}/libvirt/virtlogd.conf %config(noreplace) %{_sysconfdir}/libvirt/virtlockd.conf %config(noreplace) %{_sysconfdir}/sasl2/libvirt.conf +%config(noreplace) %{_sysconfdir}/sysconfig/libvirt-guests %config(noreplace) %{_prefix}/lib/sysctl.d/60-libvirtd.conf =20 %config(noreplace) %{_sysconfdir}/logrotate.d/libvirtd @@ -1587,14 +1582,17 @@ exit 0 %attr(0755, root, root) %{_sbindir}/virtproxyd %attr(0755, root, root) %{_sbindir}/virtlogd %attr(0755, root, root) %{_sbindir}/virtlockd +%attr(0755, root, root) %{_libexecdir}/libvirt-guests.sh =20 %{_mandir}/man1/virt-admin.1* +%{_mandir}/man1/virt-host-validate.1* %{_mandir}/man8/libvirtd.8* %{_mandir}/man8/virtlogd.8* %{_mandir}/man8/virtlockd.8* %{_mandir}/man8/virtproxyd.8* %{_mandir}/man7/virkey*.7* =20 +%{_bindir}/virt-host-validate %{_bindir}/virt-admin %{_datadir}/bash-completion/completions/virt-admin =20 @@ -1877,11 +1875,9 @@ exit 0 %{_mandir}/man1/virsh.1* %{_mandir}/man1/virt-xml-validate.1* %{_mandir}/man1/virt-pki-validate.1* -%{_mandir}/man1/virt-host-validate.1* %{_bindir}/virsh %{_bindir}/virt-xml-validate %{_bindir}/virt-pki-validate -%{_bindir}/virt-host-validate =20 %{_datadir}/systemtap/tapset/libvirt_probes*.stp %{_datadir}/systemtap/tapset/libvirt_functions.stp @@ -1891,11 +1887,6 @@ exit 0 =20 %{_datadir}/bash-completion/completions/virsh =20 - -%{_unitdir}/libvirt-guests.service -%config(noreplace) %{_sysconfdir}/sysconfig/libvirt-guests -%attr(0755, root, root) %{_libexecdir}/libvirt-guests.sh - %files libs -f %{name}.lang %license COPYING COPYING.LESSER %config(noreplace) %{_sysconfdir}/libvirt/libvirt.conf --=20 2.26.3 From nobody Fri May 17 11:28:36 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1618938842; cv=none; d=zohomail.com; s=zohoarc; b=kLqrGgmyQL6HvJoPrxA6RwA19X7/5BNMHsYa67JvCTM04sgespN9gboezFwCvTcBUz8sYn/wf0zafsVNeM9GuGGRMmaSBKiZApiXFO19F2wpFLEEmbeiZ8i4NBfmqCeqzNFmMmhdwBMva/PTqwN0UMWHTAWvbRfqeS0cR3I9f08= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1618938842; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=yeNS2JQocQyN99If+yMxMjhwaUln1hJwCy/IDwHurK4=; b=nH22fGKrYBNCm/wKN7AiBg+Wv8lOEddih1AFm3qgUcbOwOAmKSFiDmLu+08RHkQh109Yv3C4s4Qqzj/qCRjRTqITo+A5oRla0dftWpuQ/M5mwSbp9tv0GYYd2n0SKA1YewHYFjBZ9gOF9QhIev4fEvdrN9Htp7qGNezLH5z3f3Q= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 161893884265879.42381557666965; Tue, 20 Apr 2021 10:14:02 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-604-ZwkDeY_rPKaw6-voTlEOvQ-1; Tue, 20 Apr 2021 13:13:58 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3D0F1CC633; Tue, 20 Apr 2021 17:13:48 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 20D9159474; Tue, 20 Apr 2021 17:13:48 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id C1FE944A5E; Tue, 20 Apr 2021 17:13:47 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 13KHDcj6023437 for ; Tue, 20 Apr 2021 13:13:38 -0400 Received: by smtp.corp.redhat.com (Postfix) id 2981A50FAF; Tue, 20 Apr 2021 17:13:38 +0000 (UTC) Received: from harajuku.usersys.redhat.com (unknown [10.40.195.191]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 32F1B50F89 for ; Tue, 20 Apr 2021 17:13:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1618938841; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=yeNS2JQocQyN99If+yMxMjhwaUln1hJwCy/IDwHurK4=; b=aKrVz9x5CMq1mS9HsAiXZraIRJOCJ6i2TQaqKkFFVhZ2ZiuvAT5m8hp/S3D0sHp6X7E/Zo v6uN94J//Lqj5JFlDzfjMkfwLD9ONbTqlU+m2R7Z6lkkst/vDi0AL0w1bL31xcgXRHxLBU 1yXJ1K69BSLjF/D6ekjS6/4/biRs9rs= X-MC-Unique: ZwkDeY_rPKaw6-voTlEOvQ-1 From: Andrea Bolognani To: libvir-list@redhat.com Subject: [libvirt PATCH v4 5/7] spec: Move systemtap probes from -client to -libs Date: Tue, 20 Apr 2021 19:13:20 +0200 Message-Id: <20210420171322.544322-6-abologna@redhat.com> In-Reply-To: <20210420171322.544322-1-abologna@redhat.com> References: <20210420171322.544322-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Any application that uses the libraries can take advantage of the systemtap probes, so they should be shipped in the -libs package rather than in -client. Signed-off-by: Andrea Bolognani Reviewed-by: Michal Privoznik Reviewed-by: Neal Gompa --- libvirt.spec.in | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index 35e7219006..6d2206633f 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -1879,12 +1879,6 @@ exit 0 %{_bindir}/virt-xml-validate %{_bindir}/virt-pki-validate =20 -%{_datadir}/systemtap/tapset/libvirt_probes*.stp -%{_datadir}/systemtap/tapset/libvirt_functions.stp -%if %{with_qemu} -%{_datadir}/systemtap/tapset/libvirt_qemu_probes*.stp -%endif - %{_datadir}/bash-completion/completions/virsh =20 %files libs -f %{name}.lang @@ -1899,6 +1893,12 @@ exit 0 %dir %{_datadir}/libvirt/schemas/ %dir %attr(0755, root, root) %{_localstatedir}/lib/libvirt/ =20 +%{_datadir}/systemtap/tapset/libvirt_probes*.stp +%{_datadir}/systemtap/tapset/libvirt_functions.stp +%if %{with_qemu} +%{_datadir}/systemtap/tapset/libvirt_qemu_probes*.stp +%endif + %{_datadir}/libvirt/schemas/*.rng =20 %{_datadir}/libvirt/cpu_map/*.xml --=20 2.26.3 From nobody Fri May 17 11:28:36 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1618938859; cv=none; d=zohomail.com; s=zohoarc; b=fITeUkIySfVs1N+qd0siMSiZ/02DwJqr8wK89RcGz4N1ufDgzXsvVXoEO6NXsi+FXrvXYO1XNxeR1Zv7wTptz3T05hrGNpDYVklZzyhZ0z1umEFp16HOQ0IeBd+dx3WSqstxCqxEZd8gwSNA0pQx6GZT3I+sVLzSRYsKYlFtHQY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1618938859; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=1mamxb8tXOkBc+PVCZsRJ1Mn6ICm5DsfheYmzMqQgRs=; b=PUYZPnkQtnRhvzrk+NO0fGb4BbqIhsOGl9BweK+eUoodN2i72PFfdfDqvm3+99VfxMg/osOzmDN1/K0LQU7bZjZftr6NbjS1Gpru1QkPYuXBDG4hiUA/6N3Dg8jNqg3gP9oNEgLn0GW7XQrAMhnDM3frzH9clD+ZlMTNKjHLLqU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 16189388591911007.9236429487485; Tue, 20 Apr 2021 10:14:19 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-443-IwwDwr0PMJGGqOd690sfWw-1; Tue, 20 Apr 2021 13:14:05 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 18359CC658; Tue, 20 Apr 2021 17:13:51 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EBFDB5C1A1; Tue, 20 Apr 2021 17:13:50 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id B64D744A62; Tue, 20 Apr 2021 17:13:50 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 13KHDdWJ023455 for ; Tue, 20 Apr 2021 13:13:39 -0400 Received: by smtp.corp.redhat.com (Postfix) id 8DDAD50FAF; Tue, 20 Apr 2021 17:13:39 +0000 (UTC) Received: from harajuku.usersys.redhat.com (unknown [10.40.195.191]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A606D50F89 for ; Tue, 20 Apr 2021 17:13:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1618938858; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=1mamxb8tXOkBc+PVCZsRJ1Mn6ICm5DsfheYmzMqQgRs=; b=jTK/oYZzQM/np5TIA/0I8WQGLp3hMzC/8AtfrsyD/9k50CFgr4U3BbrwvEyECZ/ABhqWpe //515x85wba7bTa0h3vYVNI1P1Ud2nNHdbEADj+ZHnOvSKpWfOpsbTskah8kHk/NtA+ai8 x030kaoJ6kpGDFxHy+DQ7lGUN4ieKag= X-MC-Unique: IwwDwr0PMJGGqOd690sfWw-1 From: Andrea Bolognani To: libvir-list@redhat.com Subject: [libvirt PATCH v4 6/7] tools: Generate per-command bash completion script Date: Tue, 20 Apr 2021 19:13:21 +0200 Message-Id: <20210420171322.544322-7-abologna@redhat.com> In-Reply-To: <20210420171322.544322-1-abologna@redhat.com> References: <20210420171322.544322-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" The current setup uses a single script that is symlinked twice and that tries to configure bash completion for both virsh and virt-admin, even if only one of them is installed. This also forces us to have a -bash-completion RPM package that only contains the tiny shared file. Rework bash completion support so that two scripts are generated, each one tailored to a specific command. Since the shared script no longer exists after this change, the corresponding RPM package becomes empty. Signed-off-by: Andrea Bolognani Reviewed-by: Michal Privoznik Reviewed-by: Neal Gompa --- libvirt.spec.in | 3 --- tools/bash-completion/meson.build | 24 ++++++++++++++---------- tools/bash-completion/{vsh =3D> vsh.in} | 7 +++---- 3 files changed, 17 insertions(+), 17 deletions(-) rename tools/bash-completion/{vsh =3D> vsh.in} (91%) diff --git a/libvirt.spec.in b/libvirt.spec.in index 6d2206633f..76af267681 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -1905,9 +1905,6 @@ exit 0 =20 %{_datadir}/libvirt/test-screenshot.png =20 -%files bash-completion -%{_datadir}/bash-completion/completions/vsh - %if %{with_wireshark} %files wireshark %{wireshark_plugindir}/libvirt.so diff --git a/tools/bash-completion/meson.build b/tools/bash-completion/meso= n.build index 8924c93adf..deda7c4f46 100644 --- a/tools/bash-completion/meson.build +++ b/tools/bash-completion/meson.build @@ -1,11 +1,15 @@ -install_data('vsh', install_dir: bash_completion_dir) +completion_commands =3D [ + 'virsh', + 'virt-admin', +] =20 -meson.add_install_script( - meson_python_prog.path(), python3_prog.path(), meson_install_symlink_pro= g.path(), - bash_completion_dir, 'vsh', 'virsh', -) - -meson.add_install_script( - meson_python_prog.path(), python3_prog.path(), meson_install_symlink_pro= g.path(), - bash_completion_dir, 'vsh', 'virt-admin', -) +foreach command : completion_commands + completion_conf =3D configuration_data() + completion_conf.set('command', command) + completion =3D configure_file( + input: 'vsh.in', + output: command, + configuration: completion_conf, + ) + install_data(completion, install_dir: bash_completion_dir) +endforeach diff --git a/tools/bash-completion/vsh b/tools/bash-completion/vsh.in similarity index 91% rename from tools/bash-completion/vsh rename to tools/bash-completion/vsh.in index bbb25fc3eb..8dde38474f 100644 --- a/tools/bash-completion/vsh +++ b/tools/bash-completion/vsh.in @@ -1,8 +1,8 @@ # -# virsh & virt-admin completion command +# @command@ completion support # =20 -_vsh_complete() +_@command@_complete() { local words cword c=3D0 i=3D0 cur RO URI CMDLINE INPUT A =20 @@ -62,7 +62,6 @@ _vsh_complete() __ltrim_colon_completions "$cur" return 0 } && -complete -o default -o filenames -F _vsh_complete virsh && -complete -o default -o filenames -F _vsh_complete virt-admin +complete -o default -o filenames -F _@command@_complete @command@ =20 # vim: ft=3Dsh:et:ts=3D4:sw=3D4:tw=3D80 --=20 2.26.3 From nobody Fri May 17 11:28:36 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1618938848; cv=none; d=zohomail.com; s=zohoarc; b=NLVXJYWuPnNTO7QS2QPoWzh9/n6nfrYpNZUG0jjltmHGwHLuQVUMEfQpdk7F+ZoU51cF/OCbHCKj5cxLL7xf9eJvBRxWL/O0++kF2g4+/p40TPq/rQAQgTt3SJRfXuqHqDz3jMprvuuuu4lKH/3C87zFFcE9ExVpk7pTAfIcM8U= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1618938848; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=xkv6DYT/uaZjiB+r/2Q9y65VoCafdpRzLAQqIS0I0Kg=; b=RqjyWNaRpJtME+R/98FQKB3IYufydVOYXF0pkz0DXfpl1wlSA2hS4zAv8Aeu5oNGAb5Vhl/HSmLvwDIZSKfusnB82r37p9jpr0b20S7HjfmvxVkD3uH3+nkBcHPastECIz5cj1Bcmdohs8pGogoCiA9KxRQlig4dX00KKCqxoJQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1618938848187165.8035647386306; Tue, 20 Apr 2021 10:14:08 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-433-4cv7cwSiPTexR7kNUqeGuw-1; Tue, 20 Apr 2021 13:13:59 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 89968CC623; Tue, 20 Apr 2021 17:13:45 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 63C105D9CD; Tue, 20 Apr 2021 17:13:45 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 29A4044A57; Tue, 20 Apr 2021 17:13:45 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 13KHDhX1023491 for ; Tue, 20 Apr 2021 13:13:43 -0400 Received: by smtp.corp.redhat.com (Postfix) id A8E225945A; Tue, 20 Apr 2021 17:13:43 +0000 (UTC) Received: from harajuku.usersys.redhat.com (unknown [10.40.195.191]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 398A150F89 for ; Tue, 20 Apr 2021 17:13:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1618938847; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=xkv6DYT/uaZjiB+r/2Q9y65VoCafdpRzLAQqIS0I0Kg=; b=h3cFmQkjhbH3cKzkDU8mNm7BHEcV7UM0bDas9KTSXR63Gy2sTSofOxlMMcFgfyPc32BrBe 6u8siQOrV+xy0mrYEojb7DCeDtIhTt7PZxMGQZWPL+61wBb2cuy2UqHhu6v5ORjtQ4tHXX qifRBdFKPSYYPxBh1A06GoD/pey2h+4= X-MC-Unique: 4cv7cwSiPTexR7kNUqeGuw-1 From: Andrea Bolognani To: libvir-list@redhat.com Subject: [libvirt PATCH v4 7/7] spec: Drop -bash-completion package Date: Tue, 20 Apr 2021 19:13:22 +0200 Message-Id: <20210420171322.544322-8-abologna@redhat.com> In-Reply-To: <20210420171322.544322-1-abologna@redhat.com> References: <20210420171322.544322-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" It's now empty, so no point in keeping it around. Signed-off-by: Andrea Bolognani Reviewed-by: Michal Privoznik Reviewed-by: Neal Gompa --- docs/kbase/rpm-deployment.rst | 6 ------ libvirt.spec.in | 14 ++++---------- 2 files changed, 4 insertions(+), 16 deletions(-) diff --git a/docs/kbase/rpm-deployment.rst b/docs/kbase/rpm-deployment.rst index cc2a4eb288..7b3bbfefe8 100644 --- a/docs/kbase/rpm-deployment.rst +++ b/docs/kbase/rpm-deployment.rst @@ -27,12 +27,6 @@ RPM packages every other libvirt RPM package. Almost every deployment scenario would = be better served by picking one of the other RPMs listed below. =20 -* libvirt-bash-completion - - Argument auto-completion support for the Bash shell. This is shared code= that - is pulled in by either the libvirt-admin or libvirt-clients RPMs, so the= re is - no need to explicitly ask for this package to be installed. - * libvirt-client =20 The virsh tool, used for interacting with any libvirt driver, both prima= ry diff --git a/libvirt.spec.in b/libvirt.spec.in index 76af267681..b7359b3763 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -430,9 +430,6 @@ Summary: Server side daemon and supporting files for li= bvirt library # The client side, i.e. shared libs are in a subpackage Requires: %{name}-libs =3D %{version}-%{release} =20 -# bash completion support for virt-admin -Requires: %{name}-bash-completion =3D %{version}-%{release} - # (client invokes 'nc' against the UNIX socket on the server) Requires: /usr/bin/nc =20 @@ -469,6 +466,7 @@ Requires: gettext # Ensure smooth upgrades Obsoletes: libvirt-admin < 7.3.0 Provides: libvirt-admin +Obsoletes: libvirt-bash-completion < 7.3.0 =20 %description daemon Server side daemon required to manage the virtualization capabilities @@ -908,7 +906,9 @@ Summary: Client side utilities of the libvirt library Requires: %{name}-libs =3D %{version}-%{release} # Needed by virt-pki-validate script. Requires: gnutls-utils -Requires: %{name}-bash-completion =3D %{version}-%{release} + +# Ensure smooth upgrades +Obsoletes: libvirt-bash-completion < 7.3.0 =20 %description client The client binaries needed to access the virtualization @@ -925,12 +925,6 @@ Requires: cyrus-sasl-gssapi %description libs Shared libraries for accessing the libvirt daemon. =20 -%package bash-completion -Summary: Bash completion script - -%description bash-completion -Bash completion script stub. - %if %{with_wireshark} %package wireshark Summary: Wireshark dissector plugin for libvirt RPC transactions --=20 2.26.3