From nobody Mon Feb 9 19:53:43 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1618833306; cv=none; d=zohomail.com; s=zohoarc; b=JYScg4Yeg5Q++Dd8LTNLbEnJCxP26QtF0d6enC9UIK2NCY3TVgaM/weuuRwIqVzJ9ReErf5rVOtSbnVlZXHAdOMwRGkaXIqU7Jft3bjg7hSvNnhLqZEtiAgzd2eunTg66kWfxY7VD5R9C4ixa6UT7dYhEsHC2RR3k9KB7+ptz1w= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1618833306; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=zalVDK4+xlY+QDk1HdKOW/YrvhCXlMRYXRadSs89MN4=; b=QDhdM+Mi7RSPKxcyaziAOOnTInmhDvO1iC40Rbsmwsd6AiYqda3a6rz89jF1eg1TtezsYu57JBgWq7QhSmbS4GK6Xgb/5woyyGKN7oxcLqf1B//rA057cA1/r/0NTAmH4KNg71/Mb8b7gh/d9Kd2ULIe42Hx/uK7nAwTIFhAUWA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1618833306201955.6728549643934; Mon, 19 Apr 2021 04:55:06 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-42-B12gttpvNQyUdEACvOhQcA-1; Mon, 19 Apr 2021 07:55:02 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 034216D24E; Mon, 19 Apr 2021 11:54:57 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CC52160C04; Mon, 19 Apr 2021 11:54:56 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 8B1F444A57; Mon, 19 Apr 2021 11:54:56 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 13JBsgDN012844 for ; Mon, 19 Apr 2021 07:54:42 -0400 Received: by smtp.corp.redhat.com (Postfix) id B46F15C1CF; Mon, 19 Apr 2021 11:54:42 +0000 (UTC) Received: from work.redhat.com (ovpn-113-106.ams2.redhat.com [10.36.113.106]) by smtp.corp.redhat.com (Postfix) with ESMTP id D15095C1C4; Mon, 19 Apr 2021 11:54:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1618833305; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=zalVDK4+xlY+QDk1HdKOW/YrvhCXlMRYXRadSs89MN4=; b=dqpk+q32BKb7Q+FxK2P4QoYvVzJIGBkGt9Bd3KWf2bJpHcyueDxBXxB8XzxKulJwe6S7d5 NfrfV7UPVGSyEbn85+SlUcGTz7Pg0XEFuthhRxX6tH8qE5kBcIoq2ZPb7pwcUgmdvLkmXH 7kHknVL07ek2vkhVOPynL6C7kXjpfVA= X-MC-Unique: B12gttpvNQyUdEACvOhQcA-1 From: Tim Wiederhake To: libvir-list@redhat.com Subject: [libvirt PATCH v2 2/5] virDomainFeaturesDefParse: Fix memory leak Date: Mon, 19 Apr 2021 13:54:12 +0200 Message-Id: <20210419115415.19145-3-twiederh@redhat.com> In-Reply-To: <20210419115415.19145-1-twiederh@redhat.com> References: <20210419115415.19145-1-twiederh@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-loop: libvir-list@redhat.com Cc: Peter Krempa , Tim Wiederhake X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Fixes: 94013ee04e3945307a71f5c4897d78729e7eaff4 Signed-off-by: Tim Wiederhake Reviewed-by: Peter Krempa --- src/conf/domain_conf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 17bbeddec6..356398294e 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -19007,12 +19007,12 @@ virDomainFeaturesDefParse(virDomainDef *def, int feature; int value; g_autofree char *ptval =3D NULL; - g_autofree char *tmp =3D NULL; =20 if ((n =3D virXPathNodeSet("./features/xen/*", ctxt, &nodes)) < 0) return -1; =20 for (i =3D 0; i < n; i++) { + g_autofree char *tmp =3D NULL; feature =3D virDomainXenTypeFromString((const char *)nodes[i]-= >name); if (feature < 0) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, --=20 2.26.3