From nobody Fri May 17 09:38:20 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1618499326; cv=none; d=zohomail.com; s=zohoarc; b=fhrwhWAxDqTbW1PiphShT2hFMVhE53PG2cRHb5kJfCRKBumsg9NmbOjxuVEXvlasSq+o83GevTPHNvU+PpmWScufJsikPdOZA4FLiwyy5sBoWcmlw//hsxYEMKAPnpsZGxUvEvl++HXp8/RNJz96Iu2575TFtdiI5WW4GaIkR24= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1618499326; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=TPZG7lJWljqz1VIao9PxIgFXopVpTgL8DqrETM5c4SI=; b=cTp0miywUZSedIG9LstJ3wwIhfGC5VJKdF9R3hFtC6Yu0WeTzUi6EZq8rDU0YpOtA3m6qytxrfbeRppkAAfC7rTyxA+j78ZI+c+cD1QWbqfUqEd1pvqq5U9tVYyARhU3zDES49hliH0/mM2dHkWLHlwY9OSMrSZ4yLc4ojRTJ44= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1618499326614381.4196070408053; Thu, 15 Apr 2021 08:08:46 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-172-6XPT1FKHOvKqGy-nj7sJtg-1; Thu, 15 Apr 2021 11:08:41 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9D649A40E7; Thu, 15 Apr 2021 15:08:36 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DE89F60917; Thu, 15 Apr 2021 15:08:35 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 664C51806D15; Thu, 15 Apr 2021 15:08:33 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 13FF8VpN029769 for ; Thu, 15 Apr 2021 11:08:31 -0400 Received: by smtp.corp.redhat.com (Postfix) id 1417A53CC3; Thu, 15 Apr 2021 15:08:31 +0000 (UTC) Received: from work.redhat.com (ovpn-114-212.ams2.redhat.com [10.36.114.212]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5AD0A60CC5; Thu, 15 Apr 2021 15:08:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1618499323; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=TPZG7lJWljqz1VIao9PxIgFXopVpTgL8DqrETM5c4SI=; b=WQtyhsiDeVwrwae/31/kWbxepNAFG6gbSDtZZYDO12M1Nf0aqvM1ghExQFeuIGyEkx0zlm dmbV1+oXhPlbDgDo0a9S0ZwPv+yg2RuggSMPNJYiHzJUgFtnxRIYFE7rTqAvLodtf3RQoI PpcJnp4B6+iNSpSDfdUKxV5983vdwZ8= X-MC-Unique: 6XPT1FKHOvKqGy-nj7sJtg-1 From: Tim Wiederhake To: libvir-list@redhat.com Subject: [libvirt PATCH 1/3] xenParseHypervisorFeatures: Fix memory leak Date: Thu, 15 Apr 2021 17:08:26 +0200 Message-Id: <20210415150828.134760-2-twiederh@redhat.com> In-Reply-To: <20210415150828.134760-1-twiederh@redhat.com> References: <20210415150828.134760-1-twiederh@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com Cc: Tim Wiederhake X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Signed-off-by: Tim Wiederhake --- src/libxl/xen_common.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/libxl/xen_common.c b/src/libxl/xen_common.c index 12a44280cb..ad5a3de116 100644 --- a/src/libxl/xen_common.c +++ b/src/libxl/xen_common.c @@ -567,6 +567,7 @@ xenParseHypervisorFeatures(virConf *conf, virDomainDef = *def) timer->mode =3D VIR_DOMAIN_TIMER_MODE_PARAVIRT; =20 def->clock.timers[def->clock.ntimers - 1] =3D timer; + VIR_FREE(strval); } =20 if (xenConfigGetString(conf, "passthrough", &strval, NULL) < 0) --=20 2.26.2 From nobody Fri May 17 09:38:20 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1618499345; cv=none; d=zohomail.com; s=zohoarc; b=F/vbNYIei/zDoJDOv1IIsWsgaHEHIbIfD6p4DjHLYnR5IgPFcTyiXP7p5esFqARPCsVFZZ85+xCnleGYD7IcZ5+nqpolQTN/dIBoecn/RVT6UZbaxxV6jaTuy5RSzdv3CelmC2wO9boRccpRDe2cpqDDH0DaFr7QSnw75ySSKnk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1618499345; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=5VEWRZq0mknWmuHx/bylk1ilUKpbiQLj/0qB/evn6Q4=; b=j++w+WES4iNNP8MkrhG00JQBNyJ0FQVDK1jhCG3EqeMqAQfgYiXiDGJ2gWDOG8tDP1vhF0MYwNaKyNqrjQjfEVQsyfPhDoBu1YgpSVDqOp7xI7teiN7GiQqTgsMTj6e+iJwUg46NgTgYGbwCjhh37gQ/nNqHOfzTUhmsBkzOpYs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1618499345406860.4957437089253; Thu, 15 Apr 2021 08:09:05 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-238-wJk1o56gPf6AQNL6Q5Tc6g-1; Thu, 15 Apr 2021 11:08:56 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3ECA7108BC2E; Thu, 15 Apr 2021 15:08:50 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 176FE6064B; Thu, 15 Apr 2021 15:08:50 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 7E56E1806D16; Thu, 15 Apr 2021 15:08:49 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 13FF8WS1029778 for ; Thu, 15 Apr 2021 11:08:32 -0400 Received: by smtp.corp.redhat.com (Postfix) id 22D0460917; Thu, 15 Apr 2021 15:08:32 +0000 (UTC) Received: from work.redhat.com (ovpn-114-212.ams2.redhat.com [10.36.114.212]) by smtp.corp.redhat.com (Postfix) with ESMTP id 65F6160CC5; Thu, 15 Apr 2021 15:08:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1618499343; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=5VEWRZq0mknWmuHx/bylk1ilUKpbiQLj/0qB/evn6Q4=; b=ZMw3hsHLh1R62dNEnIlxY4BaDn0vWg8MaQAwah/ZB+dOdmTaS0zQk0AiV8CBJmIEyjoRjX D7AdNaXmx8qUKHJnn6CacHuc+2Gk8caRCRfxzYh0pJpLlXz7qWi8xVFYRhBb5i9Wc/fvkp vYVqAGjaePtnz/7kzGQkigU1pbkatUc= X-MC-Unique: wJk1o56gPf6AQNL6Q5Tc6g-1 From: Tim Wiederhake To: libvir-list@redhat.com Subject: [libvirt PATCH 2/3] virDomainFeaturesDefParse: Fix memory leak Date: Thu, 15 Apr 2021 17:08:27 +0200 Message-Id: <20210415150828.134760-3-twiederh@redhat.com> In-Reply-To: <20210415150828.134760-1-twiederh@redhat.com> References: <20210415150828.134760-1-twiederh@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com Cc: Tim Wiederhake X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Signed-off-by: Tim Wiederhake Reviewed-by: Peter Krempa --- src/conf/domain_conf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 029f2d8d9c..5591681283 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -18994,12 +18994,12 @@ virDomainFeaturesDefParse(virDomainDef *def, int feature; int value; g_autofree char *ptval =3D NULL; - g_autofree char *tmp =3D NULL; =20 if ((n =3D virXPathNodeSet("./features/xen/*", ctxt, &nodes)) < 0) return -1; =20 for (i =3D 0; i < n; i++) { + g_autofree char *tmp =3D NULL; feature =3D virDomainXenTypeFromString((const char *)nodes[i]-= >name); if (feature < 0) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, --=20 2.26.2 From nobody Fri May 17 09:38:20 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1618499340; cv=none; d=zohomail.com; s=zohoarc; b=QVFVaESM3CTVvgro6tgevjIvqSCKDH2k6hMYCMMgSA0bhOIj0m48M5KORSd5kPOat4FUjxKglblzk58Xp8Ah4Yl9TSkfrE9jQ/xIzxC6geZGlbacAn+3m++jig+dNtxU6fEYb5kn0egtUdhYfpW+vptBRBqCG9zRPq8l/47CaFE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1618499340; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=bwtVFjVAcnDYzYeJ5kKD3iKR6L0Cg3o/BU7tZDzIetU=; b=iTC79FcA8dXoOwfSddGGaNnrESJ6dvLWU3eBZV+J5/kyHHBLtNnblnI/uneKoolOoLgossdoi1N/gsKv1SU7UMCKZ62aKurSyPQqhm7Sh67HH02NDl1lKuaFrEIMi2nMsM/T3a55WE62yGuBjxTi+Io6r9zMZ/Xt1ciKbnB51Wo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1618499340977163.76268784708043; Thu, 15 Apr 2021 08:09:00 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-238-JAv_E7m1N9qZMvMy9t3Ekg-1; Thu, 15 Apr 2021 11:08:55 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 40969192378D; Thu, 15 Apr 2021 15:08:50 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1D6245D735; Thu, 15 Apr 2021 15:08:50 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 88A6B44A5E; Thu, 15 Apr 2021 15:08:49 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 13FF8XmS029786 for ; Thu, 15 Apr 2021 11:08:33 -0400 Received: by smtp.corp.redhat.com (Postfix) id 2CBD960917; Thu, 15 Apr 2021 15:08:33 +0000 (UTC) Received: from work.redhat.com (ovpn-114-212.ams2.redhat.com [10.36.114.212]) by smtp.corp.redhat.com (Postfix) with ESMTP id 73CA060CC5; Thu, 15 Apr 2021 15:08:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1618499338; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=bwtVFjVAcnDYzYeJ5kKD3iKR6L0Cg3o/BU7tZDzIetU=; b=DsFERKGDPW2JCXJG6oyjibTYbO1EMk3ZkWrEfKEJyxlroS53Mu37SaTwSjQUHss86jaRAw HtuC7e9X/jZ+2FoR/lJke+N0Yq6UWwpC4BcH3QKc59fjpo8ajOiaXaGoUF0/2SFTYoR8qb GYVm4zAZmnxPKjlWwUgD7BCHunvont4= X-MC-Unique: JAv_E7m1N9qZMvMy9t3Ekg-1 From: Tim Wiederhake To: libvir-list@redhat.com Subject: [libvirt PATCH 3/3] virQEMUCapsSetHostModel: Fix memory leak Date: Thu, 15 Apr 2021 17:08:28 +0200 Message-Id: <20210415150828.134760-4-twiederh@redhat.com> In-Reply-To: <20210415150828.134760-1-twiederh@redhat.com> References: <20210415150828.134760-1-twiederh@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com Cc: Tim Wiederhake X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" virQEMUCapsSetHostModel is called by virQEMUCapsInitHostCPUModel, which in turn is typically called twice (for KVM and QEMU), e.g. in virQEMUCapsLoadCache and virQEMUCapsNewForBinaryInternal. The second call leaks memory pointed to by "reported", "migratable" and "full". Signed-off-by: Tim Wiederhake --- src/qemu/qemu_capabilities.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index f1a3c526ef..ff8877631c 100644 --- a/src/qemu/qemu_capabilities.c +++ b/src/qemu/qemu_capabilities.c @@ -2276,6 +2276,14 @@ virQEMUCapsSetHostModel(virQEMUCaps *qemuCaps, virQEMUCapsHostCPUData *cpuData; =20 cpuData =3D &virQEMUCapsGetAccel(qemuCaps, type)->hostCPU; + + if (cpuData->reported) + virCPUDefFree(cpuData->reported); + if (cpuData->migratable) + virCPUDefFree(cpuData->migratable); + if (cpuData->full) + virCPUDefFree(cpuData->full); + cpuData->reported =3D reported; cpuData->migratable =3D migratable; cpuData->full =3D full; --=20 2.26.2