From nobody Fri May 17 07:07:52 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=quarantine dis=quarantine) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1618375476; cv=none; d=zohomail.com; s=zohoarc; b=LM1XbrtSU+ORuG/7d9KjoZaC4IHRIqaE0/dd8FjRi9if4xybvJgqroNJdyUEf9y+kL6uYtA9i2vvxVF/cMdSoLgGX6mp+S8RH6un+2GKMBnG7QBO/EUM2bIxFaJu9ryJGh+lOT1xM3bspY4+3poNEdOEt2FRvo/U+KDNKZ9dZIc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1618375476; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=7CfXlj51TBCNzgxmquvI2GBaHiNqKNhDi7J9sAi2cug=; b=HD7x4G8bw3eFVaKH4VmZVOGua0tlAbWrDVPFMVo7ZbhpqJ0CLEcA0pyeUR+33TL8TuSXUBFgayFqndcQV5OhAUZwJM1exPaHK4jYtPZIstTExHUZX6mEGjyqONpLeAdIG3OrAYDRV2U9jEjewzBS6qbj0E7aGe1hxNMnpgmdhiw= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail header.from= (p=quarantine dis=quarantine) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1618375476861982.1914140817009; Tue, 13 Apr 2021 21:44:36 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-259-D0EPMwG6M6aE6XjqiTJ0rw-1; Wed, 14 Apr 2021 00:44:33 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B919A10054F6; Wed, 14 Apr 2021 04:44:25 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A9C38610A8; Wed, 14 Apr 2021 04:44:24 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 382B21809C82; Wed, 14 Apr 2021 04:44:19 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 13E4hEpO030271 for ; Wed, 14 Apr 2021 00:43:14 -0400 Received: by smtp.corp.redhat.com (Postfix) id 259B32102FD9; Wed, 14 Apr 2021 04:43:14 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast04.extmail.prod.ext.rdu2.redhat.com [10.11.55.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1E0972102FCA for ; Wed, 14 Apr 2021 04:43:07 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 34B6B100DE77 for ; Wed, 14 Apr 2021 04:43:07 +0000 (UTC) Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [62.140.7.102]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-139-7DOsYDliNCSjpTcoN8W6Hw-1; Wed, 14 Apr 2021 00:43:04 -0400 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04lp2051.outbound.protection.outlook.com [104.47.12.51]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-28-PBpst5UDObKZg14Z3r3Gkw-1; Wed, 14 Apr 2021 06:43:02 +0200 Received: from AM8PR04MB7970.eurprd04.prod.outlook.com (2603:10a6:20b:24f::9) by AM0PR04MB3956.eurprd04.prod.outlook.com (2603:10a6:208:5d::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4020.18; Wed, 14 Apr 2021 04:43:01 +0000 Received: from AM8PR04MB7970.eurprd04.prod.outlook.com ([fe80::8532:12af:9c2:66ca]) by AM8PR04MB7970.eurprd04.prod.outlook.com ([fe80::8532:12af:9c2:66ca%7]) with mapi id 15.20.4020.022; Wed, 14 Apr 2021 04:43:01 +0000 Received: from linux-tbji.devlab.prv.suse.com (205.201.32.8) by AM0PR10CA0085.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:208:15::38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4020.17 via Frontend Transport; Wed, 14 Apr 2021 04:43:00 +0000 X-MC-Unique: D0EPMwG6M6aE6XjqiTJ0rw-1 X-MC-Unique: 7DOsYDliNCSjpTcoN8W6Hw-1 X-MC-Unique: PBpst5UDObKZg14Z3r3Gkw-1 From: Jim Fehlig To: libvir-list@redhat.com Subject: [PATCH] libxl: Add debug statements Date: Tue, 13 Apr 2021 22:42:35 -0600 Message-ID: <20210414044235.24263-1-jfehlig@suse.com> X-Originating-IP: [205.201.32.8] X-ClientProxiedBy: AM0PR10CA0085.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:208:15::38) To AM8PR04MB7970.eurprd04.prod.outlook.com (2603:10a6:20b:24f::9) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6ccd36a3-b148-4ffa-3c2c-08d8feffc8a6 X-MS-TrafficTypeDiagnostic: AM0PR04MB3956: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508 X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0 X-Microsoft-Antispam-Message-Info: 2QFishNI38zQrMHw7M23dPpRfIypQdC2G+G9Yr6rMrsgfZTOAZM1w/SotSj4Wwo1oXNzWLaMS9zK7fuagi9DMjhTnFsW2XPfyLiEaOI5GxRCiRoGH3rxAEI0NF1feGC8zN8DE2szSs1wp779hUOFPadMqZZEg23c+pEVl5wlZzvLir1qN+GtcxBhBLld24bPGeDY5OfCTdxrcWuXPPX2mYdyDt6urKl3jmlueK0HRkm1zCqI5sr81vKUqxGnp11k/0p4GyIQDlTAjFWh0FhziYyyasyE7qgdMQCMB0bfL2E5YHgotxr40q3Qhfh990IyDksCUykMHo9v8mvBtlUAIdU0Z8GfrQ08sgb8D1B8v9EVSbS8g3eMP4nrTigkzKwSnJlTKR9gmmS6LXg9OoF9BJnVOB/ga84txX+sbIKAdOBnhdBBdqhCFAjmFyD19juiuxK6clqBo68oACJIFhedeyb6d2Vo7sIAIiIiqw2RcMinZndV9NkAeAKHLzeWABxRqWSvg86uSoE+J65KtpTlA8ZNq3Qt9sz1Ix7iwNxo4lWmzGG4ug9NKiq1px3lhAmwNFf0ztqZHsHcllITKdiBv27K6lxf8hTfJhOcdrf2sVAPDsVslntF/X34fgaPY+xnY1WdQ4gcWOkHDsfsriXi5Q== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM8PR04MB7970.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(396003)(39860400002)(346002)(136003)(366004)(376002)(52116002)(66946007)(83380400001)(26005)(1076003)(107886003)(8676002)(6916009)(66476007)(16526019)(6666004)(7696005)(316002)(66556008)(36756003)(2616005)(4326008)(478600001)(86362001)(38100700002)(38350700002)(6486002)(8936002)(5660300002)(956004)(2906002)(186003); DIR:OUT; SFP:1101 X-MS-Exchange-AntiSpam-MessageData: =?us-ascii?Q?0Ttg0NHEQ5V54dcxyM5csD8RLTHBOunu2ceJDrradkvmtHksGqpW+lewSAEK?= =?us-ascii?Q?E1pUkKKapWv9DpdZkAIL6DPuIr9VTPW/Qt8VXO53wXoEIlNgSeijZtFc9SFe?= =?us-ascii?Q?mfTy/80E1A9VxGFlI9HWLBwfIxdKcza0tNOGWLRO6faLGJS2l7p88q2M0qDD?= =?us-ascii?Q?C/vYA5F+qrrR4+dKrubrMwZyIkm/p1tu0YtiHfLVpS0yCxoyj/QtF2HaRKs8?= =?us-ascii?Q?KmWr7llxyvNdQGlCOdEj7jnW8HcAEAD5gPH0BtVeueaS39OwZIOi1RftN5IH?= =?us-ascii?Q?yJUl3oDHcblL9QNYrfpfxjk5bfutkOi7QMMmxQJeSWW5PotchWiS2zAGqfwz?= =?us-ascii?Q?DHVoKwl5DnHUd0hqvW/AI8u0XpkIQKLNW/ZElWaf2WbxJFuviTbQrHwYQhAY?= =?us-ascii?Q?oA+b1K7zLoGXU69T3znxR132s8GNc5tGDjbj0lBxamQb4CJS+V/IjdUcfpU/?= =?us-ascii?Q?os5Tmo6ZQ0Pc7B1WBzt8SCQQEugRuQK1vzsYX5u9R2YWoFctUdJuxldCHOkx?= =?us-ascii?Q?9z5c4wyal2XRRBavqiAjdtusOfbuLyUxRchO3NEFXF19NCfkJ7yglc0Y/q2K?= =?us-ascii?Q?RLqOMm1v8eMwBgdj9D5/KqpKcHJQLlQjvvav4ywMd0tGdHc1IZYEHeuLtMJe?= =?us-ascii?Q?I5aod5xNgI+zWIEkplakxcFl8fvF48G+LA9qbdBfLizecyQxuovpYZ2EY4Pg?= =?us-ascii?Q?NOb4N87r+mRUAlIvI6ZgpYNNS4qADII3NNWyVKpBb3g9r5IP2HLq7KHtI6b1?= =?us-ascii?Q?ZeiHX3XDO6Q7e8lqN85o/LbQPtYdkvzGzwcKOMiTWl9JFkoNETnoG/ygfU1x?= =?us-ascii?Q?KlYBmCC39XoN2pBq0l0MJBrCbr8NPxvejnO8ohXVyFZ25X6W+tcdZ+xn9VQc?= =?us-ascii?Q?bqBT4P6YaqFPvIYaMhBpZPCTb08YXwuqcrTVvNdNerNs21QMnffAA7y3JiJm?= =?us-ascii?Q?bDHYqB4TDnULcRC4O3yU5/XJ5Ec7ipRSIotGxEGvQsgdjWWLD2FmhuNQiSmu?= =?us-ascii?Q?lD/YxW0lUR/sZ+AdDvFmTvx2ksv7+le/DL8n6VqZBEjxRmoEX8FoNmieiZMl?= =?us-ascii?Q?Xs1D6LN5/e5ACqPPtMbWEwV/HDeDoD/AQViC5G7gabmosdO1QEdERIrQ2Gl0?= =?us-ascii?Q?/3TPhYqFKguVSIJHzyA++uXVSTVVZalRvaKYK4nV9TBG/YaYntTOIJICGP0U?= =?us-ascii?Q?QXTeBxlcZDPJhmuVjLcUZh7DRFHu4RIco2W/jxKqwpERFnoRPfjoXXe6qHx+?= =?us-ascii?Q?nYLuE0dTyp4shhvmEFax1HjwrCorYQyZEl7Q2yDC0peBPmBm+oqYsVtpNKlZ?= =?us-ascii?Q?YMvRgRO1dJpQ3FrLF+PHxMPA?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6ccd36a3-b148-4ffa-3c2c-08d8feffc8a6 X-MS-Exchange-CrossTenant-AuthSource: AM8PR04MB7970.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Apr 2021 04:43:01.2793 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 50dEdCOlmVYN5M9sBOyTq6qi7rq+77hcAtk0G85O091LrDmYOANynOZ8SH/FpuECy30RqYhyzRrY+mbWhH7i2g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB3956 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-MIME-Autoconverted: from quoted-printable to 8bit by lists01.pubmisc.prod.ext.phx2.redhat.com id 13E4hEpO030271 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Over several years of debugging reports related to VM shutdown, destruction, and cleanup, I've found that logging of all events received from libxl and logging the entry of libxlDomainCleanup has proven useful. Add the these debug messages upstream to aid in future debugging. Signed-off-by: Jim Fehlig --- src/libxl/libxl_domain.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/libxl/libxl_domain.c b/src/libxl/libxl_domain.c index a25d65629a..917f6f1d81 100644 --- a/src/libxl/libxl_domain.c +++ b/src/libxl/libxl_domain.c @@ -648,6 +648,8 @@ libxlDomainEventHandler(void *data, VIR_LIBXL_EVENT_CON= ST libxl_event *event) virDomainObj *vm =3D NULL; g_autoptr(libxlDriverConfig) cfg =3D NULL; =20 + VIR_DEBUG("Received libxl event '%d' for domid '%d'", event->type, eve= nt->domid); + if (event->type !=3D LIBXL_EVENT_TYPE_DOMAIN_SHUTDOWN && event->type !=3D LIBXL_EVENT_TYPE_DOMAIN_DEATH) { VIR_INFO("Unhandled event type %d", event->type); @@ -844,6 +846,9 @@ libxlDomainCleanup(libxlDriverPrivate *driver, unsigned int hostdev_flags =3D VIR_HOSTDEV_SP_PCI; g_autoptr(virConnect) conn =3D NULL; =20 + VIR_DEBUG("Cleaning up domain with id '%d' and name '%s'", + vm->def->id, vm->def->name); + #ifdef LIBXL_HAVE_PVUSB hostdev_flags |=3D VIR_HOSTDEV_SP_USB; #endif --=20 2.30.2