From nobody Mon May 6 18:02:06 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1617984307; cv=none; d=zohomail.com; s=zohoarc; b=LVVLnEoC3qC2g8kjPTAvAEuWSvyL04lG1ZT5Mp84d9JZriYaZeaFxGJlCVfifIMZDZTeJ+wIL6ab3aiu/qUFoy7kh/pXOtvwye6BfJrYUlfrHOD8dgGEYaMG/xuwZ8+z/ppEp/50ILicmREFyMmJF/FSml9F71JJ4LQs0B853ak= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1617984307; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=20FcjVXwqQ6SIO5CsxxrC5BjhQKDneCNr8SwLPYth84=; b=LU2VfR+3vakRmmkx0HlD26YsnOxSwYWyc/sebzN+IeDXnT8rCl8JuhYknAi1QCKLxdDfcHpleihuckQkCszylVMAj+w/oWp41PQ7F+6Rdbzulk8epsE+gkQEyIHXH8Cq7MMqzlbEP37VKntUJJTlV1eWVCmNa2z6HJn//rtjyT0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1617984307903786.7160487652746; Fri, 9 Apr 2021 09:05:07 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-302-70stYsyBOTeLuZRRAJJ1Jw-1; Fri, 09 Apr 2021 12:05:04 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 836FD8030C4; Fri, 9 Apr 2021 16:04:59 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E861E10016FE; Fri, 9 Apr 2021 16:04:57 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 07DC255348; Fri, 9 Apr 2021 16:04:56 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 139G4sBf000558 for ; Fri, 9 Apr 2021 12:04:54 -0400 Received: by smtp.corp.redhat.com (Postfix) id A831319704; Fri, 9 Apr 2021 16:04:54 +0000 (UTC) Received: from himantopus.redhat.com (ovpn-113-25.phx2.redhat.com [10.3.113.25]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 68AB719C66; Fri, 9 Apr 2021 16:04:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1617984306; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=20FcjVXwqQ6SIO5CsxxrC5BjhQKDneCNr8SwLPYth84=; b=VV9BBIbBFp48dB+5OCE6GmuFl8C3lHZr/LuVXSYuAfe1qZ2Us6LIpUqMqEeG2168Ce6H4X pafqaz+8mCtW5ahXyzrU/egx0V9LOWpdRT9GIXLVxn6O4cLYT0PQqCBjijwgKlj637ckDO 3WaggncRX1JaZh0FcHfVMmjqjIFzWUg= X-MC-Unique: 70stYsyBOTeLuZRRAJJ1Jw-1 From: Jonathon Jongsma To: libvir-list@redhat.com Subject: [libvirt PATCH 1/2] nodedev: fix release version in comments for new API Date: Fri, 9 Apr 2021 11:04:46 -0500 Message-Id: <20210409160447.3734839-2-jjongsma@redhat.com> In-Reply-To: <20210409160447.3734839-1-jjongsma@redhat.com> References: <20210409160447.3734839-1-jjongsma@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" The comments mistakenly say 7.2.0, when they were actually merged during the 7.3 development cycle. Signed-off-by: Jonathon Jongsma Reviewed-by: Daniel P. Berrang=C3=A9 --- src/node_device/node_device_udev.c | 6 +++--- src/remote/remote_driver.c | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/node_device/node_device_udev.c b/src/node_device/node_devi= ce_udev.c index 77b5a56f3d..7d4e8f5c0b 100644 --- a/src/node_device/node_device_udev.c +++ b/src/node_device/node_device_udev.c @@ -2325,9 +2325,9 @@ static virNodeDeviceDriver udevNodeDeviceDriver =3D { .nodeDeviceListCaps =3D nodeDeviceListCaps, /* 0.7.3 */ .nodeDeviceCreateXML =3D nodeDeviceCreateXML, /* 0.7.3 */ .nodeDeviceDestroy =3D nodeDeviceDestroy, /* 0.7.3 */ - .nodeDeviceDefineXML =3D nodeDeviceDefineXML, /* 7.2.0 */ - .nodeDeviceUndefine =3D nodeDeviceUndefine, /* 7.2.0 */ - .nodeDeviceCreate =3D nodeDeviceCreate, /* 7.2.0 */ + .nodeDeviceDefineXML =3D nodeDeviceDefineXML, /* 7.3.0 */ + .nodeDeviceUndefine =3D nodeDeviceUndefine, /* 7.3.0 */ + .nodeDeviceCreate =3D nodeDeviceCreate, /* 7.3.0 */ }; =20 =20 diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c index 31b293ac4a..82e4fba7a1 100644 --- a/src/remote/remote_driver.c +++ b/src/remote/remote_driver.c @@ -8696,9 +8696,9 @@ static virNodeDeviceDriver node_device_driver =3D { .nodeDeviceNumOfCaps =3D remoteNodeDeviceNumOfCaps, /* 0.5.0 */ .nodeDeviceListCaps =3D remoteNodeDeviceListCaps, /* 0.5.0 */ .nodeDeviceCreateXML =3D remoteNodeDeviceCreateXML, /* 0.6.3 */ - .nodeDeviceCreate =3D remoteNodeDeviceCreate, /* 7.2.0 */ - .nodeDeviceDefineXML =3D remoteNodeDeviceDefineXML, /* 7.2.0 */ - .nodeDeviceUndefine =3D remoteNodeDeviceUndefine, /* 7.2.0 */ + .nodeDeviceCreate =3D remoteNodeDeviceCreate, /* 7.3.0 */ + .nodeDeviceDefineXML =3D remoteNodeDeviceDefineXML, /* 7.3.0 */ + .nodeDeviceUndefine =3D remoteNodeDeviceUndefine, /* 7.3.0 */ .nodeDeviceDestroy =3D remoteNodeDeviceDestroy /* 0.6.3 */ }; =20 --=20 2.26.3 From nobody Mon May 6 18:02:06 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1617984317; cv=none; d=zohomail.com; s=zohoarc; b=EeFHmh0rLFj7VVmyBWIlnp4uLNaw1WCyyIo005KUdb2F+851K3fw4rwT50UIydFnj8W15tF2IHwdfDnzw6RyJ0bmPxkj5fHaSKui5Ar8R1rgj+SHj98reSqAt4wGHZ+5rMkZ1C3amDzbY3+xbsWTxOcAq1YHhPEBtic5W5vNEB8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1617984317; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=4UKtUpOUYgUm80EDmzAQ5Z6s9+82Dw20SIf608bkHvU=; b=Bd9jcLL4zKga7YozYpRitEWP1hXk+jHhhQReV7305J4z67tyvnVux7qL8B61Tg0FeAY6t+2sAjJKgyEUulPR1mHtmEjPs9Fatv934c9OnS/+lQQMWpcgdIOfwP3I/qpvjwFTJ+FqbidHgx+CDftFfPW6sqS4f0b03SHHWoQDqek= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 161798431777714.43972794734509; Fri, 9 Apr 2021 09:05:17 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-216-fvqZeiDNPDyul5860Ro-XA-1; Fri, 09 Apr 2021 12:05:13 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 847D78030CA; Fri, 9 Apr 2021 16:05:07 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 576615DEAD; Fri, 9 Apr 2021 16:05:07 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 126A35534B; Fri, 9 Apr 2021 16:05:07 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 139G4tJa000564 for ; Fri, 9 Apr 2021 12:04:55 -0400 Received: by smtp.corp.redhat.com (Postfix) id 1CFFA19727; Fri, 9 Apr 2021 16:04:55 +0000 (UTC) Received: from himantopus.redhat.com (ovpn-113-25.phx2.redhat.com [10.3.113.25]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C59BF19C66; Fri, 9 Apr 2021 16:04:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1617984316; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=4UKtUpOUYgUm80EDmzAQ5Z6s9+82Dw20SIf608bkHvU=; b=eGLg4QgEYK5ezUM/s50ZzYHb8j9Rj4AOEk1D2i/9NX/Ektha4llfGiADCPCqPlgw1au2mx 3xKUZWAGgGWxH+GyVKJT6/YO/WHT0L1V9sjQSkcNy3Gwvee5DQb/NtPmOvjNgU1o6ts8KB DgX0BYUmTWa+Bl75fY8zAjd15OpOh5s= X-MC-Unique: fvqZeiDNPDyul5860Ro-XA-1 From: Jonathon Jongsma To: libvir-list@redhat.com Subject: [libvirt PATCH 2/2] api: Add 'flags' param to virNodeDeviceCreate/Undefine() Date: Fri, 9 Apr 2021 11:04:47 -0500 Message-Id: <20210409160447.3734839-3-jjongsma@redhat.com> In-Reply-To: <20210409160447.3734839-1-jjongsma@redhat.com> References: <20210409160447.3734839-1-jjongsma@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Follow best practices and add a unsigned int flags parameter to these new APIs that have not been in a release yet. Signed-off-by: Jonathon Jongsma Reviewed-by: Daniel P. Berrang=C3=A9 --- include/libvirt/libvirt-nodedev.h | 6 ++++-- src/driver-nodedev.h | 6 ++++-- src/libvirt-nodedev.c | 16 ++++++++++------ src/node_device/node_device_driver.c | 10 ++++++++-- src/node_device/node_device_driver.h | 6 ++++-- src/remote/remote_protocol.x | 2 ++ src/remote_protocol-structs | 2 ++ tools/virsh-nodedev.c | 4 ++-- 8 files changed, 36 insertions(+), 16 deletions(-) diff --git a/include/libvirt/libvirt-nodedev.h b/include/libvirt/libvirt-no= dedev.h index cf51c3d085..067d914d37 100644 --- a/include/libvirt/libvirt-nodedev.h +++ b/include/libvirt/libvirt-nodedev.h @@ -135,9 +135,11 @@ virNodeDevicePtr virNodeDeviceDefineXML(virConnectPtr = conn, const char *xmlDesc, unsigned int flags); =20 -int virNodeDeviceUndefine(virNodeDevicePtr dev); +int virNodeDeviceUndefine(virNodeDevicePtr dev, + unsigned int flags); =20 -int virNodeDeviceCreate(virNodeDevicePtr dev); +int virNodeDeviceCreate(virNodeDevicePtr dev, + unsigned int flags); =20 /** * VIR_NODE_DEVICE_EVENT_CALLBACK: diff --git a/src/driver-nodedev.h b/src/driver-nodedev.h index d2c7f7fe17..75464943a5 100644 --- a/src/driver-nodedev.h +++ b/src/driver-nodedev.h @@ -80,10 +80,12 @@ typedef virNodeDevicePtr unsigned int flags); =20 typedef int -(*virDrvNodeDeviceUndefine)(virNodeDevicePtr dev); +(*virDrvNodeDeviceUndefine)(virNodeDevicePtr dev, + unsigned int flags); =20 typedef int -(*virDrvNodeDeviceCreate)(virNodeDevicePtr dev); +(*virDrvNodeDeviceCreate)(virNodeDevicePtr dev, + unsigned int flags); =20 typedef int (*virDrvConnectNodeDeviceEventRegisterAny)(virConnectPtr conn, diff --git a/src/libvirt-nodedev.c b/src/libvirt-nodedev.c index 477232f630..e416c12534 100644 --- a/src/libvirt-nodedev.c +++ b/src/libvirt-nodedev.c @@ -782,6 +782,7 @@ virNodeDeviceDefineXML(virConnectPtr conn, /** * virNodeDeviceUndefine: * @dev: a device object + * @flags: extra flags; not used yet, so callers should always pass 0 * * Undefine the device object. The virtual device is removed from the host * operating system. This function may require privileged access. @@ -789,9 +790,10 @@ virNodeDeviceDefineXML(virConnectPtr conn, * Returns 0 in case of success and -1 in case of failure. */ int -virNodeDeviceUndefine(virNodeDevicePtr dev) +virNodeDeviceUndefine(virNodeDevicePtr dev, + unsigned int flags) { - VIR_DEBUG("dev=3D%p", dev); + VIR_DEBUG("dev=3D%p, flags=3D0x%x", dev, flags); =20 virResetLastError(); =20 @@ -800,7 +802,7 @@ virNodeDeviceUndefine(virNodeDevicePtr dev) =20 if (dev->conn->nodeDeviceDriver && dev->conn->nodeDeviceDriver->nodeDeviceUndefine) { - int retval =3D dev->conn->nodeDeviceDriver->nodeDeviceUndefine(dev= ); + int retval =3D dev->conn->nodeDeviceDriver->nodeDeviceUndefine(dev= , flags); if (retval < 0) goto error; =20 @@ -818,15 +820,17 @@ virNodeDeviceUndefine(virNodeDevicePtr dev) /** * virNodeDeviceCreate: * @dev: a device object + * @flags: extra flags; not used yet, so callers should always pass 0 * * Start a defined node device: * * Returns 0 in case of success and -1 in case of failure. */ int -virNodeDeviceCreate(virNodeDevicePtr dev) +virNodeDeviceCreate(virNodeDevicePtr dev, + unsigned int flags) { - VIR_DEBUG("dev=3D%p", dev); + VIR_DEBUG("dev=3D%p, flags=3D0x%x", dev, flags); =20 virResetLastError(); =20 @@ -835,7 +839,7 @@ virNodeDeviceCreate(virNodeDevicePtr dev) =20 if (dev->conn->nodeDeviceDriver && dev->conn->nodeDeviceDriver->nodeDeviceCreate) { - int retval =3D dev->conn->nodeDeviceDriver->nodeDeviceCreate(dev); + int retval =3D dev->conn->nodeDeviceDriver->nodeDeviceCreate(dev, = flags); if (retval < 0) goto error; =20 diff --git a/src/node_device/node_device_driver.c b/src/node_device/node_de= vice_driver.c index 951a77f902..c11b8d89ab 100644 --- a/src/node_device/node_device_driver.c +++ b/src/node_device/node_device_driver.c @@ -1341,12 +1341,15 @@ nodeDeviceDefineXML(virConnect *conn, =20 =20 int -nodeDeviceUndefine(virNodeDevice *device) +nodeDeviceUndefine(virNodeDevice *device, + unsigned int flags) { int ret =3D -1; virNodeDeviceObj *obj =3D NULL; virNodeDeviceDef *def; =20 + virCheckFlags(0, -1); + if (nodeDeviceWaitInit() < 0) return -1; =20 @@ -1387,12 +1390,15 @@ nodeDeviceUndefine(virNodeDevice *device) =20 =20 int -nodeDeviceCreate(virNodeDevice *device) +nodeDeviceCreate(virNodeDevice *device, + unsigned int flags) { int ret =3D -1; virNodeDeviceObj *obj =3D NULL; virNodeDeviceDef *def =3D NULL; =20 + virCheckFlags(0, -1); + if (!(obj =3D nodeDeviceObjFindByName(device->name))) return -1; =20 diff --git a/src/node_device/node_device_driver.h b/src/node_device/node_de= vice_driver.h index 4d10be2611..8a935ffed6 100644 --- a/src/node_device/node_device_driver.h +++ b/src/node_device/node_device_driver.h @@ -108,7 +108,8 @@ nodeDeviceDefineXML(virConnect *conn, unsigned int flags); =20 int -nodeDeviceUndefine(virNodeDevice *dev); +nodeDeviceUndefine(virNodeDevice *dev, + unsigned int flags); =20 int nodeConnectNodeDeviceEventRegisterAny(virConnectPtr conn, @@ -165,4 +166,5 @@ nodeDeviceGetMdevctlCreateCommand(const char *uuid, char **errmsg); =20 int -nodeDeviceCreate(virNodeDevice *dev); +nodeDeviceCreate(virNodeDevice *dev, + unsigned int flags); diff --git a/src/remote/remote_protocol.x b/src/remote/remote_protocol.x index ecfc708fb7..de69704b68 100644 --- a/src/remote/remote_protocol.x +++ b/src/remote/remote_protocol.x @@ -2156,10 +2156,12 @@ struct remote_node_device_define_xml_ret { =20 struct remote_node_device_undefine_args { remote_nonnull_string name; + unsigned int flags; }; =20 struct remote_node_device_create_args { remote_nonnull_string name; + unsigned int flags; }; =20 =20 diff --git a/src/remote_protocol-structs b/src/remote_protocol-structs index 15bd7ae8f0..6b46328adc 100644 --- a/src/remote_protocol-structs +++ b/src/remote_protocol-structs @@ -1609,9 +1609,11 @@ struct remote_node_device_define_xml_ret { }; struct remote_node_device_undefine_args { remote_nonnull_string name; + u_int flags; }; struct remote_node_device_create_args { remote_nonnull_string name; + u_int flags; }; struct remote_connect_domain_event_register_ret { int cb_registered; diff --git a/tools/virsh-nodedev.c b/tools/virsh-nodedev.c index e13c15b4b0..8b59b1f452 100644 --- a/tools/virsh-nodedev.c +++ b/tools/virsh-nodedev.c @@ -1045,7 +1045,7 @@ cmdNodeDeviceUndefine(vshControl *ctl, const vshCmd *= cmd G_GNUC_UNUSED) if (!dev) goto cleanup; =20 - if (virNodeDeviceUndefine(dev) =3D=3D 0) { + if (virNodeDeviceUndefine(dev, 0) =3D=3D 0) { vshPrintExtra(ctl, _("Undefined node device '%s'\n"), device_value= ); } else { vshError(ctl, _("Failed to undefine node device '%s'"), device_val= ue); @@ -1151,7 +1151,7 @@ cmdNodeDeviceStart(vshControl *ctl, const vshCmd *cmd) return false; } =20 - if (virNodeDeviceCreate(device) =3D=3D 0) { + if (virNodeDeviceCreate(device, 0) =3D=3D 0) { vshPrintExtra(ctl, _("Device %s started\n"), name); } else { vshError(ctl, _("Failed to start device %s"), name); --=20 2.26.3