From nobody Tue May 7 04:57:21 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1617958368; cv=none; d=zohomail.com; s=zohoarc; b=B3bIZcXdwafWgGn7a1a4k10R8mIr+FFwFHLQKjtbIiW70qoyPaltlGyUshh1OHwuJsogGcnDXGmLPccZWTvG52+deOTpWIBEV4Aglcrxuyc60iixuNP8kLS/MlZMswYeiwdpBSmygax1+oIavREmR0rkxDTVJ4PdmqdZeUYwrE8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1617958368; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=kinha7t6jCslcqTidrJEbgKLxEo54U4te9iHH4aipEg=; b=ev8uKqMN2VWwYZbgm8+EETuMkVRUBR9KpycGmT6m4plmg+BO5lgritdZlFlzl39jlUKPIWp3DcoQOHJCoZQ1h1Njj02uIl1Sz6Z5nX+hkYLeCnrFfnTXeZn1b88Wv2pHIa4UGm+ApGMQ3PHCSR7TTzuu1F77l45gKQIbnTW7n6g= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1617958368837368.6148494425415; Fri, 9 Apr 2021 01:52:48 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-158-1Kk3xcYJNeepR5C54B9gEg-1; Fri, 09 Apr 2021 04:52:45 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 992221006706; Fri, 9 Apr 2021 08:52:40 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id AA55D5D9F2; Fri, 9 Apr 2021 08:52:37 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id D95B11806D10; Fri, 9 Apr 2021 08:52:35 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 138IFoue023319 for ; Thu, 8 Apr 2021 14:15:50 -0400 Received: by smtp.corp.redhat.com (Postfix) id 38858FDCD7; Thu, 8 Apr 2021 18:15:50 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast02.extmail.prod.ext.rdu2.redhat.com [10.11.55.18]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 333FAFDCE4 for ; Thu, 8 Apr 2021 18:15:47 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D4797800883 for ; Thu, 8 Apr 2021 18:15:47 +0000 (UTC) Received: from mail-ot1-f41.google.com (mail-ot1-f41.google.com [209.85.210.41]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-266-dxcihrDlORq7glZTpxAk2w-1; Thu, 08 Apr 2021 14:15:46 -0400 Received: by mail-ot1-f41.google.com with SMTP id 91-20020a9d08640000b0290237d9c40382so3167872oty.12 for ; Thu, 08 Apr 2021 11:15:45 -0700 (PDT) Received: from localhost.localdomain (ip72-206-4-75.fv.ks.cox.net. [72.206.4.75]) by smtp.googlemail.com with ESMTPSA id u8sm43036oot.24.2021.04.08.11.15.43 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 08 Apr 2021 11:15:44 -0700 (PDT) X-MC-Unique: 1Kk3xcYJNeepR5C54B9gEg-1 X-MC-Unique: dxcihrDlORq7glZTpxAk2w-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=kinha7t6jCslcqTidrJEbgKLxEo54U4te9iHH4aipEg=; b=fA1ENayvk3HpP6UZhCECKG6zsIndT9TsShYT3YIc01ymGcsur5AOJ0lIu67ohMO89N Ydgra6PD43n2c3CzOEgI8OrF1rmrLR6RMfkj6AvDbqI4EX+4KuoFM9nmAzIALxE1Jvi3 y3wOvjR2oXReTwD5mMdbnBn4Sdaif+0xaiYC3pPH6zpBCUP8Dj/hWZMGJTxt37J0+q5p dDJJXbCfUbs2OhCnmG5Wk067n8D7fP6rNjVplDgVdQkOo2vrvR6mGn8w6v4/ybp2pM6U lERHSPpQErSHmcugyHu7wIG3uoBcKchZW/Z5dLtUJzZuHaYrVE/v0kod4oH6xehdKbqy GMVQ== X-Gm-Message-State: AOAM531UL4rutpvjqacyImplVLJf/eROxyZ4O9B6OV9qXshRC+JOCPgx 2Us5pk1u6BecxwxYXb8d7BEBnNEIaHbcfA== X-Google-Smtp-Source: ABdhPJzhekEjC9dDjhhGcEnQEEmXIBd1JZpmROy79qNbW/MewXx/pPltciAsqggHCRZearA9s166Sg== X-Received: by 2002:a9d:d02:: with SMTP id 2mr8460139oti.330.1617905745059; Thu, 08 Apr 2021 11:15:45 -0700 (PDT) From: Charlie Sharpsteen To: libvir-list@redhat.com Subject: [PATCH] vbox: Make host CPU cache init non-fatal Date: Thu, 8 Apr 2021 13:15:28 -0500 Message-Id: <20210408181528.69944-1-source@sharpsteen.net> MIME-Version: 1.0 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-loop: libvir-list@redhat.com X-Mailman-Approved-At: Fri, 09 Apr 2021 04:52:34 -0400 Cc: Charlie Sharpsteen X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This commit updates the vbox driver to log a warning if the virCapabilitiesInitCaches function fails instead of treating failure as a fatal error. CPU cache initialization requires the sysfs filesystem in order to complete successfully and thus fails on platforms such as macOS. This commit is similar to ace6528ae19, which made the same change to the VMware driver. Signed-off-by: Charlie Sharpsteen Reviewed-by: Daniel Henrique Barboza --- src/vbox/vbox_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/vbox/vbox_common.c b/src/vbox/vbox_common.c index 5a5de85eab..933851346b 100644 --- a/src/vbox/vbox_common.c +++ b/src/vbox/vbox_common.c @@ -98,7 +98,7 @@ vboxCapsInit(void) return NULL; =20 if (virCapabilitiesInitCaches(caps) < 0) - return NULL; + VIR_WARN("Failed to get host CPU cache info"); =20 if ((guest =3D virCapabilitiesAddGuest(caps, VIR_DOMAIN_OSTYPE_HVM, --=20 2.31.1