From nobody Fri Apr 26 04:04:00 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1617886866; cv=none; d=zohomail.com; s=zohoarc; b=RXYRRxh9DCr+UnUGMlsoBGtHjzntmroh5LZi+CYnB0vv7dvgdGIj9weC9Q/X8Rmls5g5KIBR5fCFNrZ2rywGO01jRtcDaJ3JvD/96Mbnm76s1MojsbmOCx8X9+5my63mue8Sg8cmVpD+gpUwxRoqcxt2QQJhMTC4XNm3yN53vLw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1617886866; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=aCZRri7ahgqcGYlsSOEuKbySdT9Tg17SvJ60mu9F4Pc=; b=A5NWzSPcoSlWcFglkKzHSjElPHS1MVQD6e8sqz+SObPaOldCJq7TC8al2c5o/Z+kak/ZVgYRcQn0wQUJUeykTVcArf9yBDj1kLYfomoMova9OQ5hmUVgYre18JRFUQdFITFlIujw/FDLfsQRjbcoEWVjK0qEwyaE2JKrZYnH7YY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1617886866749137.8388638512091; Thu, 8 Apr 2021 06:01:06 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-495-1wtBW-H6MuKsGKSbTkpP_A-1; Thu, 08 Apr 2021 09:00:58 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6EA74186833E; Thu, 8 Apr 2021 13:00:37 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8443660864; Thu, 8 Apr 2021 13:00:36 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 485F655345; Thu, 8 Apr 2021 13:00:31 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 138D0Uj8021005 for ; Thu, 8 Apr 2021 09:00:30 -0400 Received: by smtp.corp.redhat.com (Postfix) id 1F6C86A97E; Thu, 8 Apr 2021 13:00:30 +0000 (UTC) Received: from localhost.localdomain.com (ovpn-115-81.ams2.redhat.com [10.36.115.81]) by smtp.corp.redhat.com (Postfix) with ESMTP id 03D1A60CCE; Thu, 8 Apr 2021 13:00:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1617886863; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=aCZRri7ahgqcGYlsSOEuKbySdT9Tg17SvJ60mu9F4Pc=; b=LEmErEC0Woo6HZQmNcHB8bkKHlbxdmLPysGgoS3qkcWG5KUS07ssw1JNe3r8AZaBmIUjr/ zoYlIFW4AHzN/V0rXxiXF8hWwmKTQlcCoTtN3wgi3Vvrx+7YVEt8xTezVeRhXatBV7o8HW cK7UIU8jyRWNgGG7+ZyBoruRtyl0Ro0= X-MC-Unique: 1wtBW-H6MuKsGKSbTkpP_A-1 From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: libvir-list@redhat.com Subject: [libvirt PATCH] meson: remove obsolete comment about stack frame size Date: Thu, 8 Apr 2021 14:00:16 +0100 Message-Id: <20210408130016.478974-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) The virStrerror function no longer exists in libvirt so is not a constraint. At the current stack limit of 4k, and default Linux stack size of 8 MB, we have a recursion limit of 2048 in the absolute worst case, and much higher in common case. Even with smaller stack sizes, we're going to be fine as we don't deeply recurse in code. Thus it is not worth spending effort to optimize below our current 4k worst case limit. Removing the comment will stop encouraging people to spend time on this in future. Signed-off-by: Daniel P. Berrang=C3=A9 Reviewed-by: Pavel Hrdina --- meson.build | 3 --- 1 file changed, 3 deletions(-) diff --git a/meson.build b/meson.build index 97d9c52165..a521d148d5 100644 --- a/meson.build +++ b/meson.build @@ -409,9 +409,6 @@ cc_flags +=3D [ # but need to rewrite various areas of code first '-Wno-format-truncation', =20 - # This should be < 256 really. Currently we're down to 4096, - # but using 1024 bytes sized buffers (mostly for virStrerror) - # stops us from going down further '-Wframe-larger-than=3D4096', =20 # extra special flags --=20 2.30.2