From nobody Mon Feb 9 17:58:12 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) client-ip=63.128.21.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1617880933; cv=none; d=zohomail.com; s=zohoarc; b=IbxWM7lxnEmrr4jdpMmqygQHr/DzVSV8P/9o/TAOzz+o3nd99t1XhsnIcoCm7Ygnj4jcNQGxmHAE9J4JgR9/DJKHa9UwZeJ3NgvMJwZjXnWcvZEA9Wq1pNIFOl9qc2Tvo94ZyDAuNaceInodwkK4xGkjyiY2rqfEItJ1bKJygiU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1617880933; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=c4MTW3VSkR6FxyjOn5nGgLaKYLJo3EpuJNDThdgh+D4=; b=MdXaMQxVsaGjubyYMM4wHtVSsN+U7syHu3kdg5hDaa/1w4DMQZN/cSH/KHg5oO6gBMCeR3lr4tXr9IouIzF2YqWtzGKxeDKGxrnBQjejKnydeNGUtj/GTzYAZR3zYxkHG4/FdEGUr4EsaMyEqLg1tWMXILwx4Z+yqfle89gwxxc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.zohomail.com with SMTPS id 1617880933403724.51382608616; Thu, 8 Apr 2021 04:22:13 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-57-8igZK3aKOLqxFj5U5VANlw-1; Thu, 08 Apr 2021 07:20:39 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B82E6A40C3; Thu, 8 Apr 2021 11:20:33 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 90C645DAA5; Thu, 8 Apr 2021 11:20:33 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 415B51806D10; Thu, 8 Apr 2021 11:20:33 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 138BKVDo009572 for ; Thu, 8 Apr 2021 07:20:31 -0400 Received: by smtp.corp.redhat.com (Postfix) id E4B7F5171E; Thu, 8 Apr 2021 11:20:31 +0000 (UTC) Received: from work.redhat.com (ovpn-112-196.ams2.redhat.com [10.36.112.196]) by smtp.corp.redhat.com (Postfix) with ESMTP id E86FC5C5E1; Thu, 8 Apr 2021 11:20:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1617880932; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=c4MTW3VSkR6FxyjOn5nGgLaKYLJo3EpuJNDThdgh+D4=; b=XH7/Cu0h9/EbLTQzXPEynSWOyVNSZ6LT+W41L93TOqFs2Oic3FUmLlR75YaJ9263z4cXV4 FN1/qG3nrSzKrhcZ9IXnmkJCYBM2nfGji5LkHirWH6CU30vGgjPIW5EJSYyVAtHYQucq2F UPgbikAmon+PGJoQKvObY54lZe/Ci+8= X-MC-Unique: 8igZK3aKOLqxFj5U5VANlw-1 From: Tim Wiederhake To: libvir-list@redhat.com Subject: [libvirt PATCH v5 7/8] virDomainIOThreadIDDefParseXML: Use virXMLProp* Date: Thu, 8 Apr 2021 13:19:57 +0200 Message-Id: <20210408111958.32678-8-twiederh@redhat.com> In-Reply-To: <20210408111958.32678-1-twiederh@redhat.com> References: <20210408111958.32678-1-twiederh@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-loop: libvir-list@redhat.com Cc: Tim Wiederhake X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Signed-off-by: Tim Wiederhake Reviewed-by: Peter Krempa --- src/conf/domain_conf.c | 14 +++----------- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 1e72171586..fb22695dd3 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -18180,21 +18180,13 @@ static virDomainIOThreadIDDefPtr virDomainIOThreadIDDefParseXML(xmlNodePtr node) { virDomainIOThreadIDDefPtr iothrid; - g_autofree char *tmp =3D NULL; =20 iothrid =3D g_new0(virDomainIOThreadIDDef, 1); =20 - if (!(tmp =3D virXMLPropString(node, "id"))) { - virReportError(VIR_ERR_XML_ERROR, "%s", - _("Missing 'id' attribute in element")); - goto error; - } - if (virStrToLong_uip(tmp, NULL, 10, &iothrid->iothread_id) < 0 || - iothrid->iothread_id =3D=3D 0) { - virReportError(VIR_ERR_XML_ERROR, - _("invalid iothread 'id' value '%s'"), tmp); + if (virXMLPropUInt(node, "id", 10, + VIR_XML_PROP_REQUIRED | VIR_XML_PROP_NONZERO, + &iothrid->iothread_id) < 0) goto error; - } =20 return iothrid; =20 --=20 2.26.2