From nobody Mon Feb 9 07:23:31 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1617796139; cv=none; d=zohomail.com; s=zohoarc; b=b/Z/WX4C+U+Vfc9ZIoAd59+zAAe4xy/vWLTk6s50lwvrcRoD8EqGz2Wp/JYoJRwCgmLZ3JhOw4163WbCCLfT4xzZEwp/vP+qQsVBd2t0axpcmot8omoIktJFI5FWRutG2tvWNdmCQDuCl49Rvl39mAxxq6djdfmAOE1jdyrr/mo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1617796139; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=wz4oehQ22Br8i9SOimV+M5SR3yVgsXk6wxJIrF3jF5M=; b=Cs87PfJlCnmQKF8PPOipRSGL10t0gGBHenbQvzmmxDz7PnEJaXH2MPhwrdGQuVZbwAjIcTQhZIFl5sgMwVY08zc5NOS753LMpK2P4OF+pgXDdZUJrhl6ZmfiHwR7MDEgE73nWhlKw9I7KcXnBM5iFUNNCTy5IxzwVr7M960CB04= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1617796139521391.55355702598035; Wed, 7 Apr 2021 04:48:59 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-79-xgyZncUmN_mO6Q1liNHdew-1; Wed, 07 Apr 2021 07:48:56 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 249EBE99C1; Wed, 7 Apr 2021 11:48:50 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C0E8E5C1C4; Wed, 7 Apr 2021 11:48:48 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 3D2CB5533E; Wed, 7 Apr 2021 11:48:47 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 137BmjOM006707 for ; Wed, 7 Apr 2021 07:48:45 -0400 Received: by smtp.corp.redhat.com (Postfix) id 4B2F914108; Wed, 7 Apr 2021 11:48:45 +0000 (UTC) Received: from work.redhat.com (ovpn-113-23.ams2.redhat.com [10.36.113.23]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9153F608BA; Wed, 7 Apr 2021 11:48:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1617796138; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=wz4oehQ22Br8i9SOimV+M5SR3yVgsXk6wxJIrF3jF5M=; b=aecpmR2lwM7/zsilZLdOYhCa0t52XcLC1hICRHfS68QtVPOOp3OhF6JTWwvvPxGF5dYK65 pVTyhHU4nxA0v7xqCyrIBTnAf3mZKSY1tGMm4Fsoa7qMDuhox8G4yUTsMHrzYYuo9d0tCv zdGAshLhs/p6h8oUjaljlGxEjU7yN6g= X-MC-Unique: xgyZncUmN_mO6Q1liNHdew-1 From: Tim Wiederhake To: libvir-list@redhat.com Subject: [libvirt PATCH 02/14] conf: Use virTristateXXX in virStorageSourceNVMeDef Date: Wed, 7 Apr 2021 13:48:29 +0200 Message-Id: <20210407114841.85009-3-twiederh@redhat.com> In-Reply-To: <20210407114841.85009-1-twiederh@redhat.com> References: <20210407114841.85009-1-twiederh@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com Cc: Tim Wiederhake X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 4 +++- src/conf/storage_source_conf.h | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index b8f6c3d606..dfdca1891a 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -8480,12 +8480,14 @@ virDomainDiskSourceNVMeParse(xmlNodePtr node, } =20 if ((managed =3D virXMLPropString(node, "managed"))) { - if ((nvme->managed =3D virTristateBoolTypeFromString(managed)) <= =3D 0) { + int value; + if ((value =3D virTristateBoolTypeFromString(managed)) <=3D 0) { virReportError(VIR_ERR_XML_ERROR, _("malformed managed value '%s'"), managed); return -1; } + nvme->managed =3D value; } =20 if (!(address =3D virXPathNode("./address", ctxt))) { diff --git a/src/conf/storage_source_conf.h b/src/conf/storage_source_conf.h index e6702a1ffc..1783dc195e 100644 --- a/src/conf/storage_source_conf.h +++ b/src/conf/storage_source_conf.h @@ -251,7 +251,7 @@ typedef struct _virStorageSourceNVMeDef virStorageSourc= eNVMeDef; typedef virStorageSourceNVMeDef *virStorageSourceNVMeDefPtr; struct _virStorageSourceNVMeDef { unsigned long long namespc; - int managed; /* enum virTristateBool */ + virTristateBool managed; virPCIDeviceAddress pciAddr; =20 /* Don't forget to update virStorageSourceNVMeDefCopy */ --=20 2.26.2