From nobody Mon Feb 9 17:23:27 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1617796153; cv=none; d=zohomail.com; s=zohoarc; b=MxjmDDHs84BXH1U5t125ufCwj0M0MsCieyXUfkSvNU1t7jEDV74vvOvuNTAF4ajjI+E3RCS9JLfKFAZ5O00qMEWJeTRpw5rGA1An5PzozEG9zVdOSMWz7NU0AGEvshZNOHFCei+Z622Th1QYPjgDBkH/RO0LL37Vv/8FfYaF0qg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1617796153; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=j6ao+lUl8+yj08XuBPBwl7CQ/XHpPONWliVbz2VDPbA=; b=XGKVKY65NwkQGoaZg++vFk+oRp2Saw0HlXhiwF8Ag32zD8lWLKgBAewY3ZxdIpnPn5MIHaus8dNDMhv4JUZm6VwCAa56DCsxFrmwCU4OeyB8VbiARnT1BTzgxVpTF832wqyjq6/H2sbbMs4zgijZhZZEZHjb0QdTILMhYmpuOps= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1617796153238199.48670234208737; Wed, 7 Apr 2021 04:49:13 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-477-LS3YhApJMYWdKKmL-Chj0Q-1; Wed, 07 Apr 2021 07:49:10 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7C5E2107ACE4; Wed, 7 Apr 2021 11:49:03 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 385061690D; Wed, 7 Apr 2021 11:49:03 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id E775155344; Wed, 7 Apr 2021 11:49:02 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 137BmtO2006816 for ; Wed, 7 Apr 2021 07:48:55 -0400 Received: by smtp.corp.redhat.com (Postfix) id C6C4C14108; Wed, 7 Apr 2021 11:48:55 +0000 (UTC) Received: from work.redhat.com (ovpn-113-23.ams2.redhat.com [10.36.113.23]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1B64260C5C; Wed, 7 Apr 2021 11:48:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1617796152; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=j6ao+lUl8+yj08XuBPBwl7CQ/XHpPONWliVbz2VDPbA=; b=QyKJn9qA61jQYuZOYv0/6tPNGgvhRXX7Yn8fhLqOZ/1T05lDvjRSCY1phLZP0vUEWj10kg ip2vwE5S2ebp2j5GMDUJ0Pihfb7Qvapw1mVvjwmQgCbhZv+62+HN4LzZUfdknrCamVYAyx aHI+vliwdgz8xxp3xy9GgwrHHF+0wpA= X-MC-Unique: LS3YhApJMYWdKKmL-Chj0Q-1 From: Tim Wiederhake To: libvir-list@redhat.com Subject: [libvirt PATCH 12/14] conf: Use virTristateXXX in virStorageAdapterFCHost Date: Wed, 7 Apr 2021 13:48:39 +0200 Message-Id: <20210407114841.85009-13-twiederh@redhat.com> In-Reply-To: <20210407114841.85009-1-twiederh@redhat.com> References: <20210407114841.85009-1-twiederh@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com Cc: Tim Wiederhake X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Note that the comment for virStorageAdapterFCHost::managed was wrong. Signed-off-by: Tim Wiederhake --- src/conf/storage_adapter_conf.c | 4 +++- src/conf/storage_adapter_conf.h | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/conf/storage_adapter_conf.c b/src/conf/storage_adapter_con= f.c index 77ecb8d5f2..69062b4b58 100644 --- a/src/conf/storage_adapter_conf.c +++ b/src/conf/storage_adapter_conf.c @@ -68,13 +68,15 @@ virStorageAdapterParseXMLFCHost(xmlNodePtr node, =20 fchost->parent =3D virXMLPropString(node, "parent"); if ((managed =3D virXMLPropString(node, "managed"))) { - if ((fchost->managed =3D virTristateBoolTypeFromString(managed)) <= 0) { + int value; + if ((value =3D virTristateBoolTypeFromString(managed)) < 0) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, _("unknown fc_host managed setting '%s'"), managed); VIR_FREE(managed); return -1; } + fchost->managed =3D value; } =20 fchost->parent_wwnn =3D virXMLPropString(node, "parent_wwnn"); diff --git a/src/conf/storage_adapter_conf.h b/src/conf/storage_adapter_con= f.h index 4c7da7c8d9..3f64cda9af 100644 --- a/src/conf/storage_adapter_conf.h +++ b/src/conf/storage_adapter_conf.h @@ -51,7 +51,7 @@ struct _virStorageAdapterFCHost { char *parent_fabric_wwn; char *wwnn; char *wwpn; - int managed; /* enum virTristateSwitch */ + virTristateBool managed; }; =20 typedef struct _virStorageAdapter virStorageAdapter; --=20 2.26.2