[libvirt PATCH] run: fix spawning of daemons

Daniel P. Berrangé posted 1 patch 1 week ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20210406144143.300252-1-berrange@redhat.com
run.in | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

[libvirt PATCH] run: fix spawning of daemons

Posted by Daniel P. Berrangé 1 week ago
The "args" array already contains the binary name, so does not need to
be concatenated with "prog".

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 run.in | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/run.in b/run.in
index b778505a33..9aae27a79e 100644
--- a/run.in
+++ b/run.in
@@ -159,8 +159,8 @@ else:
 
             stopped_units.append(unit)
 
-        print("Running %s..." % prog)
-        ret = subprocess.call([prog] + args, env=env)
+        print("Running '%s'..." % str(" ".join(args)))
+        ret = subprocess.call(args, env=env)
     except KeyboardInterrupt:
         pass
     finally:
-- 
2.30.2

Re: [libvirt PATCH] run: fix spawning of daemons

Posted by Andrea Bolognani 6 days, 23 hours ago
On Tue, 2021-04-06 at 15:41 +0100, Daniel P. Berrangé wrote:
> The "args" array already contains the binary name, so does not need to
> be concatenated with "prog".
> 
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
>  run.in | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Andrea Bolognani <abologna@redhat.com>

-- 
Andrea Bolognani / Red Hat / Virtualization