From nobody Fri Apr 19 07:19:56 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) client-ip=63.128.21.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=quarantine dis=quarantine) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1617297076; cv=none; d=zohomail.com; s=zohoarc; b=nvGXDFS1XSKcrZr5mZGcWZJrJwb1IMxOo6LN5XUiufNGtmZW7FzzwYip9Qce8Mupso2aK9MR/nPwCcCacDo2puTT3tLY3tNJTjfvSy+QKNaQgSRSKlFpLB9/qrdvAUI2lb0TdT3InyB4PlJlyFNQZPxz2TaCcaX9HSOWk1gca4k= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1617297076; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=5ZuOjehUhtqGKNqTIjY+CYaju1/qGhvaX8sc7c2/+io=; b=Mb4K5rxGVjb9N6w+yN2kYBOdtnQSFAdSIQu8tO7uSfeNyU8ih0l6MjZ/8d1ZTSndda+4h4NzrDuaKuwO1VCYELlI2QQomA+B6mZfUYaM+dVdUho/5dq9UiZVwBOmJWU3l2Wq4Vz6lWyPojpOFo/xtWcrJXzUeAsGiYg/UFWi1Ko= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail header.from= (p=quarantine dis=quarantine) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.zohomail.com with SMTPS id 1617297076758577.9197556358238; Thu, 1 Apr 2021 10:11:16 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-502-kjnDjvUlM_C4m4mOAUPUJg-1; Thu, 01 Apr 2021 13:11:13 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 99B60814256; Thu, 1 Apr 2021 17:11:06 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6DD0259468; Thu, 1 Apr 2021 17:11:05 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id B5E7F1809C83; Thu, 1 Apr 2021 17:11:00 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 131HAwNC014267 for ; Thu, 1 Apr 2021 13:10:58 -0400 Received: by smtp.corp.redhat.com (Postfix) id 23CD72026D6B; Thu, 1 Apr 2021 17:10:58 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast03.extmail.prod.ext.rdu2.redhat.com [10.11.55.19]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1DE8D2026D64 for ; Thu, 1 Apr 2021 17:10:54 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id CDD32811E7F for ; Thu, 1 Apr 2021 17:10:54 +0000 (UTC) Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [62.140.7.102]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-570-yjD5RA1NNI-a8XsI0tUs9Q-1; Thu, 01 Apr 2021 13:10:52 -0400 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05lp2175.outbound.protection.outlook.com [104.47.17.175]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-20-xP3-CZOxMUynK1oVG9l4Qw-1; Thu, 01 Apr 2021 19:10:50 +0200 Received: from AM8PR04MB7970.eurprd04.prod.outlook.com (2603:10a6:20b:24f::9) by AM0PR04MB6210.eurprd04.prod.outlook.com (2603:10a6:208:13b::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3999.27; Thu, 1 Apr 2021 17:10:50 +0000 Received: from AM8PR04MB7970.eurprd04.prod.outlook.com ([fe80::8532:12af:9c2:66ca]) by AM8PR04MB7970.eurprd04.prod.outlook.com ([fe80::8532:12af:9c2:66ca%7]) with mapi id 15.20.3999.028; Thu, 1 Apr 2021 17:10:49 +0000 Received: from linux-tbji.devlab.prv.suse.com (75.169.51.246) by AM0PR01CA0092.eurprd01.prod.exchangelabs.com (2603:10a6:208:10e::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3999.26 via Frontend Transport; Thu, 1 Apr 2021 17:10:48 +0000 X-MC-Unique: kjnDjvUlM_C4m4mOAUPUJg-1 X-MC-Unique: yjD5RA1NNI-a8XsI0tUs9Q-1 X-MC-Unique: xP3-CZOxMUynK1oVG9l4Qw-1 From: Jim Fehlig To: libvir-list@redhat.com Subject: [PATCH] tests: Fix qemuxml2xmltest with audio driver defined in env Date: Thu, 1 Apr 2021 11:10:28 -0600 Message-ID: <20210401171028.29448-1-jfehlig@suse.com> X-Originating-IP: [75.169.51.246] X-ClientProxiedBy: AM0PR01CA0092.eurprd01.prod.exchangelabs.com (2603:10a6:208:10e::33) To AM8PR04MB7970.eurprd04.prod.outlook.com (2603:10a6:20b:24f::9) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 72e06209-3d65-4f14-4f68-08d8f5311903 X-MS-TrafficTypeDiagnostic: AM0PR04MB6210: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7219 X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0 X-Microsoft-Antispam-Message-Info: 4fxr/QdZISwN/vGAR6+nRM0FUfmUMGtZr6MAOhuoXjTeFnDmAIlDnKIOnNxSqwYLlsKeHDb45KYt7WUks1Zlsrrd7zuJ3+2EJoClhm3/LOQqIVzOAfghFfUU0+taQxN2ghDc3sAWLPLHqrNDnOQPL383K1xb5dLKBhuhFF36y0+06HwoXzhvrv3W3/VUAIMpRoFfyk5K5Vb5tPIn8XSmiuS/+UkrFP585Zq/FJdKR0SkrSc6ZbYiR8Aaw4ImTQio3OI5XTB0y/IjVejMYXZudWGZsq8ORBvWFWCRUWTUnjUpzJDn5ofARIdVzrP0YaJWuCmp09l4TdsxvwsMgff8yiUc2sFzkSvBXg9RhYDsaVpla4ExfTgDGuZgeTmwUqW5GFVILU/wDtEGkkH3BAEvVFH7h0lgfeCkFtzVTZGS86KlWByI9ZKjJQL4ljXTu00HdUSh5+Mg401XZDU9nqY6RKG661djcj7Ryafrxre2Rc1Qm5mYFI1iyRttiQiLAK0TFib4SqllSab9441t2eToA1w10rAjeUPepAil7nhxFGZ+Hf23d+04pMPOS1POE/FTK1ccZDEWxhIE7pGH+3sR8gdd5ogo6TzE6XYAkZczTQqr0x2nQAdLUk20bR7Pgw2hKIh3iIyG3ERbRzBHyfUsgw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM8PR04MB7970.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(346002)(376002)(366004)(136003)(396003)(39860400002)(6486002)(66946007)(4326008)(186003)(36756003)(83380400001)(38100700001)(107886003)(7696005)(86362001)(52116002)(26005)(66476007)(1076003)(66556008)(16526019)(5660300002)(6666004)(2906002)(6916009)(8676002)(956004)(2616005)(8936002)(316002)(478600001); DIR:OUT; SFP:1101 X-MS-Exchange-AntiSpam-MessageData: =?us-ascii?Q?ss2JQDiLWqnzr9kFTD6FGgqhlBeONIyfBg/osTvoW0h9jMncZJ+p2U1TABL0?= =?us-ascii?Q?IgS2F+g9u9sUHYose5uwBZYwsnTlJtnRA16Oo8htV4VvmM7j0xl/Rd291gbh?= =?us-ascii?Q?H1vdeJbbGGa9kO/6gDcTFNNv3QsHDjo+t0k22Cs6YWhwuJvs9/808+VweqSF?= =?us-ascii?Q?Vy2Yvfi2anwT9OJRC6LwQ2H9dRZVO1ltLJzPELjjZK7THFOaHv+WwsTcgPTP?= =?us-ascii?Q?F6gi8BpCdZt+xbI1snjU3l6MVVxkc6pQA0uMeo10RceFU3izXAmLf4dp/aKm?= =?us-ascii?Q?k7UF1wzbtzWGHH7wub+ZG/qvfYMxj2KAuzBnfDarVwYdcJDZvAcP97Fyw8X0?= =?us-ascii?Q?+qHYNo9NNs72kXjhDUWx0tfTx1fNJo2ZLqx3dVcgH5GcsIvAlbYttFHnMvMh?= =?us-ascii?Q?ltXxda4j4kXDB8OzYAYAiHShl8yw4ezMymejzL7lGpOM1O/vxEyINx5+cBPw?= =?us-ascii?Q?tna85SBQX3HQ3tcc+0iw4ZtMPhrWT3iUBqW6PejyhEXK07yuBQeLVGcWpRbK?= =?us-ascii?Q?Yr3DLEq2lkbel16cSCeP96niqsypUUr38yKx+tu6u/yhtjmwX+1uw7xCO48f?= =?us-ascii?Q?q3xamdlUllI/i7qlVxG7kXt+bO0gCVRiWhTkn23CzmmAwD7lzIJDL+M/AOGn?= =?us-ascii?Q?R8VX1LDsJnpE8m8zee8/Up7NhmAkDfFGpl0vprZ4khlZsclt/HXQQuuVeKM+?= =?us-ascii?Q?ydt+4ZZDJ8uYzMadHxrWfyGkqbid2hzyJcYWSMBM8aGFZfiBG0iuuqnJt/dX?= =?us-ascii?Q?kARSI+1A0oW4tVBu8IZIKBRkCDFVXQ570QcChqwkle32112mjddcesvXpZQV?= =?us-ascii?Q?jJzwYFqZmhXGQlVcAqDP7I40oc3dZOmsIV44G2T5pWgZ3sXuFAdZtcT6g0h1?= =?us-ascii?Q?HA7qNFTBmIGym4O8n5f5CWtZtA7JwDPFNp5a63GyKqai8DAhuXSxw4JRDgI1?= =?us-ascii?Q?TDt3o0YIN8HT6ASMOt79Q+0S8hmx/FvxaUf7l+NEnqmUXadO9K5e4RjRhVf/?= =?us-ascii?Q?tmjj6UBiM5Pz/I6TE1TsHYAPuS77BiiJ1b0hfSCWTkNeRYnu1LzP9PBYLn+i?= =?us-ascii?Q?WPzfBIER0QFPXQ6RlY5muJL6GKSZzhUUG88z4ifV4ddg+73il1Ai4W1kATiO?= =?us-ascii?Q?4t5bloN8kk4BX6KQDph/5eTERn6n+nZeDZio5OftHleYWN2dIkhb9BzQNzD8?= =?us-ascii?Q?et8q2o/ersVit9cmFjNhLb+t74Z/vgRcW70nqhenej74Pnw2I5Odh9h9eTNL?= =?us-ascii?Q?6FqxaNq8+dFt0gXPNnX0ueHIvLTexMJhFOWGYRFsKwqT4+vNgb3EoP7Z1x+u?= =?us-ascii?Q?6iv7xo3OH4sscvm7VB0jeaCJ?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 72e06209-3d65-4f14-4f68-08d8f5311903 X-MS-Exchange-CrossTenant-AuthSource: AM8PR04MB7970.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Apr 2021 17:10:49.7582 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ndmoz7XKmpJXrUHQmHTMTZcCbdmRvfmck6WjWalhwm6LaIqFpQtgkKgGQkc8LdaUupOqkdbGPqNYXL2fI9xURw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6210 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-MIME-Autoconverted: from quoted-printable to 8bit by lists01.pubmisc.prod.ext.phx2.redhat.com id 131HAwNC014267 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" If QEMU_AUDIO_DRV is defined in the build host environment, several tests in qemuxml2xmltest fail. $ env | grep -i audio AUDIODRIVER=3Dpulseaudio QEMU_AUDIO_DRV=3Dpa SDL_AUDIODRIVER=3Dpulse An example test failure with the above environment 907) QEMU XML-2-XML-active video-virtio-gpu-sdl-gl In 'libvirt/tests/qemuxml2xmloutdata/video-virtio-gpu-sdl-gl.xml': Offset 1244 Expect [v] Actual [audio id=3D'1' type=3D'pulseaudio'/> --- On IRC Daniel suggested scrubbing QEM_AUDIO_DRV and SDL_AUDIODRIVER. Only QEM_AUDIO_DRV was needed to fix the test failure, but I can scrub the other one too if that's preferred. tests/qemuxml2xmltest.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/qemuxml2xmltest.c b/tests/qemuxml2xmltest.c index 137f1871af..aff6ae9175 100644 --- a/tests/qemuxml2xmltest.c +++ b/tests/qemuxml2xmltest.c @@ -198,6 +198,7 @@ mymain(void) * using ADD_ENV_COPY, otherwise these tests may fail due to unexpected * values for these envvars */ g_setenv("PATH", "/bin", TRUE); + g_unsetenv("QEMU_AUDIO_DRV"); =20 DO_TEST("minimal", NONE); DO_TEST_CAPS_LATEST("genid"); --=20 2.30.1