From nobody Mon Feb 9 12:09:01 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) client-ip=63.128.21.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1616633764; cv=none; d=zohomail.com; s=zohoarc; b=k5+dH56Zh/JOC8VQw4s36alXE5bnKJcvZS/VdfzvzlozLniV8xAfiZVIn9aYQcMeybjH1qZ1Dgl+qdCW1RQQ1N2X0IfioCk61ICX6qjGXti0LxddQI/RKbAgtYimaUuyHIcjhvo4ytvlJb0DYMSmR4cUEKl7gniJMi8voAfnEaQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1616633764; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=+F5bU/LOip7Hh79Z2fO1m8/I1HkGp4SSNkY1MsNEg6I=; b=WDn8qKNRTXa2EM6ucMUkIjbA48j4a5rcIe/YykHDryM057N2DQs4l+kGnWmOBVMUc5nCHwZ8mxlZ7dTXzeaaK+kSgVOnHPa8Hvi/UuTt7YL2LvVVdRgZlLNXoD7EUDSZWFAtoxPOOsOM5/hlJ2SAVxqjTN/frxb6rnEHyfvVghs= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.zohomail.com with SMTPS id 1616633764260357.9741293589278; Wed, 24 Mar 2021 17:56:04 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-161-uIGWji1tNaiDSIeHygElNw-1; Wed, 24 Mar 2021 20:55:38 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D7D9E80364C; Thu, 25 Mar 2021 00:55:29 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id AB6C61971B; Thu, 25 Mar 2021 00:55:29 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 3D7D6180B451; Thu, 25 Mar 2021 00:55:29 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 12P0t8qN024599 for ; Wed, 24 Mar 2021 20:55:09 -0400 Received: by smtp.corp.redhat.com (Postfix) id C4F552026D6B; Thu, 25 Mar 2021 00:55:08 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast02.extmail.prod.ext.rdu2.redhat.com [10.11.55.18]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BDF612026D6A for ; Thu, 25 Mar 2021 00:55:06 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 65D1E80231F for ; Thu, 25 Mar 2021 00:55:06 +0000 (UTC) Received: from mail-qv1-f51.google.com (mail-qv1-f51.google.com [209.85.219.51]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-244-SHxpThRlMqychOBa-4v5Zg-1; Wed, 24 Mar 2021 20:55:04 -0400 Received: by mail-qv1-f51.google.com with SMTP id q9so367671qvm.6 for ; Wed, 24 Mar 2021 17:55:04 -0700 (PDT) Received: from localhost (209-6-122-159.s2973.c3-0.arl-cbr1.sbo-arl.ma.cable.rcncustomer.com. [209.6.122.159]) by smtp.gmail.com with ESMTPSA id z24sm3043993qkz.65.2021.03.24.17.55.03 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 24 Mar 2021 17:55:03 -0700 (PDT) X-MC-Unique: uIGWji1tNaiDSIeHygElNw-1 X-MC-Unique: SHxpThRlMqychOBa-4v5Zg-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=+F5bU/LOip7Hh79Z2fO1m8/I1HkGp4SSNkY1MsNEg6I=; b=VJtq6fg4dQtE9jv9SrckZab6Zv4B4PSJj6dY6JdEZtDrdKw1DnR98Q/Z0cVZwEtFtP CPntAKRMgvbKVYyCZmfSWwGfASzc3a/jeOKHWBXuknt946woheYBtQ5c8euKAQx9m3oJ MHALW27qZ2db29t+I8mdMKlrK/NrEtbhQMyq56ZCbd8uSaA5zwPi396QwVOpxZDr85yE Ke+vaISB9ontL9WRUlEKxIaNtpms/1zNLDnFMnNLDwGBhovkv5RR0q/+L+fyUjbyCyU1 mqSD6ai4FFVeMUrzIcWQPp5tDoCNL6+e7uD7XQS5i39tZWY+JJ30w7pUI3P5zRz464aN qlxw== X-Gm-Message-State: AOAM532fcmOCVXlLCgrV73pZUt7mpyARHQBMD5S0YAMTRxv3KbFrvUXx 2c+sVnr4Ytdsciuk0N66GHxp2yhwUA== X-Google-Smtp-Source: ABdhPJxO7E/X4m55P2BsU1DnrfT39ihdorIstcgj9Db+ATYpIPxht6WlxuHJL4if0Dcrb9jgdfVs9A== X-Received: by 2002:a0c:a909:: with SMTP id y9mr5851043qva.20.1616633703748; Wed, 24 Mar 2021 17:55:03 -0700 (PDT) From: Masayoshi Mizuma To: libvir-list@redhat.com Subject: [PATCH 07/10] WIP: qemu_snapshot: Add the guest name to the transient disk path Date: Wed, 24 Mar 2021 20:54:11 -0400 Message-Id: <20210325005414.275401-8-msys.mizuma@gmail.com> In-Reply-To: <20210325005414.275401-1-msys.mizuma@gmail.com> References: <20210325005414.275401-1-msys.mizuma@gmail.com> MIME-Version: 1.0 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-loop: libvir-list@redhat.com Cc: Masayoshi Mizuma , Masayoshi Mizuma X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Masayoshi Mizuma Add the guest name to the transient disk path name to match the path of transient disks for hotplugging. Signed-off-by: Masayoshi Mizuma --- src/qemu/qemu_snapshot.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_snapshot.c b/src/qemu/qemu_snapshot.c index 93b74b035a..a5cc0d47f2 100644 --- a/src/qemu/qemu_snapshot.c +++ b/src/qemu/qemu_snapshot.c @@ -1195,7 +1195,8 @@ qemuSnapshotDiskPrepareDisksTransient(virDomainObjPtr= vm, snapdisk->src =3D virStorageSourceNew(); snapdisk->src->type =3D VIR_STORAGE_TYPE_FILE; snapdisk->src->format =3D VIR_STORAGE_FILE_QCOW2; - snapdisk->src->path =3D g_strdup_printf("%s.TRANSIENT", domdisk->s= rc->path); + snapdisk->src->path =3D g_strdup_printf("%s.TRANSIENT-%s", + domdisk->src->path, vm->def->name); =20 if (virFileExists(snapdisk->src->path)) { virReportError(VIR_ERR_OPERATION_UNSUPPORTED, --=20 2.27.0