From nobody Mon Feb 9 23:00:12 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1616429445; cv=none; d=zohomail.com; s=zohoarc; b=b4JrT/1ERsn4fqMk7qyEkMF5YWFM7bDtiSz0itdWlCyokNw0B9BzFkMvTwnVd9ek91srUbq04I/NwChUaKSjMmQkaEGCpVXsmkEm/6smDN9JP3VMQHmBMvhNec5eIXCV57DVjHJl5TxcGSfBvKg0YHfPdGqbuSMAQhGXWyqdqeA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1616429445; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=104hfUg1pHYfNYYqHExiUdCYcBuvOUVaXMH/g3r43rk=; b=c2ukmFhXKrYZnYlzRf6iihiklnEZ/mR8UVxQxz0hc9G9p34tCmJihjJ4jmnvnc97TpkqYE8GJA0MNW4QpfWjV2JiLq6Ms1KUTEq7uTQqXfGRfG1ziVzzJ/36rmCMHX7yCSPXNRil7NastdnunOUh97cppdXEQjcq0xPBFS+YEHI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1616429444904647.6713659693132; Mon, 22 Mar 2021 09:10:44 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-262-QMuR9KTwNzKtZNNmEMPWXg-1; Mon, 22 Mar 2021 12:10:32 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 00073108BD06; Mon, 22 Mar 2021 16:10:25 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B56DA1F067; Mon, 22 Mar 2021 16:10:25 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 49F034A700; Mon, 22 Mar 2021 16:10:25 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 12MGAHcV010552 for ; Mon, 22 Mar 2021 12:10:17 -0400 Received: by smtp.corp.redhat.com (Postfix) id E04CE50A8A; Mon, 22 Mar 2021 16:10:17 +0000 (UTC) Received: from work.redhat.com (ovpn-112-246.ams2.redhat.com [10.36.112.246]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2E9C919CBA; Mon, 22 Mar 2021 16:10:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1616429435; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=104hfUg1pHYfNYYqHExiUdCYcBuvOUVaXMH/g3r43rk=; b=B6V2qIsDlR3guYe9JqYXReIhoaAolr8KXyl/SuCZ4BVPrsC7t+OXgCdQbuAy5A4S86PtBU SeAq7/+Vn2xkmnJ36tI3GN2MMXCpllKqKQEGomXAur4h5wJUdSxoBabLGnT7vusrlOuWH0 OPmT+GIJp8V337EpQlUsV1MoVQRHjq0= X-MC-Unique: QMuR9KTwNzKtZNNmEMPWXg-1 From: Tim Wiederhake To: libvir-list@redhat.com Subject: [libvirt PATCH 5/5] vsh: secret-set-value: Mark '--base64' as deprecated Date: Mon, 22 Mar 2021 17:10:04 +0100 Message-Id: <20210322161004.145555-6-twiederh@redhat.com> In-Reply-To: <20210322161004.145555-1-twiederh@redhat.com> References: <20210322161004.145555-1-twiederh@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: libvir-list@redhat.com Cc: Tim Wiederhake X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Signed-off-by: Tim Wiederhake --- tools/virsh-secret.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tools/virsh-secret.c b/tools/virsh-secret.c index 7ca3e864da..5a1c4d7bf6 100644 --- a/tools/virsh-secret.c +++ b/tools/virsh-secret.c @@ -192,6 +192,7 @@ static const vshCmdOptDef opts_secret_set_value[] =3D { }, {.name =3D "base64", .type =3D VSH_OT_STRING, + .flags =3D VSH_OFLAG_DEPRECATED, .help =3D N_("base64-encoded secret value") }, {.name =3D NULL} @@ -225,8 +226,6 @@ cmdSecretSetValue(vshControl *ctl, const vshCmd *cmd) return false; =20 if (base64) { - /* warn users that the --base64 option passed from command line is= wrong */ - vshError(ctl, _("Passing secret value as command-line argument is = insecure!")); secret_val =3D g_strdup(base64); secret_len =3D strlen(secret_val); } else if (filename) { --=20 2.26.2