From nobody Sat May 4 02:07:17 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1616429428; cv=none; d=zohomail.com; s=zohoarc; b=fUovTwL5gUWKoVxlXbC6RRDkzeHurfgTGjEngY4jQDQY1nvXRPCliLDAE8yK2cfyss/9qYqMuxOXGs8uJxvH/lkmUQpo+QF142gQGudAdI6iWjcdK88TriM/jrqLN+/11gAOcAHqJoIRAeEmjE10J+0hOIEVymHCWZEvWnbL+64= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1616429428; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=I+N2Lji9KfDV3TWlLQx03yNPswBLlGe8zzK3q7D60R4=; b=kLiaV4mGuOMRDebkesUJsKIlrRAeUs2+T1RUBtWB+/rOKp3blosCjHIzQEvvwNqpshxQdvSMUlTTvYrwyaRMRymcaHKJ5UQGEL2JzkXC+YRuulNX1vkKY/fYhuCi0dihDOFVKzfxJBuk100bqCLSfcGkxhs7uidj+1v1kt/yfJ4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1616429428967648.0521871013848; Mon, 22 Mar 2021 09:10:28 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-163-2kWPu_I6PGGVN8GoEEozNw-1; Mon, 22 Mar 2021 12:10:23 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id EBD48190A7A6; Mon, 22 Mar 2021 16:10:16 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9667917195; Mon, 22 Mar 2021 16:10:16 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 0B29C1800848; Mon, 22 Mar 2021 16:10:16 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 12MGADLY010517 for ; Mon, 22 Mar 2021 12:10:13 -0400 Received: by smtp.corp.redhat.com (Postfix) id 379DD2DACE; Mon, 22 Mar 2021 16:10:13 +0000 (UTC) Received: from work.redhat.com (ovpn-112-246.ams2.redhat.com [10.36.112.246]) by smtp.corp.redhat.com (Postfix) with ESMTP id 76E7E5946B; Mon, 22 Mar 2021 16:10:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1616429426; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=I+N2Lji9KfDV3TWlLQx03yNPswBLlGe8zzK3q7D60R4=; b=bKfsh66YYva1r/5Zh7UmixHgZu6i96+LMXP4nsFVaN2czaP0bIN7lcCp5sC/luRgbu+aNr in82qTemqzSe9dbuQgypTWU9WZCULtZgMIKfWRnp2fUFWOrDmvzJaoeZSfNWP8cEBm8zjo sSfiCDHBMREcHo4b/L5Idj86+5Zapks= X-MC-Unique: 2kWPu_I6PGGVN8GoEEozNw-1 From: Tim Wiederhake To: libvir-list@redhat.com Subject: [libvirt PATCH 1/5] vsh: Set default log level to "warning" Date: Mon, 22 Mar 2021 17:10:00 +0100 Message-Id: <20210322161004.145555-2-twiederh@redhat.com> In-Reply-To: <20210322161004.145555-1-twiederh@redhat.com> References: <20210322161004.145555-1-twiederh@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: libvir-list@redhat.com Cc: Tim Wiederhake X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Signed-off-by: Tim Wiederhake --- tools/vsh.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/vsh.h b/tools/vsh.h index 39f70913fe..e83e0eca9e 100644 --- a/tools/vsh.h +++ b/tools/vsh.h @@ -60,7 +60,7 @@ typedef enum { VSH_ERR_ERROR } vshErrorLevel; =20 -#define VSH_DEBUG_DEFAULT VSH_ERR_ERROR +#define VSH_DEBUG_DEFAULT VSH_ERR_WARNING =20 /* * virsh command line grammar: --=20 2.26.2 From nobody Sat May 4 02:07:17 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) client-ip=63.128.21.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1616429425; cv=none; d=zohomail.com; s=zohoarc; b=bJujeSvz58Dn62i1dtgqamHYzw8NgTqPS3ipbeLPT+Qm3hYO9JZhdbSXwXw62jvZdca3h/mSyuAqy02BBX2eWKBkQqyUYLgzUBLRzL86AFkvWN79p1UjyqNKfFJdgBAuv9TsRX4bhpI6xP/w1MbjWVSbYcHftfmIPS2S2+KRets= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1616429425; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=NWireD3W+eaNCFphYxAJHzfK24K66X3IvbklDA+/28Y=; b=ng5Yqkw1RHihjdNQ4x/TDqPaFsgoN2Otg6Pd8n/A4OzTbXlVG8yIFTIo670Y6mmolgNEgoPANUAgWoN9V1o7sRvfJxys/b4AU5of9fpxq9tx7A+WW+yL68F3RWXCys1cqfK6dZdTQZnQ0/lNpibYrWaC0WtEPXLQrhZY4i5BpbU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.zohomail.com with SMTPS id 1616429425693325.1374578961776; Mon, 22 Mar 2021 09:10:25 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-490-y0oz_1svNnyFxbXOkroSHw-1; Mon, 22 Mar 2021 12:10:22 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 774C6107ACCD; Mon, 22 Mar 2021 16:10:16 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EE5B91042B4C; Mon, 22 Mar 2021 16:10:15 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 8EF291800216; Mon, 22 Mar 2021 16:10:15 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 12MGAEMW010526 for ; Mon, 22 Mar 2021 12:10:14 -0400 Received: by smtp.corp.redhat.com (Postfix) id 4B21E19CBA; Mon, 22 Mar 2021 16:10:14 +0000 (UTC) Received: from work.redhat.com (ovpn-112-246.ams2.redhat.com [10.36.112.246]) by smtp.corp.redhat.com (Postfix) with ESMTP id 89EC52DACE; Mon, 22 Mar 2021 16:10:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1616429424; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=NWireD3W+eaNCFphYxAJHzfK24K66X3IvbklDA+/28Y=; b=gFVmxKVLS4tYtMcEzD4/EqF9ka9lOfVib/2S7KWT1j9zEAWyOeepaqChs3S0Euz4In6oyY EwWxf7Y9sv9hoz5SbuplWCDToPkgILLXRWgUUtZs1cdCyVbEJWFgH3wn2FJdHgN/pw4BrZ biivhJqekStXH3C3/ZJrIGBkFylZS0g= X-MC-Unique: y0oz_1svNnyFxbXOkroSHw-1 From: Tim Wiederhake To: libvir-list@redhat.com Subject: [libvirt PATCH 2/5] vsh: Introduce flag for deprecated options Date: Mon, 22 Mar 2021 17:10:01 +0100 Message-Id: <20210322161004.145555-3-twiederh@redhat.com> In-Reply-To: <20210322161004.145555-1-twiederh@redhat.com> References: <20210322161004.145555-1-twiederh@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: libvir-list@redhat.com Cc: Tim Wiederhake X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Signed-off-by: Tim Wiederhake --- tools/vsh.c | 11 +++++++++-- tools/vsh.h | 9 +++++---- 2 files changed, 14 insertions(+), 6 deletions(-) diff --git a/tools/vsh.c b/tools/vsh.c index 8fb033249e..8b58db8896 100644 --- a/tools/vsh.c +++ b/tools/vsh.c @@ -321,7 +321,8 @@ vshCmddefCheckInternals(vshControl *ctl, char *name =3D (char *)opt->help; /* cast away const */ char *p; =20 - if (opt->flags || !opt->help) { + if ((opt->flags !=3D 0 && opt->flags !=3D VSH_OFLAG_DEPRECATED= ) || + !opt->help) { vshError(ctl, _("parameter '%s' of command '%s' has incorr= ect alias option"), opt->name, cmd->name); return -1; /* alias options are tracked by the original na= me */ @@ -442,6 +443,11 @@ vshCmddefGetOption(vshControl *ctl, const vshCmdDef *c= md, const char *name, const vshCmdOptDef *opt =3D &cmd->opts[i]; =20 if (STREQ(opt->name, name)) { + if (report && (opt->flags & VSH_OFLAG_DEPRECATED)) { + vshDebug(ctl, VSH_ERR_WARNING, + _("Warning: Option '%s' is deprecated\n"), name); + } + if (opt->type =3D=3D VSH_OT_ALIAS) { char *value; =20 @@ -697,7 +703,8 @@ vshCmddefHelp(const vshCmdDef *def) continue; } =20 - fprintf(stdout, " %-15s %s\n", buf, _(opt->help)); + fprintf(stdout, " %-15s %s%s\n", buf, _(opt->help), + opt->flags & VSH_OFLAG_DEPRECATED ? " (deprecated)" : = ""); } } fputc('\n', stdout); diff --git a/tools/vsh.h b/tools/vsh.h index e83e0eca9e..e85206b726 100644 --- a/tools/vsh.h +++ b/tools/vsh.h @@ -98,10 +98,11 @@ typedef enum { * Command Option Flags */ enum { - VSH_OFLAG_NONE =3D 0, /* without flags */ - VSH_OFLAG_REQ =3D (1 << 0), /* option required */ - VSH_OFLAG_EMPTY_OK =3D (1 << 1), /* empty string option allowed */ - VSH_OFLAG_REQ_OPT =3D (1 << 2), /* --optionname required */ + VSH_OFLAG_NONE =3D 0, /* without flags */ + VSH_OFLAG_REQ =3D (1 << 0), /* option required */ + VSH_OFLAG_EMPTY_OK =3D (1 << 1), /* empty string option allowed */ + VSH_OFLAG_REQ_OPT =3D (1 << 2), /* --optionname required */ + VSH_OFLAG_DEPRECATED =3D (1 << 3), /* option is deprecated */ }; =20 /* forward declarations */ --=20 2.26.2 From nobody Sat May 4 02:07:17 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1616429436; cv=none; d=zohomail.com; s=zohoarc; b=mw4DC2j3Qibt0IcurbwIjikIBwPCxv8e1ArW1mO9U6PGSfrBLll/2Yr+M71GkoH6Rdm5Sh4T+W/+AmJ4uGLjXFfJb2FS+UKaaXkReW9PXX80lzAyXChTGcwjXMuJkwhMBGpFpkp0vnhhzzFap6o3jLltV1jbvGWDV554cUkUuuk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1616429436; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Pg1sjH2C3C2nD0QQbXQbzijbWWK0UWiQ1c1EQLBfGX4=; b=KwUUSHnqTUPBauC08mbE/2sVKQuBC65DdqAnSHvLfGCY5eKFkkecEOi0L5/p2XcDDUG7ytr0PQ2s7w9lYDlqait+0fQQdltkRa1eQzL/WUr0jsjoRkjRh9c/soduvSqW9BDOyIiQGGgQw6R4G6EIeUO0SofxXXyADZgbHjy9QNQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1616429436305333.249393913528; Mon, 22 Mar 2021 09:10:36 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-597-Ojl1XEsCMMq5NYpXUcocHQ-1; Mon, 22 Mar 2021 12:10:31 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4A38B190A7A4; Mon, 22 Mar 2021 16:10:22 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 24CF05B4A1; Mon, 22 Mar 2021 16:10:22 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id DBA424A7C9; Mon, 22 Mar 2021 16:10:21 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 12MGAF02010532 for ; Mon, 22 Mar 2021 12:10:15 -0400 Received: by smtp.corp.redhat.com (Postfix) id 61C2D2DACE; Mon, 22 Mar 2021 16:10:15 +0000 (UTC) Received: from work.redhat.com (ovpn-112-246.ams2.redhat.com [10.36.112.246]) by smtp.corp.redhat.com (Postfix) with ESMTP id A5DE019CBA; Mon, 22 Mar 2021 16:10:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1616429435; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=Pg1sjH2C3C2nD0QQbXQbzijbWWK0UWiQ1c1EQLBfGX4=; b=KnziPtugFOonhihPr/YVrGnxJbtF7cbcyBhcK7zS/Q3pfzGCWLhoTa1LDWN4Fm6qObAux8 ENd7JLLImvfFN5xjJUStX7QRjUmKWdkWF1DJVht/OMHQwyMDbt01ra+Nw7aFF5z53q+/+d /IuSu5r7HBG8EV+cxHG4B0NGD6L4nYc= X-MC-Unique: Ojl1XEsCMMq5NYpXUcocHQ-1 From: Tim Wiederhake To: libvir-list@redhat.com Subject: [libvirt PATCH 3/5] vsh: setmem: Mark '--kilobytes' as deprecated Date: Mon, 22 Mar 2021 17:10:02 +0100 Message-Id: <20210322161004.145555-4-twiederh@redhat.com> In-Reply-To: <20210322161004.145555-1-twiederh@redhat.com> References: <20210322161004.145555-1-twiederh@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: libvir-list@redhat.com Cc: Tim Wiederhake X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Signed-off-by: Tim Wiederhake --- tools/virsh-domain.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 7db88f700a..32bd048d26 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -8986,6 +8986,7 @@ static const vshCmdOptDef opts_setmem[] =3D { VIRSH_COMMON_OPT_DOMAIN_FULL(0), {.name =3D "kilobytes", .type =3D VSH_OT_ALIAS, + .flags =3D VSH_OFLAG_DEPRECATED, .help =3D "size" }, {.name =3D "size", --=20 2.26.2 From nobody Sat May 4 02:07:17 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) client-ip=63.128.21.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1616429471; cv=none; d=zohomail.com; s=zohoarc; b=ki9vGg7zlRWTNGSAqa62I+spZVjT9+YiOuiiEQBbpwHfjO6No8txSm5HTlIoTroLXyvEs70l5UM8zZ6QOm2zyHmwsgHZNx6Gr5PLKcsEfSNf4gBxWW08yk9prZ38LdnSHgc0duoRWgZv7QUCY3P7CGYVPT3vgBzkAnptQl8JoDo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1616429471; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=0Wb0AMIYK7NOamsJhgvDZRXT5sDvKZ7KUSqmWacoP94=; b=YJCQ2gw+qdgmehfpybf5bX8ZXVgpn0wbUIYLythu+LbTPSj4xz65qWMonZSHIa8AZmn5Rl/UhyRRhNmLWP1lbSWTd193TxE58cty6CnIhPJz4oiI3J3vI1KCw5LCtb35c5YywuiKIFF29KV+aFH2MWqPhVxzYKmNuqO/eeu++Yc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.zohomail.com with SMTPS id 1616429471296955.744061949051; Mon, 22 Mar 2021 09:11:11 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-132-RNQjJRNdPgq9L3aKly1rHw-1; Mon, 22 Mar 2021 12:10:30 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 56446190A7A5; Mon, 22 Mar 2021 16:10:22 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 304B96294D; Mon, 22 Mar 2021 16:10:22 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id DA1C44A7C8; Mon, 22 Mar 2021 16:10:21 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 12MGAG1b010545 for ; Mon, 22 Mar 2021 12:10:16 -0400 Received: by smtp.corp.redhat.com (Postfix) id CF1B519CBA; Mon, 22 Mar 2021 16:10:16 +0000 (UTC) Received: from work.redhat.com (ovpn-112-246.ams2.redhat.com [10.36.112.246]) by smtp.corp.redhat.com (Postfix) with ESMTP id B606A39A5F; Mon, 22 Mar 2021 16:10:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1616429470; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=0Wb0AMIYK7NOamsJhgvDZRXT5sDvKZ7KUSqmWacoP94=; b=fUFj16y0iWMNN7cVQJYykSvmJ0kzZt7WK+1UPMKzFpCKcn+XYe5rBknyn++lfg18l64h8K 6lhdh2sQhqgqgcfChqPwHpu8LmJMf/KdZX+qB5X1McdcdBAWC8BY38D9eV0Dft9hbFyJ7A KIA4uGNoLfHoDSzNcZRUZC6IE9tNO+M= X-MC-Unique: RNQjJRNdPgq9L3aKly1rHw-1 From: Tim Wiederhake To: libvir-list@redhat.com Subject: [libvirt PATCH 4/5] vsh: setmaxmem: Mark '--kilobytes' as deprecated Date: Mon, 22 Mar 2021 17:10:03 +0100 Message-Id: <20210322161004.145555-5-twiederh@redhat.com> In-Reply-To: <20210322161004.145555-1-twiederh@redhat.com> References: <20210322161004.145555-1-twiederh@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: libvir-list@redhat.com Cc: Tim Wiederhake X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Signed-off-by: Tim Wiederhake --- tools/virsh-domain.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 32bd048d26..9f0e3e1a5e 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -9065,6 +9065,7 @@ static const vshCmdOptDef opts_setmaxmem[] =3D { VIRSH_COMMON_OPT_DOMAIN_FULL(0), {.name =3D "kilobytes", .type =3D VSH_OT_ALIAS, + .flags =3D VSH_OFLAG_DEPRECATED, .help =3D "size" }, {.name =3D "size", --=20 2.26.2 From nobody Sat May 4 02:07:17 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1616429445; cv=none; d=zohomail.com; s=zohoarc; b=b4JrT/1ERsn4fqMk7qyEkMF5YWFM7bDtiSz0itdWlCyokNw0B9BzFkMvTwnVd9ek91srUbq04I/NwChUaKSjMmQkaEGCpVXsmkEm/6smDN9JP3VMQHmBMvhNec5eIXCV57DVjHJl5TxcGSfBvKg0YHfPdGqbuSMAQhGXWyqdqeA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1616429445; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=104hfUg1pHYfNYYqHExiUdCYcBuvOUVaXMH/g3r43rk=; b=c2ukmFhXKrYZnYlzRf6iihiklnEZ/mR8UVxQxz0hc9G9p34tCmJihjJ4jmnvnc97TpkqYE8GJA0MNW4QpfWjV2JiLq6Ms1KUTEq7uTQqXfGRfG1ziVzzJ/36rmCMHX7yCSPXNRil7NastdnunOUh97cppdXEQjcq0xPBFS+YEHI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1616429444904647.6713659693132; Mon, 22 Mar 2021 09:10:44 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-262-QMuR9KTwNzKtZNNmEMPWXg-1; Mon, 22 Mar 2021 12:10:32 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 00073108BD06; Mon, 22 Mar 2021 16:10:25 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B56DA1F067; Mon, 22 Mar 2021 16:10:25 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 49F034A700; Mon, 22 Mar 2021 16:10:25 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 12MGAHcV010552 for ; Mon, 22 Mar 2021 12:10:17 -0400 Received: by smtp.corp.redhat.com (Postfix) id E04CE50A8A; Mon, 22 Mar 2021 16:10:17 +0000 (UTC) Received: from work.redhat.com (ovpn-112-246.ams2.redhat.com [10.36.112.246]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2E9C919CBA; Mon, 22 Mar 2021 16:10:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1616429435; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=104hfUg1pHYfNYYqHExiUdCYcBuvOUVaXMH/g3r43rk=; b=B6V2qIsDlR3guYe9JqYXReIhoaAolr8KXyl/SuCZ4BVPrsC7t+OXgCdQbuAy5A4S86PtBU SeAq7/+Vn2xkmnJ36tI3GN2MMXCpllKqKQEGomXAur4h5wJUdSxoBabLGnT7vusrlOuWH0 OPmT+GIJp8V337EpQlUsV1MoVQRHjq0= X-MC-Unique: QMuR9KTwNzKtZNNmEMPWXg-1 From: Tim Wiederhake To: libvir-list@redhat.com Subject: [libvirt PATCH 5/5] vsh: secret-set-value: Mark '--base64' as deprecated Date: Mon, 22 Mar 2021 17:10:04 +0100 Message-Id: <20210322161004.145555-6-twiederh@redhat.com> In-Reply-To: <20210322161004.145555-1-twiederh@redhat.com> References: <20210322161004.145555-1-twiederh@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: libvir-list@redhat.com Cc: Tim Wiederhake X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Signed-off-by: Tim Wiederhake --- tools/virsh-secret.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tools/virsh-secret.c b/tools/virsh-secret.c index 7ca3e864da..5a1c4d7bf6 100644 --- a/tools/virsh-secret.c +++ b/tools/virsh-secret.c @@ -192,6 +192,7 @@ static const vshCmdOptDef opts_secret_set_value[] =3D { }, {.name =3D "base64", .type =3D VSH_OT_STRING, + .flags =3D VSH_OFLAG_DEPRECATED, .help =3D N_("base64-encoded secret value") }, {.name =3D NULL} @@ -225,8 +226,6 @@ cmdSecretSetValue(vshControl *ctl, const vshCmd *cmd) return false; =20 if (base64) { - /* warn users that the --base64 option passed from command line is= wrong */ - vshError(ctl, _("Passing secret value as command-line argument is = insecure!")); secret_val =3D g_strdup(base64); secret_len =3D strlen(secret_val); } else if (filename) { --=20 2.26.2