From nobody Tue Feb 10 07:38:55 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1616169622; cv=none; d=zohomail.com; s=zohoarc; b=eRU3Aj4lLqzLKR5r9v2vEfsnuPB072rw+0E738tOqS8r3e0VXHcaqqbVCOoLjlghqTWY0o1oxOqXcgdeDhVlDWQKZCmPM30rsZnz0vV9Ehnkyx6AoHeyB//1vwLXSOppmX+jgwBOWxeTyew8+6wnCQU80tQadIgONqe7p3zBwVk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1616169622; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=zGDbarQ/oN1Efhgsoqop5y4VN4EMLefXsJV6tRPzU54=; b=VKan9OPVw2CeMLdkK3qIO9udeAQMJXuECgtljVHxMTCdglt7K5kc+vjE1P1QqZb+rxR6A8zwsIpS4S+ght85K39WvKvh7iM8A5PgJPXOyl1OvzNjfxq2FfBh9MOOiiLsy+qnTZQjB5zQncV6oVEvuURPOfBachIz0cR6VYFw28I= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1616169622550987.7615436142543; Fri, 19 Mar 2021 09:00:22 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-43-6ELjFQ_nOU6PZGDo4-qQkA-1; Fri, 19 Mar 2021 12:00:15 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D1AB584BA75; Fri, 19 Mar 2021 16:00:07 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8FB9A5D730; Fri, 19 Mar 2021 16:00:07 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 301F050039; Fri, 19 Mar 2021 16:00:07 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 12JG02gU007454 for ; Fri, 19 Mar 2021 12:00:02 -0400 Received: by smtp.corp.redhat.com (Postfix) id 749F71C94B; Fri, 19 Mar 2021 16:00:02 +0000 (UTC) Received: from work.redhat.com (ovpn-112-175.ams2.redhat.com [10.36.112.175]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8F8AD1C955; Fri, 19 Mar 2021 16:00:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1616169620; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=zGDbarQ/oN1Efhgsoqop5y4VN4EMLefXsJV6tRPzU54=; b=B6XT7j0H7o8xR38Maila4GZ3EXkZ/eMLzEdV6pjkVPxyU0pgJg2GZOMVuApNGy8QTkJQ9+ 34YX38CcDLH9Fs6lWOYLx49OdvE0hsvOnlQWIyXcYD6Hbo4stXoHEQpb+S9KCJLbpp2wlD fb7mzyw2duKjxlSlChPfMCUTu/Anbpk= X-MC-Unique: 6ELjFQ_nOU6PZGDo4-qQkA-1 From: Tim Wiederhake To: libvir-list@redhat.com Subject: [libvirt PATCH v3 37/51] domain_conf: Use virXMLPropTristateXXX in virDomainShmemDefParseXML Date: Fri, 19 Mar 2021 16:57:34 +0100 Message-Id: <20210319155748.680146-38-twiederh@redhat.com> In-Reply-To: <20210319155748.680146-1-twiederh@redhat.com> References: <20210319155748.680146-1-twiederh@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-loop: libvir-list@redhat.com Cc: Tim Wiederhake X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 14 +++----------- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 6b98d34eb4..ef1a9cdab2 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -14358,17 +14358,9 @@ virDomainShmemDefParseXML(virDomainXMLOptionPtr xm= lopt, } VIR_FREE(tmp); =20 - if ((tmp =3D virXMLPropString(msi, "ioeventfd"))) { - int val; - - if ((val =3D virTristateSwitchTypeFromString(tmp)) <=3D 0) { - virReportError(VIR_ERR_XML_ERROR, - _("invalid msi ioeventfd setting for shmem:= '%s'"), - tmp); - goto cleanup; - } - def->msi.ioeventfd =3D val; - } + if (virXMLPropTristateSwitch(msi, "ioeventfd", false, + &def->msi.ioeventfd) < 0) + goto cleanup; } =20 /* msi option is only relevant with a server */ --=20 2.26.2