From nobody Tue Feb 10 07:39:12 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1616169615; cv=none; d=zohomail.com; s=zohoarc; b=dC1ZY8QbcV2/GkEdxYNoEYWFx3FUJWBkDM/B71NBfqsHB4nHa+TmskGWPtjBS8AoKir/2MVeEevbBLyeN8KvF0cSSOgyXuNESOxbhCbakhnXeN6DAGtS5l7KeYCp281FPmHxZQXdcCC/RVN2UahBGgFJ8h8RXeIwtC5VVs1nYCo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1616169615; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=4ZIhwIXcV0U4q0B/y6raTkQOlmx/yqo1rpu1qOlWwck=; b=EELmmqzL3skOMyg4BEIU5KsENumyalYBplu/pEmcb2LdVV7JGzDhbDIZVbjLjxgufiUHdIE7jCm7UI0KsYaHCLUi5MWbBMc1g4POuKxfhs99yrn9CH61O04Py4mboI1odpyMswfYG9Bs6+32D4J0ivQUTK/1B4m4L3zN2Vh/ykk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1616169615199256.32491909114754; Fri, 19 Mar 2021 09:00:15 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-105-FUum3AtyO5q4ayQgXEjDrA-1; Fri, 19 Mar 2021 12:00:09 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9B3F11085945; Fri, 19 Mar 2021 16:00:01 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E679B1F40A; Fri, 19 Mar 2021 16:00:00 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 98AF350039; Fri, 19 Mar 2021 16:00:00 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 12JFxxEN007414 for ; Fri, 19 Mar 2021 11:59:59 -0400 Received: by smtp.corp.redhat.com (Postfix) id DE4102B3CB; Fri, 19 Mar 2021 15:59:58 +0000 (UTC) Received: from work.redhat.com (ovpn-112-175.ams2.redhat.com [10.36.112.175]) by smtp.corp.redhat.com (Postfix) with ESMTP id A139C1F433; Fri, 19 Mar 2021 15:59:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1616169613; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=4ZIhwIXcV0U4q0B/y6raTkQOlmx/yqo1rpu1qOlWwck=; b=XoJuRAG698ViDDRazpzoH14vSxKvN1MBBHDNF/aEMccqec5b2+uQOg86H8UeK/NymvnxOw JiQMURgDRxye0NJI2PiUk7HoNAYEJonIfx2COC9c4ZBqigCZGMkRR+AJm/jcp1fMkFX6Wp 05S5xs3Sqs/DsoJesJLq39rC1TUbv0Q= X-MC-Unique: FUum3AtyO5q4ayQgXEjDrA-1 From: Tim Wiederhake To: libvir-list@redhat.com Subject: [libvirt PATCH v3 34/51] domain_conf: Use virXMLPropTristateXXX in virDomainAudioOSSParse Date: Fri, 19 Mar 2021 16:57:31 +0100 Message-Id: <20210319155748.680146-35-twiederh@redhat.com> In-Reply-To: <20210319155748.680146-1-twiederh@redhat.com> References: <20210319155748.680146-1-twiederh@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-loop: libvir-list@redhat.com Cc: Tim Wiederhake X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index afd37e3e49..c341091c99 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -13837,18 +13837,12 @@ static int virDomainAudioOSSParse(virDomainAudioIOOSSPtr def, xmlNodePtr node) { - g_autofree char *tryPoll =3D virXMLPropString(node, "tryPoll"); g_autofree char *bufferCount =3D virXMLPropString(node, "bufferCount"); =20 def->dev =3D virXMLPropString(node, "dev"); =20 - if (tryPoll && - ((def->tryPoll =3D - virTristateBoolTypeFromString(tryPoll)) <=3D 0)) { - virReportError(VIR_ERR_XML_ERROR, - _("unknown 'tryPoll' value '%s'"), tryPoll); + if (virXMLPropTristateBool(node, "tryPoll", false, &def->tryPoll) < 0) return -1; - } =20 if (bufferCount && virStrToLong_ui(bufferCount, NULL, 10, --=20 2.26.2