From nobody Tue Feb 10 07:39:06 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1616169665; cv=none; d=zohomail.com; s=zohoarc; b=FT1IGhFuVQQiL1KZHSD2Nk7vbcifcwucKm+By52b05Gva7d4DG4qoYsF1C3yCvytuUKXD+0IskhYx2P12QInUDt+kw+woV3KTRPyL6VbdtPYPIKvKbjLHZzFuxGPfQoLFwj5f56Dmb35Nm4Z0XoSXfoZyqk/zPb30n6g+i1cr+M= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1616169665; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Ogm5zX5GTF0RLB3CYF6MNNzj2UfAJKlerhMzJ1XoWOY=; b=mKguUGA3mHmOH4s60GJ9pod9vfMtCJUw7+ehlgKF9/4kOvamWDdDmTBMz0MogGlOSNL/hshSL1/C+fxruTZ/2h+3fnA0aCvoUkxcD2SJdUAgnUhUpDSBGtQYJnPus2Ts0VwG6JMK8Ye1xfvivFnQg9vwGKRBXjuClHx5VLA66II= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1616169665775757.1477279408455; Fri, 19 Mar 2021 09:01:05 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-122-7kS6_l34OfOuo4Ty6GzOxA-1; Fri, 19 Mar 2021 11:58:53 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B0A3E9CC07; Fri, 19 Mar 2021 15:58:46 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8BCD760BF1; Fri, 19 Mar 2021 15:58:46 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 4C5051818464; Fri, 19 Mar 2021 15:58:46 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 12JFwbE7006711 for ; Fri, 19 Mar 2021 11:58:37 -0400 Received: by smtp.corp.redhat.com (Postfix) id 1D57518E4B; Fri, 19 Mar 2021 15:58:37 +0000 (UTC) Received: from work.redhat.com (ovpn-112-175.ams2.redhat.com [10.36.112.175]) by smtp.corp.redhat.com (Postfix) with ESMTP id 60D981A353; Fri, 19 Mar 2021 15:58:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1616169663; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=Ogm5zX5GTF0RLB3CYF6MNNzj2UfAJKlerhMzJ1XoWOY=; b=G46L6WK5ScLPpucCOs0NCmp2d0QvW9rkvO8bMeFjrkv0FbYJRwS8eOHhkz7lfA3Qpgiz4s iLDuo3ZO4ALrXieVeqaV7wh0tw6eMT6rgAB8lnxDSZyQmJIFGbeTxO+ZHLpd/IZpmkOsH9 7fj0oipmPI6gwDj6U7dZdeBqtDYOpnk= X-MC-Unique: 7kS6_l34OfOuo4Ty6GzOxA-1 From: Tim Wiederhake To: libvir-list@redhat.com Subject: [libvirt PATCH v3 28/51] domain_conf: Use virXMLPropTristateXXX in virDomainChrSourceDefParseLog Date: Fri, 19 Mar 2021 16:57:25 +0100 Message-Id: <20210319155748.680146-29-twiederh@redhat.com> In-Reply-To: <20210319155748.680146-1-twiederh@redhat.com> References: <20210319155748.680146-1-twiederh@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-loop: libvir-list@redhat.com Cc: Tim Wiederhake X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 14 ++------------ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 0f3be88235..842a134220 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -11812,20 +11812,10 @@ static int virDomainChrSourceDefParseLog(virDomainChrSourceDefPtr def, xmlNodePtr log) { - g_autofree char *append =3D NULL; - def->logfile =3D virXMLPropString(log, "file"); =20 - if ((append =3D virXMLPropString(log, "append"))) { - int value; - if ((value =3D virTristateSwitchTypeFromString(append)) <=3D 0) { - virReportError(VIR_ERR_INTERNAL_ERROR, - _("Invalid append attribute value '%s'"), - append); - return -1; - } - def->logappend =3D value; - } + if (virXMLPropTristateSwitch(log, "append", false, &def->logappend) < = 0) + return -1; =20 return 0; } --=20 2.26.2