From nobody Tue Feb 10 07:38:52 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) client-ip=63.128.21.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1616169550; cv=none; d=zohomail.com; s=zohoarc; b=VPaUIy/gqZIfAVurka2Ey+b1GjMpOqk7UFaacj5u6SVJOl7zZuBXd7Yxp8Lq/lQryANfovuC6W/ZII4p2I99VPDBB2pxcsbEq4+1jhOOWrAfp3NiAr7NJSSkmSIY12S0ad1uKEos7s+/Uy8y0jCso805C2hZ8mlhyKIO25b5+Uo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1616169550; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=82G9U+1ssunEPIIGUegxJ753/dJoFSR6DFI0d8LHJRU=; b=JhedDrNP8jOprQP2Y/7hNfzqRP53ID5ifuwCQm9nv/myjL8atI/NjwPhzDQvGZCgr+eBkcfjqQHxidaHgO9FUWGQpPSRxR32X1SquVRFUf7eyFKNsVLubKsp2kh8bayAQZKRXFVPwXtB8vqCtW7nx+88nNQ9kaq8IaVUfB9inxg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.zohomail.com with SMTPS id 161616955065637.616873780086394; Fri, 19 Mar 2021 08:59:10 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-417-g2PNNeSHOZWTOoLjRRpDbA-1; Fri, 19 Mar 2021 11:58:46 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A2253185FFC9; Fri, 19 Mar 2021 15:58:39 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 757861F045; Fri, 19 Mar 2021 15:58:39 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 0E048180214D; Fri, 19 Mar 2021 15:58:39 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 12JFwZVm006685 for ; Fri, 19 Mar 2021 11:58:35 -0400 Received: by smtp.corp.redhat.com (Postfix) id F25991A353; Fri, 19 Mar 2021 15:58:34 +0000 (UTC) Received: from work.redhat.com (ovpn-112-175.ams2.redhat.com [10.36.112.175]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3FC1618E4B; Fri, 19 Mar 2021 15:58:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1616169549; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=82G9U+1ssunEPIIGUegxJ753/dJoFSR6DFI0d8LHJRU=; b=HtYIc2ozIwUbXC5PyNMv2WsIHBK9xzQjbCYQ2Ta6v90qIq/+BlcjBCtCU23Tt/a+FYbH6/ /fXBqFyD6K4P42Sdw9mCtPgAvhevSy6fFQnFxrDixdPUPiZ1GtAiGRB3jARA2uffKSUy/5 vNM3LUfzF4yhU/fiDpon6lg9C6iyCFo= X-MC-Unique: g2PNNeSHOZWTOoLjRRpDbA-1 From: Tim Wiederhake To: libvir-list@redhat.com Subject: [libvirt PATCH v3 26/51] domain_conf: Use virXMLPropTristateXXX in virDomainChrSourceDefParseTCP Date: Fri, 19 Mar 2021 16:57:23 +0100 Message-Id: <20210319155748.680146-27-twiederh@redhat.com> In-Reply-To: <20210319155748.680146-1-twiederh@redhat.com> References: <20210319155748.680146-1-twiederh@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-loop: libvir-list@redhat.com Cc: Tim Wiederhake X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 13 ++----------- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 97eb1b6f8a..7fb096e6d9 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -11703,17 +11703,8 @@ virDomainChrSourceDefParseTCP(virDomainChrSourceDe= fPtr def, def->data.tcp.host =3D virXMLPropString(source, "host"); def->data.tcp.service =3D virXMLPropString(source, "service"); =20 - if ((tmp =3D virXMLPropString(source, "tls"))) { - int value; - if ((value =3D virTristateBoolTypeFromString(tmp)) <=3D 0) { - virReportError(VIR_ERR_XML_ERROR, - _("unknown chardev 'tls' setting '%s'"), - tmp); - return -1; - } - def->data.tcp.haveTLS =3D value; - VIR_FREE(tmp); - } + if (virXMLPropTristateBool(source, "tls", false, &def->data.tcp.haveTL= S) < 0) + return -1; =20 if ((flags & VIR_DOMAIN_DEF_PARSE_STATUS) && (tmp =3D virXMLPropString(source, "tlsFromConfig"))) { --=20 2.26.2