From nobody Mon Feb 9 16:02:07 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1616161379; cv=none; d=zohomail.com; s=zohoarc; b=S4fUqZOV8UogxYJ6+lpxBE3Flu7KjI0ka5iwRUT1VbqFNPSd0SNomJv7ldzw5Q/SO/eY7Ot07sJA0jGAJ6oaN790dRZu+WajwDmIIADcnCQ+8DQ8fA0MRrQv4cxjTY1euWxuT3lvYtmrADBD5o3hE26cPrk5rqttjES9zMtQLH0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1616161379; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=CG1Aqbne+ac/2NT4NbH9hk5GpYrn8W1DzlP6YMkcxBg=; b=YzgAOh5PmJTbVny4cpaLo92kM3XGYo4Xp4qMjvmX/IX1kAuC7XXYMZn9L0lwcJn/pZzFaYCWEgXy57eXgAmZfGHFrXOLkCL0mm8Zn78gJOsM32fxLFlrFgTOARmIXBiVy75S9KtMw0+1OGIybqSk7SgUTSZSqXssjeh48gdeJnE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1616161379593581.1707003929853; Fri, 19 Mar 2021 06:42:59 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-48-a0V89DHOM0mb7laoq4VJKw-1; Fri, 19 Mar 2021 09:42:56 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9D0FC593B7; Fri, 19 Mar 2021 13:42:50 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 76E065DAA5; Fri, 19 Mar 2021 13:42:50 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 2EF3B1818468; Fri, 19 Mar 2021 13:42:50 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 12JDgiNP020684 for ; Fri, 19 Mar 2021 09:42:44 -0400 Received: by smtp.corp.redhat.com (Postfix) id 4BF6D59452; Fri, 19 Mar 2021 13:42:44 +0000 (UTC) Received: from work.redhat.com (ovpn-112-175.ams2.redhat.com [10.36.112.175]) by smtp.corp.redhat.com (Postfix) with ESMTP id 910C55944F; Fri, 19 Mar 2021 13:42:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1616161378; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=CG1Aqbne+ac/2NT4NbH9hk5GpYrn8W1DzlP6YMkcxBg=; b=FbEpyXaASaMyslDClqW6yv4/KE5X6KdrU/+WR+Aq4DjwflmsMpAWtDC/nX1sezP7J794Er EzQTrvp+/WQ6k3ywLI4W5qoIRyDX9b5jF9wT77suD+rg1OxwkskMxLxukBFRUZ5i6kPFef kpQu5eV3BnYz6ZTFGVt6ePoIyLGVjdw= X-MC-Unique: a0V89DHOM0mb7laoq4VJKw-1 From: Tim Wiederhake To: libvir-list@redhat.com Subject: [libvirt PATCH v2 41/51] domain_conf: Use virXMLPropTristateXXX in virDomainVsockDefParseXML Date: Fri, 19 Mar 2021 14:40:55 +0100 Message-Id: <20210319134105.442774-42-twiederh@redhat.com> In-Reply-To: <20210319134105.442774-1-twiederh@redhat.com> References: <20210319134105.442774-1-twiederh@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: libvir-list@redhat.com Cc: Tim Wiederhake X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 13 ++----------- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 4bcae93c37..418e86ebcb 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -15842,17 +15842,8 @@ virDomainVsockDefParseXML(virDomainXMLOptionPtr xm= lopt, } } =20 - VIR_FREE(tmp); - if ((tmp =3D virXMLPropString(cid, "auto"))) { - val =3D virTristateBoolTypeFromString(tmp); - if (val <=3D 0) { - virReportError(VIR_ERR_XML_DETAIL, - _("'auto' attribute can be 'yes' or 'no': %= s"), - tmp); - return NULL; - } - vsock->auto_cid =3D val; - } + if (virXMLPropTristateBool(cid, "auto", false, &vsock->auto_cid) <= 0) + return NULL; } =20 if (virDomainDeviceInfoParseXML(xmlopt, node, ctxt, &vsock->info, flag= s) < 0) --=20 2.26.2