From nobody Mon Feb 9 19:05:02 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1616161377; cv=none; d=zohomail.com; s=zohoarc; b=mNXVy8AplLtU4MEALAHKSTabVZ4VLv5j2n7I3zZZA0mvKQrpGmG3MH7hsncVjnS8qphS00eCWcGif7ZlpYIdzJB3bdX79omN2ernd/7LZwNUiBl1PTJqKVutUCYsI+uZn/spCZ5UNSy9f9ZXeflm75Mhs0TnXnibcDk2cxCbkiI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1616161377; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=vPzV+uPWJYT7YIBW66vZ+UEujk78jiwU1KYzVOdvzcQ=; b=L/Zs6ImjtQt8mgbMOHR4JakiGI7pqH1iJuTsrBGTEqsOg2eiLgCMQ309iAl4mEUFRc/Da5YSywl8aZn4yKxEA8nCAgfh96/OZ0gEPQy8H6z39AMHs8CoWeUyzd/uMpuyG0lIhftG5Rns5r7PkRTRWXD1WzDRSbY9MisKekwyFrg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1616161377443834.6651569767139; Fri, 19 Mar 2021 06:42:57 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-7-5lLBPPGXPlW8nxYAJU4OWQ-1; Fri, 19 Mar 2021 09:42:51 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1102A1013724; Fri, 19 Mar 2021 13:42:44 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DE50C5054E; Fri, 19 Mar 2021 13:42:43 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 8E88450052; Fri, 19 Mar 2021 13:42:43 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 12JDgbRh020601 for ; Fri, 19 Mar 2021 09:42:37 -0400 Received: by smtp.corp.redhat.com (Postfix) id D60765944B; Fri, 19 Mar 2021 13:42:37 +0000 (UTC) Received: from work.redhat.com (ovpn-112-175.ams2.redhat.com [10.36.112.175]) by smtp.corp.redhat.com (Postfix) with ESMTP id 288B84F3C6; Fri, 19 Mar 2021 13:42:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1616161376; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=vPzV+uPWJYT7YIBW66vZ+UEujk78jiwU1KYzVOdvzcQ=; b=V0jN6ZAzftiOWg0UC6LnstZCEDF8r+OpvNJC+LoW14z8+wghr9OV/uYnm5XNwIjIZkLYQD 8S9BdK2wUNkuvB4ZFeMRzuXdgesys1zuaqVRjyt6xMBDBpPi5JCEgUlal3jco53Z/qZ1Rz knYEP9LbzVevIX2IAWRHUI4p2IdbNMQ= X-MC-Unique: 5lLBPPGXPlW8nxYAJU4OWQ-1 From: Tim Wiederhake To: libvir-list@redhat.com Subject: [libvirt PATCH v2 35/51] domain_conf: Use virXMLPropTristateXXX in virDomainAudioDefParseXML Date: Fri, 19 Mar 2021 14:40:49 +0100 Message-Id: <20210319134105.442774-36-twiederh@redhat.com> In-Reply-To: <20210319134105.442774-1-twiederh@redhat.com> References: <20210319134105.442774-1-twiederh@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: libvir-list@redhat.com Cc: Tim Wiederhake X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 16 ++++------------ 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 17b8cab707..976bdb0172 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -13970,23 +13970,15 @@ virDomainAudioDefParseXML(virDomainXMLOptionPtr x= mlopt G_GNUC_UNUSED, break; =20 case VIR_DOMAIN_AUDIO_TYPE_OSS: { - g_autofree char *tryMMap =3D virXMLPropString(node, "tryMMap"); - g_autofree char *exclusive =3D virXMLPropString(node, "exclusive"); g_autofree char *dspPolicy =3D virXMLPropString(node, "dspPolicy"); =20 - if (tryMMap && ((def->backend.oss.tryMMap =3D - virTristateBoolTypeFromString(tryMMap)) <=3D 0)) { - virReportError(VIR_ERR_XML_ERROR, - _("unknown 'tryMMap' value '%s'"), tryMMap); + if (virXMLPropTristateBool(node, "tryMMap", false, + &def->backend.oss.tryMMap) < 0) goto error; - } =20 - if (exclusive && ((def->backend.oss.exclusive =3D - virTristateBoolTypeFromString(exclusive)) <=3D = 0)) { - virReportError(VIR_ERR_XML_ERROR, - _("unknown 'exclusive' value '%s'"), exclusive); + if (virXMLPropTristateBool(node, "exclusive", false, + &def->backend.oss.exclusive) < 0) goto error; - } =20 if (dspPolicy) { if (virStrToLong_i(dspPolicy, NULL, 10, --=20 2.26.2