From nobody Mon Feb 9 15:11:22 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1616161453; cv=none; d=zohomail.com; s=zohoarc; b=AA+wD2zr1SgS8JxTiY4NS+ScIWTxCq/h2xYZEdATc9uMLf6xqndPxLyO35TJkeZ4IRIgD7oeD+jNrmEUZtDTmcuH5UdZs10clfxlSS+5rLaEGYeZRcq/2VNEnqkCEveaU1NzPC1/F8Z26loRpa7HHAmWFdTY7+v/B9AaprWRUaA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1616161453; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=a9GvnTJeTAygE5v3gsZ+5cDHM/V+Z8vmzDI9USjwceo=; b=Ax+8SSsY0pn6YZQTtIxu5WA75kaKNRpciPjB5Ngx7HiaQvb0yyIA9YJZnQVrcDF+VAmfDMwmcnAidFQYoGVo6U3EBId5CRh41cMJFd5RtjIvx5+XlV2M7FWMl3HZe5FgNwuu8AcRZnYA0QAZJuTUvJMns1E1rRwrN5vMhWEisa0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1616161453196327.64512812129556; Fri, 19 Mar 2021 06:44:13 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-208-R21cBwShPEKiyzvjyoWdwA-1; Fri, 19 Mar 2021 09:42:10 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 39B1B83DD23; Fri, 19 Mar 2021 13:42:04 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 116B650454; Fri, 19 Mar 2021 13:42:04 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id B5EC850043; Fri, 19 Mar 2021 13:42:03 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 12JDfk3R019666 for ; Fri, 19 Mar 2021 09:41:46 -0400 Received: by smtp.corp.redhat.com (Postfix) id 4554239A65; Fri, 19 Mar 2021 13:41:46 +0000 (UTC) Received: from work.redhat.com (ovpn-112-175.ams2.redhat.com [10.36.112.175]) by smtp.corp.redhat.com (Postfix) with ESMTP id 87DD863B8C; Fri, 19 Mar 2021 13:41:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1616161446; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=a9GvnTJeTAygE5v3gsZ+5cDHM/V+Z8vmzDI9USjwceo=; b=LYAtGD5r+b2mi0XbGaG/47cxhKUT5WuGtOLLik3iLxo0kAvNAnTBNLpf/w8D7qpH4n3/ha jK/kNIYtfoaa1zJ2UnzGgOu71GfTpuXmNP4huSukKJHASJGplaLH665fqb1DikOHjq+epp Q2Y9/TKXnU7Yl5tmeJcIFUVMLtQWnM4= X-MC-Unique: R21cBwShPEKiyzvjyoWdwA-1 From: Tim Wiederhake To: libvir-list@redhat.com Subject: [libvirt PATCH v2 26/51] domain_conf: Use virXMLPropTristateXXX in virDomainChrSourceDefParseTCP Date: Fri, 19 Mar 2021 14:40:40 +0100 Message-Id: <20210319134105.442774-27-twiederh@redhat.com> In-Reply-To: <20210319134105.442774-1-twiederh@redhat.com> References: <20210319134105.442774-1-twiederh@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: libvir-list@redhat.com Cc: Tim Wiederhake X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 329f42d6dd..9822f4f451 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -11704,15 +11704,8 @@ virDomainChrSourceDefParseTCP(virDomainChrSourceDe= fPtr def, def->data.tcp.host =3D virXMLPropString(source, "host"); def->data.tcp.service =3D virXMLPropString(source, "service"); =20 - if ((tmp =3D virXMLPropString(source, "tls"))) { - if ((def->data.tcp.haveTLS =3D virTristateBoolTypeFromString(tmp))= <=3D 0) { - virReportError(VIR_ERR_XML_ERROR, - _("unknown chardev 'tls' setting '%s'"), - tmp); - return -1; - } - VIR_FREE(tmp); - } + if (virXMLPropTristateBool(source, "tls", false, &def->data.tcp.haveTL= S) < 0) + return -1; =20 if ((flags & VIR_DOMAIN_DEF_PARSE_STATUS) && (tmp =3D virXMLPropString(source, "tlsFromConfig"))) { --=20 2.26.2