From nobody Mon Feb 9 15:11:22 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1616161513; cv=none; d=zohomail.com; s=zohoarc; b=dQuuwAmX9+oinOUBXWSE5Y3voMRa8/B//73m6Uvn4ikgQxBOAGVkD+9d9hGGspPU+Lu2Waap9IIRdZdYgbHx5fGKNsKtykOHnDtzX/4CaVsceBkKlnzaK04DRz08U0pgickepj9Oxqi8IZSHBvB+/ZZg39FF/iFW5f8IrtYyQF0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1616161513; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=m5m47gEy4Afy6KMyGllHbfDCvtAS+G6wvuADe7PYsT4=; b=bkVRPSfvS1P05RNWtaKPptYfUbbhO3saDFXcs6fRsxg8N6NyFaxxK2Hs7qKrq3EiWp3gIoSd5C+qP4eBToGJwNHsSZdyO+EWHyJ3hZYUKe8L56YZ9m6i5sf8HdwqdhCAnDB33JejnInk1hinfsVHbxPqVrC1oNx089mNa7Gs82w= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1616161513704554.4679437502687; Fri, 19 Mar 2021 06:45:13 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-358-fmUrso0qPBmjAs5An6x4Eg-1; Fri, 19 Mar 2021 09:42:06 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id EB48D1013723; Fri, 19 Mar 2021 13:41:59 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C9A8A60BF1; Fri, 19 Mar 2021 13:41:59 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 9235550041; Fri, 19 Mar 2021 13:41:59 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 12JDfhpH019530 for ; Fri, 19 Mar 2021 09:41:43 -0400 Received: by smtp.corp.redhat.com (Postfix) id 2198D39A65; Fri, 19 Mar 2021 13:41:43 +0000 (UTC) Received: from work.redhat.com (ovpn-112-175.ams2.redhat.com [10.36.112.175]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6AD592BFEE; Fri, 19 Mar 2021 13:41:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1616161511; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=m5m47gEy4Afy6KMyGllHbfDCvtAS+G6wvuADe7PYsT4=; b=fXv35P2YAEwFlX4UD1JDVvvhuWOG3vZhGt1QNzVMm6hRw+PSuteBRbfqzDl4/9+7++9X37 sikN6XX0mVNoN8PRls4/BQvqagyi3D4c2kMEs/nveAL2O4PXZsNTw4Vkh4aeL7INrbgvsE 89yoMCtsqRFy+OL1KYbRAX8b98FJq50= X-MC-Unique: fmUrso0qPBmjAs5An6x4Eg-1 From: Tim Wiederhake To: libvir-list@redhat.com Subject: [libvirt PATCH v2 23/51] domain_conf: Use virXMLPropTristateXXX in virDomainActualNetDefParseXML Date: Fri, 19 Mar 2021 14:40:37 +0100 Message-Id: <20210319134105.442774-24-twiederh@redhat.com> In-Reply-To: <20210319134105.442774-1-twiederh@redhat.com> References: <20210319134105.442774-1-twiederh@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: libvir-list@redhat.com Cc: Tim Wiederhake X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index ef7eed5682..bcc89c0afc 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -10436,7 +10436,6 @@ virDomainActualNetDefParseXML(xmlNodePtr node, g_autofree char *type =3D NULL; g_autofree char *mode =3D NULL; g_autofree char *addrtype =3D NULL; - g_autofree char *trustGuestRxFilters =3D NULL; g_autofree char *macTableManager =3D NULL; =20 actual =3D g_new0(virDomainActualNetDef, 1); @@ -10464,15 +10463,9 @@ virDomainActualNetDefParseXML(xmlNodePtr node, goto error; } =20 - trustGuestRxFilters =3D virXMLPropString(node, "trustGuestRxFilters"); - if (trustGuestRxFilters && - ((actual->trustGuestRxFilters - =3D virTristateBoolTypeFromString(trustGuestRxFilters)) <=3D 0))= { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, - _("unknown trustGuestRxFilters value '%s'"), - trustGuestRxFilters); + if (virXMLPropTristateBool(node, "trustGuestRxFilters", false, + &actual->trustGuestRxFilters) < 0) goto error; - } =20 virtPortNode =3D virXPathNode("./virtualport", ctxt); if (virtPortNode) { --=20 2.26.2