From nobody Mon Feb 9 16:00:53 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) client-ip=63.128.21.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1616054559; cv=none; d=zohomail.com; s=zohoarc; b=Wx20CTBMkhzwT3WhIg/jocNvdbrOXY/qXAhA6/gckTdR8lCIZ6Wl9vOWrbkjuFBM9iIelXUOUmDpWSOCghul3P4MrvjtsgNTfW0ZWOkx6wmOvPTMOmX1OGCTH3vFKBQXzliX4Ptr1PHAEQL+/X/TMuuyFvFrKgm1E7y3OqttOHI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1616054559; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=GS7O2syX4WvVXIYA8jE3nyu3tFmTP/sxHU91ZvuTGBA=; b=TO1q/nh44P0RRqvVtyLnYMjTWhYo/bys2Jf9FxKUStxkMJtMj2FlC4HWjKh0/q2rHS6fiaLZaez6daNbcdAh8e5u8ty4YtMJ7WJZBpaQTDuo7iF6YJc120ux5rbnL/1btItWfx5m4A2MfHX9v0WZJCqEixRgOM1ob8Pq0fAsVzw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.zohomail.com with SMTPS id 161605455931413.126737379911901; Thu, 18 Mar 2021 01:02:39 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-342-zDaiFfj1Pvej-EdWs9nblg-1; Thu, 18 Mar 2021 04:02:35 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0D98910866AA; Thu, 18 Mar 2021 08:02:31 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D4DEC70951; Thu, 18 Mar 2021 08:02:30 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 891E0180C5C6; Thu, 18 Mar 2021 08:02:30 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 12I82Q73029021 for ; Thu, 18 Mar 2021 04:02:26 -0400 Received: by smtp.corp.redhat.com (Postfix) id E73646362B; Thu, 18 Mar 2021 08:02:26 +0000 (UTC) Received: from work.redhat.com (ovpn-112-180.ams2.redhat.com [10.36.112.180]) by smtp.corp.redhat.com (Postfix) with ESMTP id 30CCB669F2; Thu, 18 Mar 2021 08:02:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1616054557; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=GS7O2syX4WvVXIYA8jE3nyu3tFmTP/sxHU91ZvuTGBA=; b=IQb2fZ7c9i4ozGpbz7slj9nxlzIcEl8bZUT22iHx8S02CiS0/fcg+slDnDIcijCNQ6RSML 0QSGK18GcYYlHJycXBlv+O7MGBkFD8t0SRd4sZsti2W6MvrzVcB2h1RNCF6/Z6/daslzYO qFXvA7jC5dYA+85psEL20TKfayqdsSQ= X-MC-Unique: zDaiFfj1Pvej-EdWs9nblg-1 From: Tim Wiederhake To: libvir-list@redhat.com Subject: [libvirt PATCH 28/38] domain_conf: Use virXMLProp(OnOff|YesNo) in virDomainVsockDefParseXML Date: Thu, 18 Mar 2021 09:01:07 +0100 Message-Id: <20210318080117.70255-29-twiederh@redhat.com> In-Reply-To: <20210318080117.70255-1-twiederh@redhat.com> References: <20210318080117.70255-1-twiederh@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com Cc: Tim Wiederhake X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 13 ++----------- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 2969cf0d88..39f171ba74 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -15900,17 +15900,8 @@ virDomainVsockDefParseXML(virDomainXMLOptionPtr xm= lopt, } } =20 - VIR_FREE(tmp); - if ((tmp =3D virXMLPropString(cid, "auto"))) { - val =3D virTristateBoolTypeFromString(tmp); - if (val <=3D 0) { - virReportError(VIR_ERR_XML_DETAIL, - _("'auto' attribute can be 'yes' or 'no': %= s"), - tmp); - return NULL; - } - vsock->auto_cid =3D val; - } + if (virXMLPropYesNo(cid, "auto", &vsock->auto_cid) < 0) + return NULL; } =20 if (virDomainDeviceInfoParseXML(xmlopt, node, &vsock->info, flags) < 0) --=20 2.26.2