From nobody Tue Feb 10 03:45:15 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1616054650; cv=none; d=zohomail.com; s=zohoarc; b=Oi1UWbd1Yx8jMbkUZ/xMjLCSYXAvxRpxvB0zVl6WkAxl3k9EZBGJJ+BaJVQ3m0pMgJlFQsMPWQy5yNnRWvHBSRkLx7sqty90u64APMcTiKr95KeGQT/ofdYOJoExNsA/gZMLTV9cC1VmpFBGH4rosMOuzxp0+SZJ7V4Pcc77fg8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1616054650; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=U/ruRJY7RFa5wrjlbgwsm9KMhZS9PaX5+qw5n1JiJ6s=; b=SeBD0B4/fobiW7K1I8gIvpgJyhi8wkXo18PkIm93QLMw2Mu7G/zpqR0c0gugzcNO4f5VnMdDpIA5Gzc7DxenFY9Lo45mKWt8WzmjD+N7xBGVVC3PQ9Ss4ZEQfcC+o7VfRkfjVeaVdufLgLZg91oIDQUIn4UBHkNAvL9XqJDrozM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1616054650786780.9908044379099; Thu, 18 Mar 2021 01:04:10 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-220-o1SCSQhGPiSZrS8s775_vQ-1; Thu, 18 Mar 2021 04:02:11 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0DCAA10866A3; Thu, 18 Mar 2021 08:02:06 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D6F7067892; Thu, 18 Mar 2021 08:02:05 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 9A8724A705; Thu, 18 Mar 2021 08:02:05 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 12I81vUB028458 for ; Thu, 18 Mar 2021 04:01:57 -0400 Received: by smtp.corp.redhat.com (Postfix) id C1C1A6362B; Thu, 18 Mar 2021 08:01:57 +0000 (UTC) Received: from work.redhat.com (ovpn-112-180.ams2.redhat.com [10.36.112.180]) by smtp.corp.redhat.com (Postfix) with ESMTP id 16CC96268F; Thu, 18 Mar 2021 08:01:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1616054649; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=U/ruRJY7RFa5wrjlbgwsm9KMhZS9PaX5+qw5n1JiJ6s=; b=ZzHxF23x7/mqZeJkstCOPDWDGHAsjl+eqc7V7NxVqQIbozJqhjSvhPLEfPBjkuCLbew5al Sbb22XextMo1NhQLEozHljX1vh5EeZvwMIUBuS0HSL75SkYo/xDCQECLacxZ/USEMyR6l3 wFedF2zUwcrnYgYHmS0mVMx7MVNAmSc= X-MC-Unique: o1SCSQhGPiSZrS8s775_vQ-1 From: Tim Wiederhake To: libvir-list@redhat.com Subject: [libvirt PATCH 22/38] domain_conf: Use virXMLProp(OnOff|YesNo) in virDomainAudioDefParseXML Date: Thu, 18 Mar 2021 09:01:01 +0100 Message-Id: <20210318080117.70255-23-twiederh@redhat.com> In-Reply-To: <20210318080117.70255-1-twiederh@redhat.com> References: <20210318080117.70255-1-twiederh@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com Cc: Tim Wiederhake X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 14 ++------------ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 6559c3d2f8..fe35a3960e 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -14025,23 +14025,13 @@ virDomainAudioDefParseXML(virDomainXMLOptionPtr x= mlopt G_GNUC_UNUSED, break; =20 case VIR_DOMAIN_AUDIO_TYPE_OSS: { - g_autofree char *tryMMap =3D virXMLPropString(node, "tryMMap"); - g_autofree char *exclusive =3D virXMLPropString(node, "exclusive"); g_autofree char *dspPolicy =3D virXMLPropString(node, "dspPolicy"); =20 - if (tryMMap && ((def->backend.oss.tryMMap =3D - virTristateBoolTypeFromString(tryMMap)) <=3D 0)) { - virReportError(VIR_ERR_XML_ERROR, - _("unknown 'tryMMap' value '%s'"), tryMMap); + if (virXMLPropYesNo(node, "tryMMap", &def->backend.oss.tryMMap) < = 0) goto error; - } =20 - if (exclusive && ((def->backend.oss.exclusive =3D - virTristateBoolTypeFromString(exclusive)) <=3D = 0)) { - virReportError(VIR_ERR_XML_ERROR, - _("unknown 'exclusive' value '%s'"), exclusive); + if (virXMLPropYesNo(node, "exclusive", &def->backend.oss.exclusive= ) < 0) goto error; - } =20 if (dspPolicy) { if (virStrToLong_i(dspPolicy, NULL, 10, --=20 2.26.2