From nobody Mon Feb 9 09:33:34 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1616054586; cv=none; d=zohomail.com; s=zohoarc; b=KLHMg0UJ4zQehXv+d3tXRe+HFcUkNWanHzFP+5zaStu7x73nrj0ABeeA0GfpcELdZTEqAYTcM8YFItRNXQOjXpZDRmCZrZ4J/fZ5McF/jsyeNgIBEW6Qg6JOLyVCY+pUpnxNVeUwG/+Kp5kKp4/RLAqKBgufCyzpiZtHnO9CtIQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1616054586; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=uqLBj1IbVjxrPatZNLb+on3Be7U4bcMqHPBDeKd12p8=; b=Yvfy4niJ9o8dnhoXHU403hv2C5+r6UZCaNqTuqC1rg1bjIMIYVfoZEQ+1u+HsJKoIHoeara9rDWk5tgaLu9Z7sFhbS7DiATI7lgvk5kzGJBJvXE7GyVZPbtSuIB8feTYLxfiWHoNvILjH0SqcQy4bH+Cad3g32kvxjCENLGUY+o= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1616054586981867.4315713125479; Thu, 18 Mar 2021 01:03:06 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-437-gPW5lSuIMMa_T48kG7RxUQ-1; Thu, 18 Mar 2021 04:02:14 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 866C6107B7C4; Thu, 18 Mar 2021 08:02:07 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 147E76E6FE; Thu, 18 Mar 2021 08:02:07 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id BAD0D180213A; Thu, 18 Mar 2021 08:02:06 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 12I81cIa028255 for ; Thu, 18 Mar 2021 04:01:38 -0400 Received: by smtp.corp.redhat.com (Postfix) id 2DC38669F2; Thu, 18 Mar 2021 08:01:38 +0000 (UTC) Received: from work.redhat.com (ovpn-112-180.ams2.redhat.com [10.36.112.180]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7029262951; Thu, 18 Mar 2021 08:01:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1616054586; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=uqLBj1IbVjxrPatZNLb+on3Be7U4bcMqHPBDeKd12p8=; b=TYsTLYuEFERFXYqUFsF/bsS09q3sVXy6WBPH/XNWlVAwTNHcMoTWpJhG6JsCLE3DNknV7F JEobhDfcZhhAALzZttuaNKfi4SgXLy5BsGHUFZ/HNOD9v88R/khcOT58FsAqYgw0/aZAaC yx/Z+kSXGiVLdJDFRyIUOl0XHxVKP7A= X-MC-Unique: gPW5lSuIMMa_T48kG7RxUQ-1 From: Tim Wiederhake To: libvir-list@redhat.com Subject: [libvirt PATCH 14/38] domain_conf: Use virXMLProp(OnOff|YesNo) in virDomainChrSourceDefParseFile Date: Thu, 18 Mar 2021 09:00:53 +0100 Message-Id: <20210318080117.70255-15-twiederh@redhat.com> In-Reply-To: <20210318080117.70255-1-twiederh@redhat.com> References: <20210318080117.70255-1-twiederh@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com Cc: Tim Wiederhake X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 1cec2edde7..d9330f9ee7 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -11808,17 +11808,13 @@ static int virDomainChrSourceDefParseFile(virDomainChrSourceDefPtr def, xmlNodePtr source) { - g_autofree char *append =3D NULL; - - def->data.file.path =3D virXMLPropString(source, "path"); + virTristateSwitch append =3D VIR_TRISTATE_SWITCH_ABSENT; =20 - if ((append =3D virXMLPropString(source, "append")) && - (def->data.file.append =3D virTristateSwitchTypeFromString(append)= ) <=3D 0) { - virReportError(VIR_ERR_INTERNAL_ERROR, - _("Invalid append attribute value '%s'"), - append); + if (virXMLPropOnOff(source, "append", &append) < 0) return -1; - } + + def->data.file.path =3D virXMLPropString(source, "path"); + def->data.file.append =3D append; =20 return 0; } --=20 2.26.2